Rename DotnetTestProtocol source package to Microsoft.Testing.Platform.Internal.DotnetTest

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14

[Amaury Levé (Evangelink)]

What

Renames the cross-repo source-sharing package from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, making it a single, generically-named internal package for the dotnet test ↔ Microsoft.Testing.Platform integration rather than one package per shared contract.

The package is currently unused (not consumed anywhere yet), so the rename is safe.

Why

• We only have one real consumer for this shared source: dotnet/sdk's dotnet test. There's no need for a package-per-contract; a single package can host everything we share (today the wire contract; soon the terminal reporter).
• The Internal segment — together with the existing IsShipping=false and DevelopmentDependency=true — makes it unmistakable that this is an implementation detail, not a public client library. (A public MTP client/orchestration NuGet was proposed in Make client for MTP and publish it as nuget #5667; that's a separate effort, now closed pending a concrete use case.)

Changes

• Package id + folder: …DotnetTestProtocol → …Internal.DotnetTest.
• Updated PACKAGE.md and PackageDescription to describe the generic internal scope.
• Updated TestFx.slnx.
• The protocol contract .props (DotnetTestProtocolContract.props) and its standalone consumer test are unchanged — only the package wrapper is renamed.

Verification

dotnet pack produces Microsoft.Testing.Platform.Internal.DotnetTest.2.3.0-dev.nupkg (NonShipping) with both contract files shipped as contentFiles/cs/any/DotnetTestProtocol/*.cs (buildAction="Compile"). No dangling references to the old id remain.

Follow-up

Add the terminal reporter contract (TerminalReporterContract.props + TerminalResources.resx/xlf via a build-extension .props) to this same package once #9249 merges.

[Copilot]

Pull request overview

This PR renames the internal, source-sharing NuGet package used for cross-repo dotnet test ↔ Microsoft.Testing.Platform integration from Microsoft.Testing.Platform.DotnetTestProtocol to Microsoft.Testing.Platform.Internal.DotnetTest, clarifying that it’s a single internal package intended to host multiple shared integration contracts over time.

Changes:

• Updated the main solution (TestFx.slnx) to reference the renamed package project path.
• Added the new package’s PACKAGE.md and updated the .csproj description/commentary to reflect the broader “internal dotnet test integration” scope.
• Removed the old package PACKAGE.md.

Show a summary per file

File	Description
TestFx.slnx	Switches solution reference to the renamed internal package project path.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/PACKAGE.md	Introduces updated package readme describing the internal, source-only, cross-repo scope.
src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj	Updates package metadata/commentary for the renamed internal package.
src/Platform/Microsoft.Testing.Platform.DotnetTestProtocol/PACKAGE.md	Removes the old package readme as part of the rename.

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:23

• The XML comment says "*ContractCompile=false" but the actual MSBuild property used by this project is DotnetTestProtocolContractCompile (see the property set on line 31). Updating the comment avoids confusion when someone tries to find the controlling property.

• Files reviewed: 4/4 changed files
• Comments generated: 0

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 21/22 dimensions clean — one NIT only.

#	Dimension	Verdict
17	Documentation Accuracy	🔵 1 NIT

---

NIT — Documentation Accuracy

src/Platform/Microsoft.Testing.Platform/ServerMode/DotnetTest/DotnetTestProtocolContract.props was intentionally left unchanged by this PR, but now carries a stale comment (line 29):

- The Microsoft.Testing.Platform.DotnetTestProtocol package project sets
DotnetTestProtocolContractCompile=false and instead packs ...

After this rename the consumer is Microsoft.Testing.Platform.Internal.DotnetTest, not Microsoft.Testing.Platform.DotnetTestProtocol. A future contributor following the comment will look for the wrong project. Updating this one line in the same PR (or a quick follow-up) would close the gap cleanly.

---

All other dimensions — contextual assessment:

This PR is a pure package-wrapper rename (folder, .csproj, PACKAGE.md, TestFx.slnx). No logic, no IPC wire format, no public API, no test changes.

• Public API / Binary Compat (§4) — LGTM. IsShipping=false + explicitly unused → no consumer breakage.
• IPC Wire Compatibility (§19) — LGTM. Contract files (ObjectFieldIds.cs, Constants.cs) are untouched. The contentFiles/cs/any/DotnetTestProtocol/ subfolder name inside the package is intentionally preserved — it reflects the underlying protocol, not the wrapper package name, and avoids a content-path break for the eventual dotnet/sdk consumer.
• Build Infrastructure (§20) — LGTM. TestFx.slnx updated. No filtered .slnf referenced the old project (verified), so nothing was missed there.
• Scope & PR Discipline (§21) — LGTM. Single concern, well-described rationale, cites #5667 for the separate public-API effort.
• Remaining dimensions (§1–3, §5–16, §18, §22) — N/A for a non-logic, non-test, non-script rename.

[Petr Pokorny (0101)]

Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.

[Amaury Levé (Evangelink)]

The failing Debug test legs were not caused by this PR — they are a repo-wide regression affecting every PR built after #9248.

Root cause:#9246 moved the terminal test-run summary strings into the new TerminalResources.resx (translations carried over, CI green). The subsequent OneLocBuild check-in #9248 then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, so the summary labels (total/failed/succeeded/skipped, Test run summary:) rendered in English regardless of locale and broke LocalizationTests/LocalizationFailingTests.

I cherry-picked the fix (restore the 13 TerminalResources.*.xlf files to their #9246 translated state) onto this branch so CI is unblocked. The same fix is also proposed standalone in #9252 — once that merges to main, this duplicate commit will drop out on rebase (or feel free to drop it and rely on #9252).

[Copilot]

Copilot's findings

Comments suppressed due to low confidence (1)

src/Platform/Microsoft.Testing.Platform.Internal.DotnetTest/Microsoft.Testing.Platform.Internal.DotnetTest.csproj:24

• The comment refers to "*ContractCompile=false" but the actual property controlling this behavior in this project is DotnetTestProtocolContractCompile. Using the real property name here will make the packing/compile behavior clearer (and searchable) for future maintainers.

• Files reviewed: 17/17 changed files
• Comments generated: 14