Uh oh!
There was an error while loading. Please reload this page.
Restore TerminalResources translations wiped by OneLocBuild (#9248) - #9252
Merged
Amaury Levé (Evangelink) merged 1 commit intoJun 19, 2026
Conversation
…t#9248) microsoft#9246 extracted the terminal test-run summary strings into the new TerminalResources.resx and switched TerminalTestReporter to use it, with the translations carried over (its CI was green). The subsequent OneLocBuild check-in (microsoft#9248) then reset every TerminalResources.*.xlf entry from state="translated" back to state="new" with the English source as the target, because the localization database did not yet know about the freshly added resource. As a result, all TerminalTestReporter summary output (e.g. "Test run summary:", and the total/failed/succeeded/skipped labels) rendered in English regardless of locale, breaking LocalizationTests and LocalizationFailingTests on every PR built after microsoft#9248. This restores the 13 TerminalResources.*.xlf files to their microsoft#9246 (translated) state. A future OneLocBuild run will reconcile them once the loc database is updated. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 19, 2026
Merged
Contributor
There was a problem hiding this comment.
✅ Ready to approve
Only a minor formatting nit was found (trailing whitespace in one localized multi-line string), with no functional concerns identified.
Note: this review does not count toward required approvals for merging.
Pull request overview
This PR restores localized TerminalResources XLIFF entries that were reset by OneLocBuild (#9248), fixing localization test failures where the terminal test-run summary rendered in English for non-English locales.
Changes:
- Restores translated
<target state="translated">…</target>values across theTerminalResources.*.xlfsatellite files (13 locales). - Reverts the OneLocBuild “translated → new/English placeholder” regression for terminal summary strings.
File summaries
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.cs.xlf | Restores Czech translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.de.xlf | Restores German translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.es.xlf | Restores Spanish translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.fr.xlf | Restores French translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.it.xlf | Restores Italian translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ja.xlf | Restores Japanese translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ko.xlf | Restores Korean translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.pl.xlf | Restores Polish translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.pt-BR.xlf | Restores Portuguese (Brazil) translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ru.xlf | Restores Russian translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.tr.xlf | Restores Turkish translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.zh-Hans.xlf | Restores Chinese (Simplified) translations for terminal reporter resource strings. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.zh-Hant.xlf | Restores Chinese (Traditional) translations for terminal reporter resource strings. |
Copilot's findings
- Files reviewed: 13/13 changed files
- Comments generated: 1
Note
Your feedback helps us improve the quality of this feature.
Please use 👍 or 👎 to tell us whether this assessment is correct.
Comment on lines
+139
to
+140
| <target state="translated">Detalhamento da saída ao relatar testes | ||
| Os valores válidos são “Normal”, “Detailed”. O padrão é “Normal”.</target> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LocalizationTests/LocalizationFailingTests(the Debug Linux/Windows test legs) are failing on every PR built after #9248 — e.g. #9233, #9250. The MTP terminal test-run summary renders in English regardless of locale:Note the verdict word (
Correcta!) is localized — it still comes fromPlatformResources. Only the strings that #9246 moved toTerminalResourcesare English.Root cause
TerminalResources.resx, switchedTerminalTestReporterto use it, and carried the translations across (its CI was green ✅).TerminalResources.*.xlfentry fromstate="translated"(e.g.Anulado) back tostate="new"with the English source as the target (e.g.Aborted) — because the localization database did not yet know about the freshly-added resource.So at runtime the localized satellites contain English placeholders for all
TerminalResourcesstrings, breaking the localization tests.Fix
Restore the 13
TerminalResources.*.xlffiles to their #9246 (translated) state. A future OneLocBuild run will reconcile them once the loc DB is updated.This unblocks all PRs currently red on the Debug legs (#9233, #9250, …).