Unify MTP terminal reporter to handle 1..N assemblies

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

What

Converts the Microsoft.Testing.Platform terminal test reporter from a single-assembly model to a multi-assembly (1..N) model, so a single shared source can render both the in-process MTP host (one assembly) and the dotnet test orchestrator (N child assemblies).

This is the prerequisite called out in the terminal-sharing effort (follow-up to the protocol-sharing PRs #9218 / #9231 and the package PRs #9249 / #9250 / #9253): the SDK currently hard-forks the reporter because the shared MTP copy was single-assembly. With this change the reporter core exposes the multi-assembly API the SDK needs.

How

• Replace the single TestProgressState + _assembly/_targetFramework/_architecture fields with a ConcurrentDictionary<string, TestProgressState> _assemblies keyed by a caller-provided execution id. The in-process host passes one fixed id; the orchestrator passes one per child assembly.
• Route TestCompleted / TestInProgress / TestDiscovered / AssemblyRunStarted / AssemblyRunCompleted / ArtifactAdded per execution id.
• Aggregate the run and discovery summaries across all assemblies. N=1 (in-process) output stays byte-identical via an assemblies.Count == 1 branch that still appends the per-assembly link to the verdict line; for N>1 the verdict line is link-free (per-assembly identity lives in the progress area).
• Expand TestRunArtifact and ArtifactAdded with assembly / targetFramework / architecture / executionId.
• Add a TotalTests aggregate and surface isHelp / isRetry on TestExecutionStarted.
• Adapt the in-process caller (TerminalOutputDevice) to the new API using a single fixed InProcessExecutionId.

Scope / deferred

The SDK-orchestrator-only surface — handshake-failure recap, instanceId-based retry counting, build-error tracking, and exit-code-in-summary — is intentionally not ported here. That logic depends on the SDK's richer TestProgressState retry model and is only exercised by real multi-process runs, so it cannot be verified from the in-process unit tests. It will land with the SDK plug-in PR where it can be driven and tested end-to-end against actual N-assembly runs.

Verification

• Platform builds clean on net8.0 / net9.0 / netstandard2.0 (0 warnings).
• Full Microsoft.Testing.Platform.UnitTests suite green: 1197 total, 0 failed — the 94 existing byte-exact terminal tests confirm the in-process UI is unchanged.
• New TerminalTestReporter_WhenMultipleAssemblies_AggregatesCountsAndOmitsAssemblyLinkOnVerdict test covers the N>1 path (aggregated counts + link-free verdict).
• The standalone TerminalReporterContract consumer still compiles in isolation (the Share dotnet test wire contract (ObjectFieldIds + Constants) as source #9218-equivalent gate).

[Copilot]

Pull request overview

This PR updates the Microsoft.Testing.Platform terminal reporter to support a multi-assembly (1..N) execution model (keyed by execution id), while preserving byte-identical output for the existing single-assembly in-process host.

Changes:

• Replace single-assembly reporter state with a per-execution-id map and aggregate run/discovery summaries across assemblies.
• Extend reporter events/artifact tracking to carry assembly identity (assembly/TFM/architecture/executionId) and route events by execution id.
• Update the in-process TerminalOutputDevice and unit tests to use the new multi-assembly reporter API; add a dedicated multi-assembly aggregation test.

Show a summary per file

File	Description
test/UnitTests/Microsoft.Testing.Platform.UnitTests/OutputDevice/Terminal/TerminalTestReporterTests.cs	Updates tests for new reporter APIs and adds a multi-assembly aggregation test.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.SessionLifecycle.cs	Adapts in-process session lifecycle to call multi-assembly reporter methods using a fixed execution id.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.Initialization.cs	Introduces an in-process execution id constant and updates reporter construction for the new API.
src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs	Routes test state/artifacts into reporter with the in-process execution id and richer artifact metadata.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestRunArtifact.cs	Expands artifact record to include assembly identity fields.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs	Stores the full assembly path/display name for later linking and summary formatting.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.TestCompletion.cs	Keys TestCompleted handling by execution id and looks up per-assembly state.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Summary.cs	Aggregates counts across assemblies and removes verdict-line assembly link when N>1.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Messaging.cs	Keys TestInProgress by execution id for multi-assembly progress rendering.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs	Adds multi-assembly lifecycle APIs and clears per-assembly state on completion.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Formatting.cs	Updates assembly link formatting to operate on an assembly-run state instance.
src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs	Removes single-assembly constructor inputs, adds per-assembly dictionary state and richer ArtifactAdded.

Copilot's findings

Comments suppressed due to low confidence (2)

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:205

• The TestCompleted argument indentation in the TimeoutTestNodeStateProperty case has an extra leading space compared to the surrounding blocks, which can trigger IDE0055 (formatting) during builds with code-style enforcement.

 case TimeoutTestNodeStateProperty timeoutState:
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Timeout,
duration,

src/Platform/Microsoft.Testing.Platform/OutputDevice/TerminalOutputDevice.DataConsumption.cs:223

• The TestCompleted argument indentation in the CancelledTestNodeStateProperty case is inconsistent (extra leading space), which may trigger IDE0055 formatting diagnostics when code style is enforced in build.

#pragma warning disable CS0618, MTP0001 // Type or member is obsolete
case CancelledTestNodeStateProperty cancelledState:
#pragma warning restore CS0618, MTP0001 // Type or member is obsolete
_terminalTestReporter.TestCompleted(
InProcessExecutionId,
testNodeStateChanged.TestNode.Uid.Value,
testNodeStateChanged.TestNode.DisplayName,
TestOutcome.Canceled,
duration,

• Files reviewed: 12/12 changed files
• Comments generated: 5

[Amaury Levé (Evangelink)]

🔍 Build Failure Analysis

Summary — The build of Microsoft.Testing.Platform.csproj fails due to three distinct analyzer violations introduced in the OutputDevice/Terminal/ area: two SA1623 violations (property XML doc summaries not starting with "Gets") and one IDE0052 violation (a private field that is assigned but never read).

---

Root cause 1 — SA1623: Property doc summaries missing "Gets" prefix

SA1623 requires that the <summary> of any property with a getter must begin with the word "Gets" (e.g. /// <summary>Gets the ...</summary>). Two new properties were added with prose-style summaries that omit this prefix — both are lifted to errors by TreatWarningsAsErrors in this project.

Affected locations

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TestProgressState.cs:23 — SA1623 on the new Assembly property
• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.cs:67 — SA1623 on the new TotalTests property

Fix — prepend Gets to each <summary>:

// TestProgressState.cs:23
- /// <summary>The assembly path or display name as provided by the caller (used for the summary link).</summary>+ /// <summary>Gets the assembly path or display name as provided by the caller (used for the summary link).</summary>
// TerminalTestReporter.cs:67
- /// <summary>Total number of tests across all registered assemblies.</summary>+ /// <summary>Gets the total number of tests across all registered assemblies.</summary>

---

Root cause 2 — IDE0052: _isRetry field is write-only

[IDE0052]((learn.microsoft.com/redacted) fires when a private member is assigned but never read. _isRetry was introduced in TerminalTestReporter.Lifecycle.cs, assigned in TestExecutionStarted, but consumed nowhere — unlike its sibling _isHelp, which is already read in TestExecutionCompleted to suppress the summary when --help is active.

Affected location

• src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/TerminalTestReporter.Lifecycle.cs:12 — IDE0052 on _isRetry

Fix — remove the field and its assignment. If retry-specific behaviour is planned, add the corresponding read-site (e.g. in TestExecutionCompleted) and keep the field; otherwise also remove the bool isRetry parameter from TestExecutionStarted and update callers.

 private bool _isHelp;
- private bool _isRetry;
public void TestExecutionStarted(DateTimeOffset testStartTime, int workerCount, bool isDiscovery, bool isHelp, bool isRetry)
{
_isDiscovery = isDiscovery;
_isHelp = isHelp;
- _isRetry = isRetry;
_testExecutionStartTime = testStartTime;

---

Build overview

MSBuild	18.7.0-preview
Duration	154 s
Projects	45
Errors	10 (3 unique issues, each repeated across multiple TFMs)
Warnings	0

All errors originate in Microsoft.Testing.Platform.csproj. The failures of Microsoft.Testing.Extensions.AzureDevOpsReport, Microsoft.Testing.Extensions.CrashDump, and MSTest.TestAdapter are cascades from that single project.

All MSBuild errors (3 unique, 10 total across TFMs)

Code	File	Line	Message
SA1623	TestProgressState.cs	24	The property's documentation summary text should begin with: 'Gets'
SA1623	TerminalTestReporter.cs	68	The property's documentation summary text should begin with: 'Gets'
IDE0052	TerminalTestReporter.Lifecycle.cs	12	Private member _isRetry can be removed as the value assigned to it is never read

---

_{🤖 Generated by the Build Failure Analysis workflow · commit 476750cda2a7f588e1e5476448945f10789afff4}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · [◷]( · ◷)

[Amaury Levé (Evangelink)]

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 246.3 AIC · ⌖ 12.8 AIC · ⊞ 46.9K · ◷

[Amaury Levé (Evangelink)]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Review Summary

The multi-assembly generalisation is well-designed: the ConcurrentDictionary approach, the single InProcessExecutionId constant for the in-process host, the assemblies.Count == 1 branch that keeps byte-identical single-assembly output, and the new aggregating test — all read cleanly. The 94 byte-exact existing tests continuing to pass confirms the in-process path is unchanged.

One MAJOR correctness regression was found in the factory pattern, plus two MODERATE dead-API issues and two NITs.

---

#	Dimension	Verdict	File	Line
2	Threading & Concurrency	🔴 1 MAJOR	TerminalTestReporter.Lifecycle.cs	26–37
15	Code Structure	🟡 2 MODERATE	TerminalTestReporter.Lifecycle.cs	12, 23
5	Performance & Allocations	🔵 1 NIT	TerminalTestReporter.cs	68
8	Defensive Coding	🔵 1 NIT	TerminalTestReporter.Lifecycle.cs	50

✅ 18/22 dimensions clean.

---

Findings

• [MAJOR – Threading]GetOrAdd(key, valueFactory) can invoke the factory more than once for the same key if two threads race (the inner lock serialises the invocations sequentially but does not prevent both from running). Both invocations call AddWorker, occupying two slots; only one TestProgressState is kept in the dictionary, leaking the other's progress slot permanently. Current callers guarantee unique IDs so the race is not reachable today, but the pattern is a correctness regression from the old double-checked locking. Replace with TryGetValue / lock / TryGetValue / _assemblies[key] = ... DCL. See inline comment.

• [MODERATE – Dead API]instanceId is accepted by AssemblyRunStarted but never forwarded or stored. If keeping it as scaffolding, add a // Reserved for SDK retry logic comment; otherwise remove and re-introduce with its consumer.

• [MODERATE – Dead Code]_isRetry is assigned in TestExecutionStarted but never read anywhere in the partial class. _isHelp has a consumer; _isRetry does not. Remove or add an explanatory comment.

• [NIT – Performance]TotalTests property lambda should use static for consistency with all other lambdas in this file: Sum(static a => a.TotalTests).

• [NIT – Dead Param]exitCode in TestExecutionCompleted is never stored. A short inline comment noting this is deferred to the SDK plug-in PR would be enough.

[Copilot]

Copilot's findings

• Files reviewed: 12/12 changed files
• Comments generated: 1

[Amaury Levé (Evangelink)]

🧪 Test quality grade — PR #9256

Δ	Test	Grade	Band	Notes
new	TerminalTestReporterTests. TerminalTestReporter_ WhenReusedAcrossSessions_ DoesNotLeakArtifactsOrCancelledState	B	80–89	3 meaningful assertions cover both leak vectors; body is ~42 lines — consider a session-run helper to trim setup verbosity.

_{This advisory comment was generated automatically. Grades are heuristic
and informational — they do not block merging. Re-run with
/grade-tests.}

🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Grade Tests on PR (on open / sync) workflow. · 464 AIC · ⌖ 13.2 AIC · ⊞ 45.6K · [◷]( · ◷)