Uh oh!
There was an error while loading. Please reload this page.
Remove terminal-exclusive resource keys now served by TerminalResources - #9260
Conversation
#9246/#9253 extracted the terminal reporter strings into TerminalResources (shipped with the Internal.DotnetTest source package). 32 of those keys were left duplicated in PlatformResources purely to avoid churn; they now have zero PlatformResources.<key> references in src or test and are absent from the hand-maintained !IS_CORE_MTP accessor block, so the copies are dead. Remove the 32 keys from PlatformResources.resx and regenerate all 13 xlf via UpdateXlf (pure deletions). The 12 keys still referenced through PlatformResources (e.g. Aborted, Failed, ZeroTestsRan, the ActiveTestsRunning_* progress strings) are intentionally kept. Verified: platform rebuilds clean on net8.0/net9.0/netstandard2.0 (0 warnings); representative extensions (MSBuild, TrxReport) build clean; full Microsoft.Testing.Platform.UnitTests suite green (1198, 0 failed). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR is a localization/resource cleanup in Microsoft.Testing.Platform (MTP) that removes terminal-reporter resource keys from PlatformResources now that those strings are served by TerminalResources (to reduce duplication and keep the platform-wide resource set focused).
Changes:
- Removed terminal-reporter-specific
<data>entries fromPlatformResources.resx. - Removed the corresponding
<trans-unit>entries from the localizedPlatformResources.*.xlffiles (pure deletions aligned with the.resx). - Kept
PlatformResources.cs’s cross-assembly accessor surface unchanged (no new keys added there).
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/Resources/PlatformResources.resx | Removes terminal-only resource keys that are now owned by TerminalResources. |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.cs.xlf | Deletes localized trans-units for removed keys (Czech). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.de.xlf | Deletes localized trans-units for removed keys (German). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.es.xlf | Deletes localized trans-units for removed keys (Spanish). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.fr.xlf | Deletes localized trans-units for removed keys (French). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.it.xlf | Deletes localized trans-units for removed keys (Italian). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ja.xlf | Deletes localized trans-units for removed keys (Japanese). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ko.xlf | Deletes localized trans-units for removed keys (Korean). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pl.xlf | Deletes localized trans-units for removed keys (Polish). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.pt-BR.xlf | Deletes localized trans-units for removed keys (Portuguese - Brazil). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.ru.xlf | Deletes localized trans-units for removed keys (Russian). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.tr.xlf | Deletes localized trans-units for removed keys (Turkish). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hans.xlf | Deletes localized trans-units for removed keys (Chinese - Simplified). |
| src/Platform/Microsoft.Testing.Platform/Resources/xlf/PlatformResources.zh-Hant.xlf | Deletes localized trans-units for removed keys (Chinese - Traditional). |
Copilot's findings
- Files reviewed: 14/14 changed files
- Comments generated: 1
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Review Summary
All claims in the PR description have been independently verified against the live repo. The change is a clean, well-scoped resource deduplication with no issues found.
Verification Findings
Removed key count confirmed:git diff HEAD~1 HEAD shows exactly 32 keys removed from PlatformResources.resx (225 → 193 entries). Each of the 13 xlf files has a uniform 178 lines deleted, consistent with machine-generation via UpdateXlf.
All 32 removed keys exist in TerminalResources.resx: Verified with a per-key grep — every one of the 32 keys scores count=1 in TerminalResources.resx. No key was orphaned.
Zero PlatformResources.* references to removed keys:grep -r "PlatformResources\.(Actual|CancelledLowercase|ConsoleIsAlreadyInBatchingMode|...)" --include="*.cs" src/ test/ returned 0 hits. The only occurrences of those identifier strings in .cs files are in TerminalResources.cs (the new home).
PlatformResources.cs!IS_CORE_MTP accessor block is clean: None of the 32 removed keys appear as properties. The hand-maintained block exposes only the still-present keys (InternalLoopAsyncDidNotExitSuccessfullyErrorMessage and the IS_MTP_UNIT_TESTS sub-block covering Aborted, Failed, Passed, TotalLowercase, FailedLowercase, SucceededLowercase, SkippedLowercase, ZeroTestsRan, ActiveTestsRunning_*, and a set of PlatformCommandLine* keys).
12 "kept duplicate" keys verified correct: All 12 (Aborted, CancellingTestSession, PressCtrlCAgainToForceExit, Failed, FailedLowercase, Passed, SkippedLowercase, TotalLowercase, ZeroTestsRan, ActiveTestsRunning_MoreTestsCount, ActiveTestsRunning_FullTestsCount, SucceededLowercase) are still present in PlatformResources.resx (count=1 each) and are actively referenced via PlatformResources.* in non-terminal platform code and unit tests (e.g. SimplifiedConsoleOutputDeviceBase.cs, TestRunSummaryHelperTests.cs).
XLF format spot-check:PlatformResources.cs.xlf opens with the standard XLIFF 1.2 header, and entries follow the machine-generated <trans-unit id="..."><source>...</source><target state="...">...</target><note /></trans-unit> schema. No sign of manual editing.
22-Dimension Verdict Table
| # | Dimension | Status | Notes |
|---|---|---|---|
| 1 | Algorithmic Correctness | ✅ | Zero PlatformResources.* refs to any removed key confirmed by grep |
| 2 | Logic / Semantics | ✅ | Pure deletion — no logic changes |
| 3 | Naming & Conventions | N/A | No new names introduced |
| 4 | Code Clarity | ✅ | Eliminates dead duplication |
| 5 | Performance | N/A | |
| 6 | Memory / Resource Management | N/A | |
| 7 | Error Handling | N/A | |
| 8 | Security | N/A | No secrets, no input handling |
| 9 | Test Coverage | ✅ | Full unit test suite green (1198/0 per commit message); removed keys not referenced in tests |
| 10 | Localization Done Right | ✅ | 13 xlf files regenerated via UpdateXlf; 178 lines deleted per file (consistent); machine-generated format confirmed |
| 11 | Backward Compatibility | ✅ | All resources are internal; !IS_CORE_MTP accessor block unchanged; no public API affected |
| 12 | Thread Safety | N/A | |
| 13 | Async / Await | N/A | |
| 14 | Dependency Management | N/A | |
| 15 | Build / Project Config | N/A | |
| 16 | Documentation | N/A | |
| 17 | Scope Discipline | ✅ | Exactly 14 files (1 resx + 13 xlf), all pure deletions, single concern |
| 18 | Kept-Duplicate Correctness | ✅ | All 12 claimed-kept keys present in resx and actively used by non-terminal code |
| 19 | Cross-Assembly Surface (!IS_CORE_MTP) | ✅ | None of the 32 removed keys appear as properties in the hand-maintained accessor block |
| 20 | Resource Consistency (resx ↔ TerminalResources) | ✅ | Every removed key confirmed present in TerminalResources.resx (count=1 each) |
| 21 | Public API | ✅ | PlatformResources is internal static partial class; no public surface affected |
| 22 | Commit Quality | ✅ | Detailed commit message with reproduction steps and verification evidence |
Overall: ✅ No blocking issues. The PR achieves exactly what it claims.
What
Removes 32 terminal-reporter resource keys from
PlatformResourcesthat were left duplicated after the terminal strings were extracted intoTerminalResources(#9246 / #9253, shipped as source in theMicrosoft.Testing.Platform.Internal.DotnetTestpackage).This is the resource-cleanup follow-up tracked alongside the terminal-sharing effort (#9246 → #9256).
Why these 32 are safe to remove
For each removed key I verified:
PlatformResources.<key>references anywhere insrc/ortest/— the terminal code now reads them fromTerminalResources.!IS_CORE_MTPaccessor block inPlatformResources.cs(the block that extension projects and theIS_MTP_UNIT_TESTSpath consume), so the cross-assembly surface is unaffected.The 12 still-referenced duplicates (
Aborted,CancellingTestSession,PressCtrlCAgainToForceExit,Failed,FailedLowercase,Passed,SkippedLowercase,TotalLowercase,ZeroTestsRan,ActiveTestsRunning_MoreTestsCount,ActiveTestsRunning_FullTestsCount,SucceededLowercase) are intentionally kept because non-terminal platform code still uses them viaPlatformResources.How
<data>entries fromPlatformResources.resx.PlatformResources.*.xlfviadotnet msbuild .../Microsoft.Testing.Platform.csproj /t:UpdateXlf(pure deletions — no manual xlf edits).Verification
PlatformResources.cs(Microsoft.Testing.Platform.MSBuild,Microsoft.Testing.Extensions.TrxReport) build clean.Microsoft.Testing.Platform.UnitTestssuite green: 1198 total, 0 failed.PlatformResources.resxvalidated as well-formed XML; UTF-8 BOM preserved; diff is pure deletions across the resx + 13 xlf.