Uh oh!
There was an error while loading. Please reload this page.
Temporarily disable LocalizationTests/LocalizationFailingTests so loc can flow (#9295) - #9296
Conversation
OneLocBuild auto check-ins keep reverting the TerminalResources.*.xlf targets back to English, which XliffTasks bakes into the fr/es satellite assemblies, making these acceptance tests fail on main on every loc check-in. Disable both classes via [Ignore] so loc PRs can flow and the downstream pipeline can produce proper translations. Re-enable per #9295. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Temporarily disables the Microsoft.Testing.Platform acceptance localization coverage by ignoring the two classes that validate localized terminal summary output, to unblock recurring OneLocBuild auto check-ins that currently revert TerminalResources.*.xlf targets back to English.
Changes:
- Add a class-level
[Ignore]toLocalizationTestswith an issue link explaining the temporary disablement. - Add a class-level
[Ignore]toLocalizationFailingTestswith the same rationale and tracking link.
Show a summary per file
| File | Description |
|---|---|
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/LocalizationTests.cs | Adds a class-level [Ignore] (with issue link) to temporarily disable localization acceptance tests. |
| test/IntegrationTests/Microsoft.Testing.Platform.Acceptance.IntegrationTests/LocalizationFailingTests.cs | Adds a class-level [Ignore] (with issue link) to temporarily disable failing-case localization acceptance tests. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Amaury Levé (Evangelink)
commented
Jun 20, 2026
🧪 Test quality grade — PR #9296No new or modified test methods were identified in the changed regions of this PR. Nothing to grade. The only changes are a class-level Re-run with
|
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
✅ 22/22 dimensions clean — no findings.
Went through all applicable dimensions for this two-file, test-only change:
| Dimension | Verdict |
|---|---|
| Localization & Resources | ✅ Root cause clearly explained; [Ignore] is the right tool while OneLocBuild cannot yet deliver translated xlf files. |
| Test Isolation | ✅ [Ignore] at the class level is AttributeTargets.Class-valid in MSTest and correctly suppresses all test methods, [ClassInitialize]/[ClassCleanup], and (critically) the heavy TestAssetFixture asset-generation pipeline — no spurious build work will occur on CI. |
| Flakiness Patterns | ✅ This is a deliberate, bounded suppression of a genuine infrastructure-driven failure (OneLocBuild repeatedly clobbering TerminalResources.*.xlf), not a hide-the-flake pattern. |
| Test Completeness & Coverage | ✅ Temporary removal is tracked by #9295 with a concrete re-enable condition (proper xlf checked in). |
| Code Structure & Simplification | ✅ Attribute placement, comment style, and message content are all clear. |
| Naming & Conventions | ✅ [Ignore("reason")] usage is idiomatic MSTest; the code comment is a plain explanatory note (not a TODO keyword), so the TODO(#N) policy is satisfied. |
| Documentation Accuracy | ✅ Both the inline comment and the [Ignore] reason string reference #9295 accurately. |
| Scope & PR Discipline | ✅ Minimal, focused change; PR description is thorough; "Closes nothing; tracked by #9295" is the honest, correct framing. |
| All other dimensions | ✅ N/A (no algorithmic, concurrency, security, public-API, performance, resource-management, or build-infra changes). |
Amaury Levé (Evangelink)
commented
Jun 20, 2026
🔍 Build Failure AnalysisSummary — The build fails with 4 Root cause: |
| Line | Method | Error |
|---|---|---|
1468 | AssemblyRunCompleted_WhenKnownAssemblyFails_PrintsExecutableSummary | IDE0008: Use explicit type instead of 'var' |
1492 | AssemblyRunCompleted_WhenKnownAssemblySucceeds_DoesNotPrintExecutableSummary | IDE0008: Use explicit type instead of 'var' |
1513 | TestExecutionCompleted_WhenHandshakeFailures_PrintsRecapAndFailsRun | IDE0008: Use explicit type instead of 'var' |
1537 | AssemblyRunStarted_AfterRetry_RendersLatestAttemptCounts | IDE0008: Use explicit type instead of 'var' |
Proposed fix — replace var with TerminalTestReporter at each of the four call sites (CreateOrchestratorReporter is declared as private static TerminalTestReporter CreateOrchestratorReporter(...)):
- var terminalReporter = CreateOrchestratorReporter(stringBuilderConsole);+ TerminalTestReporter terminalReporter = CreateOrchestratorReporter(stringBuilderConsole);(apply identically to lines 1468, 1492, and 1537; line 1513 has an extra named argument but the same var → TerminalTestReporter change)
Note: Because
TerminalTestReporterTests.csis not part of this PR's diff, no inline suggestion can be posted here. The fix can be included as an additional commit in this PR or applied directly tomainin a separate patch PR.
Build overview
| Field | Value |
|---|---|
| MSBuild | 18.7.0-preview |
| Duration | 243.9 s |
| Projects | 46 |
| Errors | 9 (4 unique locations × 2 TFMs) |
| Warnings | 0 |
| Failed project | Microsoft.Testing.Platform.UnitTests.csproj |
| Failed target | CoreCompile |
The project builds for two target frameworks, so each of the 4 errors is reported twice (8 IDE0008 + 1 "Build failed." = 9 total).
All MSBuild errors (4 unique)
| Code | File | Line | Message |
|---|---|---|---|
IDE0008 | TerminalTestReporterTests.cs | 1468 | Use explicit type instead of 'var' |
IDE0008 | TerminalTestReporterTests.cs | 1492 | Use explicit type instead of 'var' |
IDE0008 | TerminalTestReporterTests.cs | 1513 | Use explicit type instead of 'var' |
IDE0008 | TerminalTestReporterTests.cs | 1537 | Use explicit type instead of 'var' |
🤖 Generated by the Build Failure Analysis workflow using [binlog-mcp]((dev.azure.com/redacted) · commit 0c97b68
🤖 Automated content by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Build Failure Analysis workflow. · 291.6 AIC · ⌖ 13.9 AIC · ⊞ 49.5K · [◷]( · ◷)
Petr Pokorny (0101)
left a comment
There was a problem hiding this comment.
Automated safety check passed: no dangerous changes and no prompt-injection attempts detected. Approving as requested. Note: this is a quick safety sanity check, not a full code review.
Uh oh!
There was an error while loading. Please reload this page.
Temporarily
[Ignore]theLocalizationTestsandLocalizationFailingTestsacceptance tests.Why
The OneLocBuild auto check-in PRs (#9248, #9254, #9262, #9292, ...) repeatedly revert the
TerminalResources.*.xlf<target>text back to English (state="new"), becauseTerminalResources.resxis a new loc file (strings extracted/moved out ofPlatformResourcesin #9246, de-duped in #9260) that the downstream localization pipeline has not translated yet. WithLclSource: lclFilesInRepothe loc handback is the source of truth, so each OneLocBuild run re-clobbers the manually-restored translations.XliffTasks bakes that English
<target>text into the fr/es satellite assemblies, so the product genuinely emits English underDOTNET_CLI_UI_LANGUAGE=fr/es— which correctly fails these tests and turnsmainred on every loc check-in (see restore PRs #9252, #9261, #9288).What
Disable both test classes so the OneLocBuild PRs can flow and the downstream pipeline can produce proper
TerminalResourcestranslations. This is a temporary measure tracked by #9295; re-enable both classes once correct localized xlf are checked in.Closes nothing; tracked by #9295.