Neutralize test result recording in PlatformServices (Phase 6b) by Evangelink · Pull Request #9579 · microsoft/testfx

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink) · 2026-07-03T13:40:50Z

Phase 6b of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase makes the execution engine report results through the neutral ITestResultRecorder using UnitTestElement instead of the VSTest TestCase, and moves the VSTest result construction out of the engine to the adapter boundary.

What changed

ITestResultRecorder is now neutral: RecordStart / RecordEmptyResult / RecordResult take UnitTestElement (+ the framework TestResult) instead of a VSTest TestCase. The engine no longer references TestCase for recording.
Recorder created once at the boundary: MSTestExecutor (both RunTestsAsync overloads) builds the recorder via frameworkHandle.ToTestResultRecorder(Environment.MachineName, MSTestSettings.CurrentSettings) and injects it into TestExecutionManager (threaded through RunTestsAsync → ExecuteTestsAsync → _testResultRecorder → Runner). Removed the now-unused IEnvironment field/ctor param from the engine.
Moved VSTest result construction to MSTest.TestAdapter: TestResultExtensions.ToTestResult, UnitTestOutcomeHelper, and the recorder bridge TestResultRecorderExtensions (HostTestResultRecorder). The bridge resolves the host TestCase via the memoized UnitTestElement.GetOrCreateHostTestCase() handle.
IVT: added TestFramework → MSTest.TestAdapter (result construction reads internal framework TestResult members + DebugEx/StringEx), and MSTest.TestAdapter → MSTestAdapter.PlatformServices.UnitTests (engine/result unit tests reach the moved internal bridge).

Byte-for-byte fidelity (no behavior change)

Normal results still record against the original host TestCase (via GetOrCreateHostTestCase()), preserving host-injected TCM / data-collector properties; cleanup-failure results still use AssociatedUnitTestElement.ToTestCase(). RecordStart/RecordResult observe the same memoized TestCase per test.
Environment.MachineName at the boundary equals the previous EnvironmentWrapper.Instance.MachineName.
The neutral recorder wraps the same IFrameworkHandle with the same computerName + MSTestSettings as before.

Verification

Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462), MSTestAdapter.UnitTests: 21 — all pass.
MSTest.IntegrationTests: 47 passed / 1 skipped (the skipped OutputIsNotMixedWhenTestsRunInParallel is the known CI-excluded parallel-output timing flake).
Reviewed by the expert MSTest/MTP reviewer: no correctness/fidelity/ordering/public-API findings.

Base / review order

Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), and Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576). This PR was developed stacked on 6a; 6a has since merged into the base, so the diff here is 6b only (13 files).
Draft for now.

Remaining work (later phases)

6c: host contexts + AppDomain message-logger neutralization (hardest).
6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
6e: remaining misc ObjectModel usages.
7: remove the Microsoft.TestPlatform.ObjectModel PackageReference from MSTestAdapter.PlatformServices.csproj + guard test.

Make the execution engine report results through the platform-agnostic ITestResultRecorder using neutral UnitTestElement instead of VSTest TestCase, and move the VSTest result construction out of MSTestAdapter.PlatformServices up into the MSTest.TestAdapter boundary. - ITestResultRecorder now takes UnitTestElement (RecordStart/RecordEmptyResult/ RecordResult); the engine no longer references TestCase for recording. - Recorder is created once at the adapter boundary (MSTestExecutor) and injected into TestExecutionManager, instead of being built inside the engine. - Moved TestResultExtensions, UnitTestOutcomeHelper and the recorder bridge (TestResultRecorderExtensions) into MSTest.TestAdapter; the bridge resolves the host TestCase via UnitTestElement.GetOrCreateHostTestCase so normal-result TRX/TCM/data-collector properties stay byte-for-byte identical. - Added TestFramework -> MSTest.TestAdapter InternalsVisibleTo (result construction reads internal framework TestResult members). Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Amaury Leveque <amauryleve@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

…ervices Squashed rebase of the vstest-decoupling PlatformServices stack onto main. Phases 1, 2 and 5 already landed on main via #9548/#9567/#9550; this commit carries the remaining net-new work: - Phase 3 (#9566): abstract the VSTest discovery sink (IUnitTestElementSink). - Phase 4 (#9572): abstract VSTest execution input. - Phase 6a (#9576): neutralize deployment input (DeploymentContext). - Phase 6b (#9579): neutralize test result recording (ITestResultRecorder). - Phase 6c (#9585): neutralize test message logging. - Phase 6c2: neutralize run-settings input in the host layer (settingsXml). - Phase 6d-1: move test-case filter parsing to the adapter boundary (ITestElementFilterProvider / TestElementFilterProvider). - Phase 6d-2: remove IRunContext/IDiscoveryContext from PlatformServices. - Phase 6e-1 (#9622): remove IFrameworkHandle from the execution engine. - Phase 6e-2 (#9623): relocate VSTest logger/sink bridges to the adapter. - Phase 6e-3a (#9624): neutralize the trait type on UnitTestElement. Result: MSTestAdapter.PlatformServices no longer references the VSTest run/discovery context or result object model; those types live only at the MSTest.TestAdapter boundary. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Amaury Levé (Evangelink)force-pushed the dev/amauryleve/vstest-decoupling-recorder branch from 0f14cbd to 502d7feCompare July 3, 2026 13:42

Amaury Levé (Evangelink) marked this pull request as ready for review July 3, 2026 14:14

Amaury Levé (Evangelink) added the state/needs-review Awaiting review from the team. label Jul 3, 2026

Petr Pokorny (0101) approved these changes Jul 3, 2026
View reviewed changes

Amaury Levé (Evangelink) merged commit 371124a into dev/amauryleve/vstest-decoupling-baseJul 3, 2026
36 of 45 checks passed