Neutralize test message logging in PlatformServices execution engine (Phase 6c)

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.

[Amaury Levé (Evangelink)]

Phase 6c of the PlatformServices platform-agnostic initiative

Part of the effort to remove the VSTest object model (Microsoft.TestPlatform.ObjectModel) dependency from MSTestAdapter.PlatformServices, moving VSTest coupling up into MSTest.TestAdapter.

This phase neutralizes the test message logger: it replaces the VSTest IMessageLogger with the platform-agnostic IAdapterMessageLogger (introduced in Phase 1) throughout the execution engine, test-context, and class-cleanup paths — including the logger marshaled into the isolation host (child AppDomain) for RunSingleTest.

What changed

• RemotingMessageLogger now implements IAdapterMessageLogger instead of VSTest IMessageLogger (still MarshalByRefObject on netfx). It wraps a parent-domain IAdapterMessageLogger and forwards SendMessage(MessageLevel, string). Marshaling stays by reference — the wrapped logger never crosses into the child domain, and MessageLevel is a serializable enum, so no VSTest type is needed child-side.
• IPlatformServiceProvider.GetTestContext, UnitTestRunner.RunSingleTest(Async)/ForceCleanup, ClassCleanupManager.ForceCleanup, TestContextImplementation (field + ctor), and InitializeRandomTestOrder now take IAdapterMessageLogger.
• TestContext.DisplayMessage forwards MessageLevel directly to the neutral logger (the MessageLevel→TestMessageLevel conversion now happens once, at the boundary bridge).
• The engine obtains the neutral logger via frameworkHandle.ToAdapterMessageLogger() at the same points it already used for discovery.

No behavior change

The same messages cross the same AppDomain boundary to the same host logger; MessageLevel maps 1:1 to TestMessageLevel at the bridge. The non-AppDomain path is unchanged. The single remaining VSTest logging reference in PlatformServices is the AdapterMessageLoggerExtensions bridge, to be relocated with the other bridges in a later phase.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTestAdapter.UnitTests: 21 — all pass.
• MSTest.IntegrationTests (net462, exercises AppDomain-isolated execution → child-domain logging via the marshaled logger): 47 passed / 1 skipped / 0 failed.
• Expert MSTest/MTP reviewer: no correctness/marshaling/fidelity/public-API findings.

Base

• Base = dev/amauryleve/vstest-decoupling-base, which already contains Phase 3 (Abstract VSTest discovery sink in PlatformServices (Phase 3 of platform-agnostic effort) #9566), Phase 4 (Abstract VSTest execution input in PlatformServices (Phase 4 of platform-agnostic effort) #9572), Phase 6a (Neutralize deployment input in PlatformServices (Phase 6a of platform-agnostic effort) #9576), and Phase 6b (Neutralize test result recording in PlatformServices (Phase 6b) #9579). Developed stacked on 6b; 6b has since merged into the base, so the diff here is 6c only (13 files).

Remaining work (later phases)

• Host run-contexts/settings (IRunContext/IRunSettings/IDiscoveryContext; CreateTestSourceHost(IRunSettings)).
• 6d: filter internals (folds in Avoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568).
• 6e: relocate remaining bridges (recorder/deployment/logger/message-level).
• 7: remove the Microsoft.TestPlatform.ObjectModel PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

✅ 22/22 dimensions clean — no findings.

---

Reviewed against all 22 dimensions. This is a clean, mechanical decoupling of IMessageLogger (VSTest) in favour of IAdapterMessageLogger (platform-agnostic) across 13 files. Key observations that were verified:

Correctness — The MessageLevel → TestMessageLevel conversion is now centralised in exactly one place (AdapterMessageLoggerExtensions.HostMessageLogger.SendMessage). All call sites pass MessageLevel directly. The DisplayMessage simplification to _messageLogger?.SendMessage(messageLevel, message) is semantically equivalent to the six-line version it replaces.

AppDomain marshaling (netfx) — RemotingMessageLogger is MarshalByRefObject on .NET Framework; the wrapped IAdapterMessageLogger stays in the parent domain. Only MessageLevel (a serializable enum) and string cross the AppDomain boundary. Correct.

Threading — _adapterMessageLogger in the override partial class is written once (synchronously) before base.RunTestsAsync starts any parallel workers, then read in the downstream async continuation. Write-before-read in a single async chain — no race. Parallel test workers capture adapterMessageLogger (a local) by closure; SendMessage calls are concurrent but the VSTest host logger they ultimately reach is thread-safe.

! null-forgiving — _adapterMessageLogger! in ExecuteTestsAsync override is safe because RunTestsAsync always initialises it before calling base.RunTestsAsync, which is the only path that invokes the override.

Cross-TFM — #if NETFRAMEWORK guard on MarshalByRefObject is correct. Non-netfx stub provided.

Test assertions — MSTestAdapter.PlatformServices.UnitTests bans MSTest Assert; the updated tests correctly use AwesomeAssertions + Moq. Mocks set up with It.IsAny<MessageLevel>() and verified with specific MessageLevel values — correct.

Diff artefact in UnitTestRunner.cs (cosmetic) — Hunk 3 (ForceCleanup) shows the IMessageLogger signature as an unchanged context line alongside identical -/+ lines for the IAdapterMessageLogger version. This is a git diff alignment artefact from the stacked-PR base; the compiled result has only one ForceCleanup signature taking IAdapterMessageLogger. No action needed.

Removed using System.Diagnostics.CodeAnalysis — Safe: [NotNullWhen] was already removed from TestContextImplementation in a prior phase, making the directive dead code. Correct cleanup.