Remove IFrameworkHandle from the PlatformServices execution engine (Phase 6e-1)

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.

[Amaury Levé (Evangelink)]

Phase 6e-1 of the PlatformServices platform-agnostic initiative

Part of removing the VSTest object model dependency from MSTestAdapter.PlatformServices.

The execution engine used the VSTest IFrameworkHandle (from ObjectModel.Adapter) exclusively to obtain an IAdapterMessageLogger via .ToAdapterMessageLogger(). This phase replaces the IFrameworkHandle parameter with the neutral IAdapterMessageLogger throughout TestExecutionManager (both RunTestsAsync overloads, ExecuteTestsAsync, ExecuteTestsInSourceAsync, Deploy); the boundary (MSTestExecutor) now calls frameworkHandle.ToAdapterMessageLogger() once and injects the result.

This removes the last ObjectModel.Adapter reference from the execution engine (IFrameworkHandle is now entirely absent from PlatformServices).

No behavior change

ToAdapterMessageLogger() returns a stateless HostMessageLogger (single readonly field forwarding to the same underlying VSTest logger), so collapsing the previous per-call-site wrappers into one shared instance is observationally identical — including for the RemotingMessageLogger that marshals it into the child AppDomain.

Verification

• Full build green across all TFMs (net462, net8.0, net9.0, UWP, WinUI).
• MSTestAdapter.PlatformServices.UnitTests: 897 (net8.0) / 935 (net462); MSTest.IntegrationTests: 47 pass / 1 skip.
• Expert MSTest/MTP reviewer: no material findings; confirmed statelessness/instance-equivalence and the child-AppDomain marshaling are byte-for-byte.

Base / stacking

Stacked on Phase 6d-2 (#9621). Base = dev/amauryleve/vstest-decoupling-runcontext.

Remaining work (6e continues)

• Relocate the neutral-boundary bridges (AdapterMessageLoggerExtensions, MessageLevel, UnitTestElementSinkExtensions, TestCaseExtensions) to MSTest.TestAdapter.
• The deep UnitTestElement↔TestCase conversion (ToTestCase/GetOrCreateHostTestCase) + EngineConstants VSTest TestProperty defs + TcmTestPropertiesProvider; closeAvoid double TestCase construction when filtering during discovery/execution (platform-agnostic refactor follow-up) #9568/CloneWithUpdatedSource mutates this instead of the returned clone #9573.
• Settings/utility residuals (XmlRunSettingsUtilities, Constants, SuspendCodeCoverage, the typeof(TestCase) version check).
• Phase 7: drop the Microsoft.TestPlatform.ObjectModel (+ ObjectModel.Utilities) PackageReference + guard test.

[github-actions]

Note

🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.

Expert Review — PR #9622 · Phase 6e-1: Remove IFrameworkHandle from execution engine

#	Dimension	Verdict
1	Algorithmic Correctness	✅ LGTM
2	Threading & Concurrency	✅ LGTM
3	Security & IPC Contract Safety	— N/A
4	Public API & Binary Compatibility	— N/A (all internal)
5	Performance & Allocations	✅ LGTM (minor improvement: 1 wrapper/run instead of 2–4)
6	Cross-TFM Compatibility	✅ LGTM
7	Resource & IDisposable Management	— N/A
8	Defensive Coding at Boundaries	✅ LGTM
9	Localization & Resources	— N/A
10	Test Isolation	✅ LGTM
11	Assertion Quality	✅ LGTM (AwesomeAssertions, per BannedSymbols.txt)
12	Flakiness Patterns	— N/A
13	Test Completeness & Coverage	✅ LGTM
14	Data-Driven Test Coverage	— N/A
15	Code Structure & Simplification	🟡 2 NIT (inline)
16	Naming & Conventions	✅ LGTM
17	Documentation Accuracy	✅ LGTM
18	Analyzer & Code Fix Quality	— N/A
19	IPC Wire Compatibility	— N/A
20	Build Infrastructure & Dependencies	— N/A
21	Scope & PR Discipline	✅ LGTM
22	PowerShell Scripting Hygiene	— N/A

✅ 13/13 applicable dimensions clean — 2 NIT items flagged inline.

---

Notes

Correctness confirmation:HostMessageLogger is a stateless value-object (single readonly field delegating directly to the underlying IMessageLogger). Collapsing multiple per-call-site ToAdapterMessageLogger() invocations into one shared instance at the adapter boundary is byte-for-byte equivalent. The RemotingMessageLogger cross-AppDomain wrapper correctly wraps any IAdapterMessageLogger, so the shared-instance pattern is safe there too.

Threading: The shared adapterMessageLogger instance is used across parallel workers in ExecuteTestsInSourceAsync. Since HostMessageLogger.SendMessage is a pure delegation and IMessageLogger implementations provided by VSTest hosts are thread-safe, no race condition is introduced.

2 NIT items (inline): Both TestExecutionManager.Parallelization.cs:68 and TestExecutionManager.cs:133 now hold trivial local-variable aliases (adapterMessageLogger = messageLogger and logger = messageLogger). These were meaningful before (each called frameworkHandle.ToAdapterMessageLogger()); now they're no-op assignments. A follow-up cleanup would rename the parameter or remove the local and update downstream uses within the method — both are purely cosmetic.

[github-actions]

NIT (Dim 15 — Code Structure): Same trivial alias pattern as in ExecuteTestsInSourceAsync: logger is now identically equal to messageLogger. This line was meaningful before (it called frameworkHandle.ToAdapterMessageLogger()) but is now dead.

Follow-up cleanup: rename the parameter or remove the local and update the handful of downstream uses in this method.

[github-actions]

NIT (Dim 15 — Code Structure):adapterMessageLogger is now a trivial alias for the incoming parameter messageLogger; the two names exist only because the earlier code called frameworkHandle.ToAdapterMessageLogger() here to produce a new wrapper.

Follow-up cleanup option: rename the parameter from messageLogger to adapterMessageLogger (matching the existing local variable) and drop this assignment, keeping the rest of the method body unchanged. Alternatively, remove the local and replace all downstream uses of adapterMessageLogger with messageLogger. Either way no behavior change.