Skip to content

Add an event to edit the CSP - #15730

Merged
rullzer merged 1 commit into
masterfrom
enh/14179/event_for_csp
Jul 9, 2019
Merged

Add an event to edit the CSP#15730
rullzer merged 1 commit into
masterfrom
enh/14179/event_for_csp

Conversation

@rullzer

@rullzerrullzer commented May 24, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Fixes#14179

This introduces and event that can be listend to when we actually use
the CSP. This means that apps no longer have to always inject their CSP
but only do so when it is required. Yay for being lazy.

Todo:

  • Tests
  • Documentation

@rullzerrullzer added this to the Nextcloud 17 milestone May 24, 2019
kesselb
kesselb reviewed May 26, 2019
View reviewed changes
Comment threadlib/public/Security/CSP/AddCSPPolicyEvent.php Outdated
@rullzerrullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels May 27, 2019
MorrisJobke
MorrisJobke approved these changes May 31, 2019
View reviewed changes

@MorrisJobkeMorrisJobke left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense 👍

kesselb
kesselb reviewed Jun 16, 2019
View reviewed changes
Comment threadlib/public/IServerContainer.php Outdated
kesselb
kesselb reviewed Jun 16, 2019
View reviewed changes
Comment threadlib/public/Security/IContentSecurityPolicyManager.php Outdated
kesselb
kesselb reviewed Jun 16, 2019
View reviewed changes
Comment threadlib/public/Security/IContentSecurityPolicyManager.php Outdated
@ChristophWurst
ChristophWurstforce-pushed the enh/14179/event_for_csp branch from de5db59 to 0518ff1CompareJune 17, 2019 07:43
@rullzer
rullzerforce-pushed the enh/14179/event_for_csp branch from 0518ff1 to 8af4c5bCompareJune 27, 2019 20:42
ChristophWurst
ChristophWurst approved these changes Jul 5, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise 👍

Comment threadlib/public/Security/IContentSecurityPolicyManager.php Outdated
Comment threadlib/public/Security/IContentSecurityPolicyManager.php Outdated
@rullzer
rullzerforce-pushed the enh/14179/event_for_csp branch from 8af4c5b to 905bf3fCompareJuly 8, 2019 12:51
@rullzer
Add an event to edit the CSP
5ac857b
This introduces and event that can be listend to when we actually use
the CSP. This means that apps no longer have to always inject their CSP
but only do so when it is required. Yay for being lazy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the enh/14179/event_for_csp branch from 905bf3f to 5ac857bCompareJuly 8, 2019 18:35
@rullzerrullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 8, 2019
@rullzer
rullzer merged commit 5cef895 into masterJul 9, 2019
@delete-merged-branch
delete-merged-branchBot deleted the enh/14179/event_for_csp branch July 9, 2019 08:59
@MorrisJobke

MorrisJobke commented Jul 9, 2019

Copy link
Copy Markdown
Member
  • Documentation

😉

@rullzer

rullzer commented Jul 9, 2019

Copy link
Copy Markdown
MemberAuthor

Yeah it is on my whiteboard list ;)

MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
da43209
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke mentioned this pull request Aug 10, 2020
Merged
backportbot-nextcloudBot pushed a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke@backportbot
Document existing events
6ca7040
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
7e78e7e
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
6da5114
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselbkesselbkesselb left review comments
@MorrisJobkeMorrisJobkeMorrisJobke approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@nickvergessennickvergessenAwaiting requested review from nickvergessen
@juliusknorrjuliusknorrAwaiting requested review from juliusknorr

Assignees

No one assigned

Labels

4. to releaseReady to be released and/or waiting for tests to finishenhancement

Projects

None yet

Milestone

Nextcloud 17

Development

Successfully merging this pull request may close these issues.

Content security policy on non-TemplateResponses

4 participants

@rullzer@MorrisJobke@ChristophWurst@kesselb