Skip to content

config.php setting to always accept internal shares - #18384

Merged
rullzer merged 1 commit into
masterfrom
fix/18255/global_config_to_always_accept
Dec 16, 2019
Merged

config.php setting to always accept internal shares#18384
rullzer merged 1 commit into
masterfrom
fix/18255/global_config_to_always_accept

Conversation

@rullzer

@rullzerrullzer commented Dec 12, 2019

Copy link
Copy Markdown
Member

Part of #18255

Setting this new setting to true basically reverts back to the pre 18 behavior by just always accepting the internal shares.

@rullzerrullzer added enhancement 3. to review Waiting for reviews labels Dec 12, 2019
@rullzerrullzer added this to the Nextcloud 18 milestone Dec 12, 2019
This was referenced Dec 12, 2019
Merged
Closed
nickvergessen
nickvergessen reviewed Dec 12, 2019
View reviewed changes
Comment threadapps/files_sharing/lib/Listener/GlobalShareAcceptanceListener.php
@nickvergessen

nickvergessen commented Dec 12, 2019

Copy link
Copy Markdown
Member

I would instead just check the config directly in these two places:

server/lib/private/Share20/DefaultShareProvider.php

Line 150 in 5bf3d1b

$qb->setValue('accepted', $qb->createNamedParameter(IShare::STATUS_PENDING));

server/lib/private/Share20/DefaultShareProvider.php

Line 539 in 5bf3d1b

$qb = $this->dbConn->getQueryBuilder();

@rullzerrullzer mentioned this pull request Dec 16, 2019
Merged
34 tasks
ChristophWurst
ChristophWurst approved these changes Dec 16, 2019
View reviewed changes

@ChristophWurstChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@rullzer
rullzerforce-pushed the fix/18255/global_config_to_always_accept branch from 418237b to e4df82cCompareDecember 16, 2019 08:01
@rullzer
config.php setting to always accept internal shares
bb4264c
Part of #18255
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
rullzerforce-pushed the fix/18255/global_config_to_always_accept branch from e4df82c to bb4264cCompareDecember 16, 2019 08:07
@rullzer
rullzer merged commit 3b8fbf1 into masterDec 16, 2019
@rullzer
rullzer deleted the fix/18255/global_config_to_always_accept branch December 16, 2019 08:50
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
da43209
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobkeMorrisJobke mentioned this pull request Aug 10, 2020
Merged
backportbot-nextcloudBot pushed a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke@backportbot
Document existing events
6ca7040
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
7e78e7e
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke added a commit to nextcloud/documentation that referenced this pull request Aug 10, 2020
@MorrisJobke
Document existing events
6da5114
* LoadAdditionalScripts (@rullzer) - nextcloud/server#16641
* LoadViewerEvent (@skjnldsv) - nextcloud/viewer#271
* RegisterDirectEditorEvent (@juliushaertl) - nextcloud/server#17625
* typed events for files scanner (@ChristophWurst) - nextcloud/server#18351
* typed events for group mangement (@ChristophWurst) - nextcloud/server#18350
* AddContentSecurityPolicyEvent (@rullzer) - nextcloud/server#15730
* UserLiveStatusEvent (@georgehrke) - nextcloud/server#21186
* password_policy events (@ChristophWurst) - nextcloud/server#18019
* AddFeaturePolicyEvent (@rullzer) - nextcloud/server#16613
* ShareCreatedEvent (@rullzer) - nextcloud/server#18384
* LoadSettingsScriptsEvent (@blizzz) - nextcloud/server#21475
* flow events (@rullzer) - nextcloud/server#18535
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickvergessennickvergessennickvergessen left review comments
@icewind1991icewind1991icewind1991 approved these changes
@ChristophWurstChristophWurstChristophWurst approved these changes
@jospoortvlietjospoortvlietAwaiting requested review from jospoortvliet
@karlitschekkarlitschekAwaiting requested review from karlitschek
@wiswedelwiswedelAwaiting requested review from wiswedel
@skjnldsvskjnldsvAwaiting requested review from skjnldsv

Assignees

No one assigned

Labels

3. to reviewWaiting for reviewsenhancement

Projects

None yet

Milestone

Nextcloud 18.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rullzer@nickvergessen@icewind1991@ChristophWurst