Skip to content

fix(files): unexpected checksum header in multipart uploads caused by S3 default integrity change in AWS SDK for PHP - #56078

Merged
kesselb merged 1 commit into
nextcloud:fix/56077/s3-configure-checksum-defaultsfrom
cfiehe:fix/56077
Oct 30, 2025
Merged

fix(files): unexpected checksum header in multipart uploads caused by S3 default integrity change in AWS SDK for PHP#56078
kesselb merged 1 commit into
nextcloud:fix/56077/s3-configure-checksum-defaultsfrom
cfiehe:fix/56077

Conversation

@cfiehe

Copy link
Copy Markdown

Summary

This commit makes the configuration settings request_checksum_calculation and response_checksum_validation of the S3Client from the AWS SDK for PHP configurable via the objectstore S3 configuration section of the config.php. Allowed values are when_required and when_supported (new default since AWS SDK for PHP >= 3.337.0).

Signed-off-by: Fiehe Christoph c.fiehe@eurodata.de

This commit makes the configuration settings 'request_checksum_calculation' and 'response_checksum_validation' of the S3Client from the AWS SDK for PHP configurable.
Signed-off-by: Fiehe Christoph <c.fiehe@eurodata.de>

@skjnldsvskjnldsv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code make sense

@kesselb

Copy link
Copy Markdown
Contributor

@kesselb
kesselb changed the base branch from master to fix/56077/s3-configure-checksum-defaultsOctober 30, 2025 10:54
@nextcloudnextcloud deleted a comment from miaulalalaOct 30, 2025
@kesselb
kesselb merged commit 39c5999 into nextcloud:fix/56077/s3-configure-checksum-defaultsOct 30, 2025
1 of 2 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbackport-requestbugfeature: object storagefeedback-requestedpending documentationThis pull request needs an associated documentation update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected checksum header in multipart uploads caused by S3 default integrity change in AWS SDK for PHP >= v3.337.0

5 participants

@cfiehe@kesselb@miaulalala@skjnldsv@tobiasKaminsky