fix(s3): make data integrity protections opt-in

[kesselb]

Summary

Follow up for nextcloud/documentation#13875, #56096 and #56078.

The AWS SDK shipped with Nextcloud 32 does enable it by default. That only works if your S3 implementation does support it. Otherwise, you are unable to upload new files. Therefore we are turning it off by default.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[kesselb]

/backport to stable32

[kesselb]

cc @cfiehe

[come-nc]

🐘

[kesselb]

/backport to stable32

[kesselb]

Documentation update nextcloud/documentation#14039

[skjnldsv]

@kesselb@provokateurin do you think this also apply to external storage S3 ?

[kesselb]

@skjnldsv should be because the trait is used by primary storage and external.

We didn't add a UI option, but occ works:

occ files_external:config <id> request_checksum_calculation when_supported
occ files_external:config <id> request_checksum_calculation when_required

If you are unsure if the s3 backend is reading the value at all, try:

occ files_external:config <id> request_checksum_calculation blub (or any other random string. minio for example responds with an error, when uploading a file, that either when_supported or when_required is supported).

[skjnldsv]

Yes, I saw that in the code.
I'll check it out and see if we need to add that option in the UI too :)

Thanks!! 🙏