Skip to content

fix(s3): expose request_checksum_calculation and response_checksum_va… - #56096

Merged
provokateurin merged 1 commit into
masterfrom
fix/56077/s3-configure-checksum-defaults
Nov 3, 2025
Merged

fix(s3): expose request_checksum_calculation and response_checksum_va…#56096
provokateurin merged 1 commit into
masterfrom
fix/56077/s3-configure-checksum-defaults

Conversation

@kesselb

@kesselbkesselb commented Oct 30, 2025

Copy link
Copy Markdown
Contributor

Summary

Fix#56077

Local version of #56078 for a full CI run with adjusted commit message and fixed dco (the commit itself was fine, just the branch weeks behind).

This commit makes the configuration settings 'request_checksum_calculation' and 'response_checksum_validation' of the S3Client from the AWS SDK for PHP configurable.

TODO

  • CI

Checklist

…lidation
Fix#56077
This commit makes the configuration settings 'request_checksum_calculation' and 'response_checksum_validation' of the S3Client from the AWS SDK for PHP configurable.
Signed-off-by: Fiehe Christoph <c.fiehe@eurodata.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
@kesselbkesselb added this to the Nextcloud 33 milestone Oct 30, 2025
@kesselbkesselb self-assigned this Oct 30, 2025
@kesselb
kesselb requested a review from a team as a code ownerOctober 30, 2025 11:00
@kesselbkesselb added bug 3. to review Waiting for reviews labels Oct 30, 2025
@kesselb
kesselb requested review from leftybournes and yemkareems and removed request for a teamOctober 30, 2025 11:00
@kesselb

Copy link
Copy Markdown
ContributorAuthor

/backport to stable32

@kesselbkesselb added the pending documentation This pull request needs an associated documentation update label Oct 30, 2025
@provokateurin
provokateurin merged commit e3edf43 into masterNov 3, 2025
202 of 206 checks passed
@provokateurin
provokateurin deleted the fix/56077/s3-configure-checksum-defaults branch November 3, 2025 10:08
@kesselb

Copy link
Copy Markdown
ContributorAuthor

Update for the release notes at nextcloud/documentation#13875

@kesselbkesselb removed the pending documentation This pull request needs an associated documentation update label Nov 21, 2025
@nextcloud-botnextcloud-bot mentioned this pull request Jan 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to reviewWaiting for reviewsbug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Unexpected checksum header in multipart uploads caused by S3 default integrity change in AWS SDK for PHP >= v3.337.0

3 participants

@kesselb@miaulalala@provokateurin