Skip to content

tools: fix lint issue in doctool - #11658

Closed
silverwind wants to merge 1 commit into
nodejs:masterfrom
silverwind:fix-lint
Closed

tools: fix lint issue in doctool#11658
silverwind wants to merge 1 commit into
nodejs:masterfrom
silverwind:fix-lint

Conversation

@silverwind

@silverwindsilverwind commented Mar 2, 2017

Copy link
Copy Markdown
Contributor

Fixes a lint issue introduced in #11167.

cc: @jasnell

@silverwindsilverwind added the tools Issues and PRs related to the tools directory. label Mar 2, 2017
@nodejs-github-botnodejs-github-bot added the tools Issues and PRs related to the tools directory. label Mar 2, 2017
@silverwindsilverwind mentioned this pull request Mar 2, 2017
Closed
3 tasks
@addaleax

addaleax commented Mar 2, 2017

Copy link
Copy Markdown
Member

Doesn’t the linter catch issues in tools/doc/?

@silverwind

silverwind commented Mar 2, 2017

Copy link
Copy Markdown
ContributorAuthor

It does, but I simply forgot to run it after my latest change in that PR. Running make test now and will land afterwards.

jasnell
jasnell approved these changes Mar 2, 2017
View reviewed changes

@jasnelljasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's fast track this to unbreak CI

@jasnell

jasnell commented Mar 2, 2017

Copy link
Copy Markdown
Member

CI Linter: https://ci.nodejs.org/job/node-test-linter/7369/

jasnell pushed a commit that referenced this pull request Mar 2, 2017
@silverwind@jasnell
tools: fix lint issue in doctool
172be50
PR-URL: #11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Mar 2, 2017

Copy link
Copy Markdown
Member

Landed in 172be50

@jasnelljasnell closed this Mar 2, 2017
@silverwind

silverwind commented Mar 2, 2017

Copy link
Copy Markdown
ContributorAuthor

Thanks @jasnell. For the record, the issue happened because my workflow on that PR was basically

rm out/doc/api && make doc-only && make docopen

I'll have to remember to actually run tests on that type of change too, because tests partially cover the doctool

@silverwind
silverwind deleted the fix-lint branch March 2, 2017 17:56
@jasnell

jasnell commented Mar 2, 2017

Copy link
Copy Markdown
Member

It's all good. I just did a lint check on this particular PR. You make want to do a full CI run just to make sure that everything else is still good.

@silverwind

silverwind commented Mar 2, 2017

Copy link
Copy Markdown
ContributorAuthor

make test passed locally, so it should be good.

@evanlucas

evanlucas commented Mar 7, 2017

Copy link
Copy Markdown
Contributor

This is not landing cleanly on v7.x-staging. Mind submitting a backport PR?

@silverwind

silverwind commented Mar 7, 2017

Copy link
Copy Markdown
ContributorAuthor

There's three PRs that should land in tandem, I will do a backport once the last one lands.

#11167
#11658
#11697

silverwind added a commit to silverwind/node that referenced this pull request Mar 8, 2017
@silverwind
tools: fix lint issue in doctool
6e0d53b
PR-URL: nodejs#11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@silverwindsilverwind mentioned this pull request Mar 8, 2017
Closed
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 13, 2017
@silverwindItalo A. Casas
tools: fix lint issue in doctool
5a9e30f
PR-URL: nodejs#11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Apr 17, 2017

Copy link
Copy Markdown
Contributor

do we want to backport to v6.x?

@silverwind

silverwind commented May 16, 2017

Copy link
Copy Markdown
ContributorAuthor

Backport in #13054

gibfahn pushed a commit that referenced this pull request May 16, 2017
@silverwind@gibfahn
tools: fix lint issue in doctool
5fd1593
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahngibfahn mentioned this pull request May 16, 2017
Closed
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@silverwind@MylesBorins
tools: fix lint issue in doctool
7135a7b
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
silverwind added a commit to silverwind/node that referenced this pull request May 18, 2017
@silverwind
tools: fix lint issue in doctool
8098f49
PR-URL: nodejs#11658
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit to gibfahn/node that referenced this pull request Jun 17, 2017
@silverwind@gibfahn
tools: fix lint issue in doctool
e70cb6a
PR-URL: nodejs#11658
Backport-PR-URL: nodejs#13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
@silverwind@gibfahn
tools: fix lint issue in doctool
c881b2c
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
@silverwind@MylesBorins
tools: fix lint issue in doctool
beb8485
PR-URL: #11658
Backport-PR-URL: #13054
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Jul 18, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@lpincalpincalpinca approved these changes

Assignees

No one assigned

Labels

toolsIssues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@silverwind@addaleax@jasnell@evanlucas@MylesBorins@lpinca@gibfahn@nodejs-github-bot