doc: fix more type case inconsistencies

[silverwind]

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

Turns out I missed quite a few types in ff13619 because my sed skills weren't up to par. This commit should fix all remaining issues with primitive type cases.

I also made the syntax with multiple types consistent by removing any whitespace between curly braces. If more people prefer {type | type | type} over {type|type|type}, I can also change to that.

Type replacement was done with:

sed -i -E 's#(\{|\|)\s+?(Boolean|Null|Undefined|Number|String|Symbol)\s+?(\||\})#\1\L\2\3#g' *.md

[TimothyGu]

Integer needs to be fixed as well

[silverwind]

Integer is not a valid type. Shall we change them all to number?

[addaleax]

I think it would make sense to be specific to keep Integer here because it doesn’t really make sense to pass in non-integer numbers here… the upper-casing is a bit weird but I’d be okay with it, as long as we try to be consistent

(also /cc @ameliavoncat whose awesome PRs also touch these parts of the docs and who might want to keep track of this discussion)

[silverwind]

Yeah, I guess it's better to keep it as-is. Per our rule discussed in the last PR, everything except the six primitives should be uppercased.

[TimothyGu]

@silverwind in your commit that changed the case in the doctool, Integer was changed to integer. Either way it doesn't seem right to me that number and integer have different cases.

[silverwind]

I think I'll move it out of jsPrimitives and into typeMap, possibly linking it to number docs.

[addaleax]

Can you drop the spaces before the colons in this file? We don’t do that anywhere else in the docs

[silverwind]

done

[silverwind]

@TimothyGud5d4274 fixes the Integer inconsistency in the doctool. I also added the missing undefined type, which results in a few new links in the doc. I still think we should keep it at Integer because we only lowercase the six primitives.

[TimothyGu]

I still think we should keep it at Integer because we only lowercase the six primitives.

But the issue at hand is that an integer is expressed as a number primitive.

I also just looked at a proposal in TypeScript to add integral types, and though not yet accepted, it also uses lower cased type name (int). And AFAICT, there isn't any disagreement in that thread about its capitalization.

[silverwind]

@TimothyGu okay, lowercased integer. I guess a argument could be made about it not being a valid constructor. It's really a odd type, but I see its value in documentation.

[silverwind]

Landed in 5f32024.

[MylesBorins]

Do we want to backport to v6.x?

[silverwind]

I'd say it's not strictly necessary, but it could make landing future doc backports easier.

Ideally, these commits should be landed in tandem:

ff13619
9be03a2
172be50
5f32024

[MylesBorins]

@silverwind would you be willing to put together a PR with those commits?

[silverwind]

@MylesBorins not right now, I'm busy on other projects. But if you can wait a bit, I can put something together later.

[silverwind]

Backport in #13054