Uh oh!
There was an error while loading. Please reload this page.
(v6.x backport) doc types fixes - #13054
Closed
silverwind wants to merge 4 commits into
Closed
Conversation
This was referenced May 16, 2017
silverwind
commented
May 16, 2017
ContributorAuthor
Once this has landed #9532 should be attempted to be backported. |
gibfahn
commented
May 16, 2017
Member
This doesn't apply cleanly, I think because it was raised against @silverwind I've updated the base branch in this PR, could you rebase against |
silverwind
commented
May 16, 2017
ContributorAuthor
Meh, I was specifically asked to target |
silverwindforce-pushed
the
doc-types-backport
branch
from
May 16, 2017 17:03
d266701 to
356d59fComparesilverwind
commented
May 16, 2017
ContributorAuthor
How's it now? |
silverwindforce-pushed
the
doc-types-backport
branch
3 times, most recently
from
May 16, 2017 17:10
1c6abfb to
a207db0Comparesilverwind
commented
May 16, 2017
ContributorAuthor
(Fixed a few oversights) |
gibfahn
approved these changes
May 16, 2017
silverwindforce-pushed
the
doc-types-backport
branch
from
May 16, 2017 17:12
a207db0 to
9b0fb17CompareMember
gibfahn
commented
May 16, 2017
Member
FWIW the backporting guide should be clear about which branch to backport to, LMK if anything in that is unclear. |
PR-URL: nodejs#11658 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: nodejs#11697 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
silverwindforce-pushed
the
doc-types-backport
branch
from
May 18, 2017 16:36
11918c4 to
6014aa7Comparesilverwind
commented
May 18, 2017
ContributorAuthor
Done. I noticed docs for |
gibfahn pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
PR-URL: nodejs#11167 Backport-PR-URL: nodejs#13054 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
gibfahn pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
PR-URL: nodejs#11167 Backport-PR-URL: nodejs#13054 Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
gibfahn pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
PR-URL: nodejs#11658 Backport-PR-URL: nodejs#13054 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn pushed a commit
to gibfahn/node
that referenced
this pull request
Jun 17, 2017
- fix a number of uppercase types - lowercase 'integer' - consistent formatting in crypto PR-URL: nodejs#11697 Backport-PR-URL: nodejs#13054 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
vsemozhetbyt
commented
Jul 18, 2017
Contributor
@silverwind, @gibfahn There are some |
silverwind
commented
Jul 18, 2017
ContributorAuthor
Must've missed those. They are in |
vsemozhetbyt
commented
Jul 18, 2017
Contributor
@silverwind It seems only in |
silverwind added a commit
to silverwind/node
that referenced
this pull request
Jul 18, 2017
The backport in nodejs#13054 contained a leftover section from the WHATWG url.format, in addition to the existing url.format. This removes this section.
silverwind
commented
Jul 18, 2017
ContributorAuthor
Filed #14351 |
MylesBorins pushed a commit
that referenced
this pull request
Jul 18, 2017
The backport in #13054 contained a leftover section from the WHATWG url.format, in addition to the existing url.format. This removes this section.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport for these commits:
ff13619
9be03a2
172be50
5f32024
cc: @MylesBorins