Skip to content

repl: support top-level for-await-of - #23841

Closed
codebytere wants to merge 1 commit into
nodejs:masterfrom
codebytere:fix-for-await-of
Closed

repl: support top-level for-await-of#23841
codebytere wants to merge 1 commit into
nodejs:masterfrom
codebytere:fix-for-await-of

Conversation

@codebytere

@codebyterecodebytere commented Oct 24, 2018

Copy link
Copy Markdown
Member

Resolves#23836.

Ensures that visitors check for a for-of statement with await: true so that state.containsAwait is then properly handled.

/cc @devsnek

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Oct 24, 2018

Copy link
Copy Markdown
Collaborator

@codebytere build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1352/pipeline

@nodejs-github-botnodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Oct 24, 2018
@Trott

Trott commented Oct 24, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/18095/

@TrottTrott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 24, 2018
TimothyGu
TimothyGu approved these changes Oct 24, 2018
View reviewed changes
Comment threadlib/internal/repl/await.js
}
walk.base.ClassDeclaration(node, state, c);
},
ForOfStatement(node, state, c) {

@TimothyGuTimothyGuOct 24, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for parity with Chromium code, I would move this to right after AwaitExpression.

@Trott

Trott commented Oct 26, 2018

Copy link
Copy Markdown
Member

Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/18163/

@targos

targos commented Oct 28, 2018

Copy link
Copy Markdown
Member

Landed in 35f9cd2

@targostargos closed this Oct 28, 2018
targos pushed a commit that referenced this pull request Oct 28, 2018
@codebytere@targos
repl: support top-level for-await-of
35f9cd2
PR-URL: #23841Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 28, 2018
@codebytere@targos
repl: support top-level for-await-of
d6aeb1e
PR-URL: #23841Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targostargos added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 28, 2018
targos added a commit that referenced this pull request Oct 28, 2018
@targos
2018-10-30, Version 11.1.0 (Current)
3dfd630
Notable changes:
* deps
* Updated ICU to 63.1. #23715
* repl
* Top-level for-await-of is now supported in the REPL.
#23841
* timers
* Fixed an issue that could cause timers to enter an infinite loop.
#23870
PR-URL: #23922
@targostargos mentioned this pull request Oct 28, 2018
Merged
@codebytere
codebytere deleted the fix-for-await-of branch October 28, 2018 16:29
targos pushed a commit that referenced this pull request Nov 1, 2018
@codebytere@targos
repl: support top-level for-await-of
02f13ab
PR-URL: #23841Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos added a commit that referenced this pull request Nov 1, 2018
@targos
2018-11-02, Version 11.1.0 (Current)
af6d262
Notable changes:
* deps
* Updated ICU to 63.1. #23715
* repl
* Top-level for-await-of is now supported in the REPL.
#23841
* timers
* Fixed an issue that could cause timers to enter an infinite loop.
#23870
PR-URL: #23922
targos added a commit that referenced this pull request Nov 2, 2018
@targos
2018-11-02, Version 11.1.0 (Current)
74ba482
Notable changes:
* deps
* Updated ICU to 63.1. #23715
* repl
* Top-level for-await-of is now supported in the REPL.
#23841
* timers
* Fixed an issue that could cause timers to enter an infinite loop.
#23870
PR-URL: #23922
This was referenced Nov 2, 2018
Closed
Closed
Closed
Closed
@MylesBorins

MylesBorins commented Nov 26, 2018

Copy link
Copy Markdown
Contributor

This lands cleanly on 10.x but I'm unclear if this is Semver-Minor or Semver-Patch

can someone expand on why this did not land as a minor?

@Trott

Trott commented Nov 27, 2018

Copy link
Copy Markdown
Member

can someone expand on why this did not land as a minor?

Probably because everyone forgot to add the semver-minor label.

@MylesBorinsMylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 27, 2018
@MylesBorins

MylesBorins commented Nov 27, 2018

Copy link
Copy Markdown
Contributor

I've added the semver-minor label. If anyone thinks it should be removed please lmk

@imcotton

imcotton commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

@MylesBorins

So, will this Closed PR with later added semver-minor label, lands on v10 eventually? In terms of its lts-watch-v10.x from begin with?

Or does it just needs another cherry-picked PR to make the cut?

MylesBorins pushed a commit that referenced this pull request Mar 20, 2019
@codebytere@MylesBorins
repl: support top-level for-await-of
b9188d4
PR-URL: #23841Fixes: #23836
Reviewed-By: John-David Dalton <john.david.dalton@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

MylesBorins commented Mar 20, 2019

Copy link
Copy Markdown
Contributor

@imcotton the next 10.x release is Semver-Minor! I've landed this upstream in b9188d4, but this will need to be approved by the LTS team. So just to set expectations, there is a chance it could be backed out

@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
9bc1d75
Notable changes:
- deps:
- icu 63.1 bump (CLDR 34) (Steven R. Loomis)
[#23715](#23715)
- upgrade npm to 6.9.0 (Kat Marchán)
[#26244](#26244)
- upgrade openssl sources to 1.1.1a (Sam Roberts)
[#25381](#25381)
- upgrade to libuv 1.24.1 (cjihrig)
[#25078](#25078)
- events: add once method to use promises with EventEmitter
(Matteo Collina) [#26078](#26078)
- n-api: mark thread-safe function as stable (Gabriel Schulhof)
[#25556](#25556)
- repl: support top-level for-await-of (Shelley Vohr)
[#23841](#23841)
- zlib:
- add brotli support (Anna Henningsen)
[#24938](#24938)
PR-URL: #27514
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
308b8b9
Notable changes:
- **deps**:
- update ICU to 64.2 (Ujjwal Sharma)
[#27361](#27361)
- upgrade npm to 6.9.0 (Kat Marchán)
[#26244](#26244)
- upgrade openssl sources to 1.1.1b (Sam Roberts)
[#26327](#26327)
- upgrade to libuv 1.28.0 (cjihrig)
[#27241](#27241)
- **events**:
- add once method to use promises with EventEmitter (Matteo Collina)
[#26078](#26078)
- **n-api**:
- mark thread-safe function as stable (Gabriel Schulhof)
[#25556](#25556)
- **repl**:
- support top-level for-await-of (Shelley Vohr)
[#23841](#23841)
- **zlib**:
- add brotli support (Anna Henningsen)
[#24938](#24938)
PR-URL: #27514
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
b323658
Notable changes:
- **deps**:
- update ICU to 64.2 (Ujjwal Sharma)
[#27361](#27361)
- upgrade npm to 6.9.0 (Kat Marchán)
[#26244](#26244)
- upgrade openssl sources to 1.1.1b (Sam Roberts)
[#26327](#26327)
- upgrade to libuv 1.28.0 (cjihrig)
[#27241](#27241)
- **events**:
- add once method to use promises with EventEmitter (Matteo Collina)
[#26078](#26078)
- **n-api**:
- mark thread-safe function as stable (Gabriel Schulhof)
[#25556](#25556)
- **repl**:
- support top-level for-await-of (Shelley Vohr)
[#23841](#23841)
- **zlib**:
- add brotli support (Anna Henningsen)
[#24938](#24938)
PR-URL: #27514
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
+5 more reviewers
@jdaltonjdaltonjdalton approved these changes
@TimothyGuTimothyGuTimothyGu approved these changes
@hiroppyhiroppyhiroppy approved these changes
@mmarchinimmarchinimmarchini approved these changes
@devsnekdevsnekdevsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author readyPRs that have at least one approval, no pending requests for changes, and a CI started.notable-changePRs with changes that should be highlighted in changelogs.replIssues and PRs related to the REPL subsystem.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@codebytere@nodejs-github-bot@Trott@targos@MylesBorins@imcotton@jdalton@jasnell@TimothyGu@cjihrig@hiroppy@mmarchini@devsnek