deps: upgrade to libuv 1.28.0

[cjihrig]

Notable changes:

• uv_gettimeofday() has been added.
• Streaming readdir() via the uv_fs_{open,read,close}dir() methods.
• A macOS copyfile() permissions bug has been fixed.
• A bug in uv_interface_addresses() on machines with multiple interfaces has been fixed.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3261

[BridgeAR]

RSLGTM

[Trott]

Rubber-stamp LGTM

[Trott]

The two commits will be squashed into one when landing? Otherwise, the first commit will have a failing test, possibly messing up a git bisect. Maybe that doesn't matter too much as you don't usually run make test with git bisect but instead something more specific....

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22505/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22519/

[richardlau]

test-fs-copyfile-respect-permissions is failing on Windows:
e.g. https://ci.nodejs.org/job/node-test-binary-windows-2/190/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/testReport/junit/(root)/test/parallel_test_fs_copyfile_respect_permissions/

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:+ actual - expected+ 'EPERM'- 'EACCES' at Object.check (c:\workspace\node-test-binary-windows-2\test\parallel\test-fs-copyfile-respect-permissions.js:26:12) at expectedException (assert.js:586:19) at expectsError (assert.js:686:17) at Function.throws (assert.js:717:3) at Object.<anonymous> (c:\workspace\node-test-binary-windows-2\test\parallel\test-fs-copyfile-respect-permissions.js:37:10) at Module._compile (internal/modules/cjs/loader.js:766:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:777:10) at Module.load (internal/modules/cjs/loader.js:635:32) at Function.Module._load (internal/modules/cjs/loader.js:562:12) at Function.Module.runMain (internal/modules/cjs/loader.js:833:10)

[richardlau]

@cjihrig the following should fix the test:

diff --git a/test/parallel/test-fs-copyfile-respect-permissions.js b/test/parallel/test-fs-
index 34697ee..3f8d025 100644
--- a/test/parallel/test-fs-copyfile-respect-permissions.js+++ b/test/parallel/test-fs-copyfile-respect-permissions.js@@ -23,7 +23,9 @@ function beforeEach() {
fs.chmodSync(dest, '444');
const check = (err) => {
- assert.strictEqual(err.code, 'EACCES');+ const expected = ['EACCES', 'EPERM'];+ assert(expected.includes(err.code),+ `err.code '${err.code}' is neither '${expected.join('\' nor \'')}'`);
assert.strictEqual(fs.readFileSync(dest, 'utf8'), 'dest');
return true;
};

Also please remove the entries in test/known_issues/known_issues.status:

diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status
index d7e0b54..3463f0a 100644
--- a/test/known_issues/known_issues.status+++ b/test/known_issues/known_issues.status@@ -7,24 +7,18 @@ prefix known_issues
[true] # This section applies to all platforms
[$system==win32]
-test-fs-copyfile-respect-permissions: SKIP
[$system==linux]
test-vm-timeout-escape-promise: PASS,FLAKY
-test-fs-copyfile-respect-permissions: SKIP
[$system==macos]
[$system==solaris]
-test-fs-copyfile-respect-permissions: SKIP
[$system==freebsd]
-test-fs-copyfile-respect-permissions: SKIP
[$system==aix]
-test-fs-copyfile-respect-permissions: SKIP
[$arch==arm]
# https://github.com/nodejs/node/issues/24120
test-vm-timeout-escape-nexttick: PASS,FLAKY
-test-fs-copyfile-respect-permissions: SKIP

[richardlau]

Fixes: #27273

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22626/

EDIT(cjihrig): CI was green.

[cjihrig]

Landed in 2161690...a3d1922. Thanks for the reviews, especially @richardlau.