Skip to content

n-api: mark thread-safe function as stable - #25556

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:un-experimental-tsfn
Closed

n-api: mark thread-safe function as stable#25556
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:un-experimental-tsfn

Conversation

@gabrielschulhof

@gabrielschulhofgabrielschulhof commented Jan 18, 2019

Copy link
Copy Markdown
Contributor

Fixes: #24249

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot

nodejs-github-bot commented Jan 18, 2019

Copy link
Copy Markdown
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2279/pipeline

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jan 18, 2019
@gabrielschulhofgabrielschulhof added semver-minor PRs that contain new features and should be released in the next minor version. node-api Issues and PRs related to the Node-API. labels Jan 18, 2019
mhdawson
mhdawson approved these changes Jan 18, 2019
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gabrielschulhof

gabrielschulhof commented Jan 18, 2019

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/20199/

@gabrielschulhof

gabrielschulhof commented Jan 22, 2019

Copy link
Copy Markdown
ContributorAuthor

Fresh CI before landing: https://ci.nodejs.org/job/node-test-pull-request/20253/

@gabrielschulhof

gabrielschulhof commented Jan 22, 2019

Copy link
Copy Markdown
ContributorAuthor

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/20254/

@gabrielschulhof

gabrielschulhof commented Jan 22, 2019

Copy link
Copy Markdown
ContributorAuthor

Landed in 11387e1.

gabrielschulhof pushed a commit that referenced this pull request Jan 22, 2019
Gabriel Schulhof
n-api: mark thread-safe function as stable
11387e1
Fixes: #24249
PR-URL: #25556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhofgabrielschulhof mentioned this pull request Jan 22, 2019
Closed
4 tasks
@gabrielschulhofgabrielschulhof mentioned this pull request Jan 22, 2019
Closed
4 tasks
targos pushed a commit that referenced this pull request Jan 24, 2019
Gabriel Schulhof@targos
n-api: mark thread-safe function as stable
2b18582
Fixes: #24249
PR-URL: #25556
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Jan 24, 2019
Merged
MylesBorins added a commit that referenced this pull request Jan 24, 2019
@MylesBorins
2019-01-24, Version 11.8.0 (Current)
11ee794
Notable Changes:
* events:
* For unhandled `error` events with an argument that is not an
`Error` object, the resulting exeption will have more information
about the argument.
#25621
* child_process:
* When the `maxBuffer` option is passed, `stdout` and `stderr` will
be truncated rather than unavailable in case of an error.
#24951
* policy:
* Experimental support for module integrity checks through a manifest
file is implemented now.
#23834
* n-api:
* The `napi_threadsafe_function` feature is now stable.
#25556
* report:
* An experimental diagnostic API for capturing process state is
available as `process.report` and through command line flags.
#22712
* tls:
* `tls.connect()` takes a `timeout` option analogous to the
`net.connect()` one.
#25517
* worker:
* `process.umask()` is available as a read-only function inside Worker
threads now.
#25526
* An `execArgv` option that supports a subset of Node.js command line
options is supported now.
#25467
PR-URL: #25687
MylesBorins added a commit that referenced this pull request Jan 25, 2019
@MylesBorins
2019-01-24, Version 11.8.0 (Current)
641de82
Notable Changes:
* events:
* For unhandled `error` events with an argument that is not an
`Error` object, the resulting exeption will have more information
about the argument.
#25621
* child_process:
* When the `maxBuffer` option is passed, `stdout` and `stderr` will
be truncated rather than unavailable in case of an error.
#24951
* policy:
* Experimental support for module integrity checks through a manifest
file is implemented now.
#23834
* n-api:
* The `napi_threadsafe_function` feature is now stable.
#25556
* report:
* An experimental diagnostic API for capturing process state is
available as `process.report` and through command line flags.
#22712
* tls:
* `tls.connect()` takes a `timeout` option analogous to the
`net.connect()` one.
#25517
* worker:
* `process.umask()` is available as a read-only function inside Worker
threads now.
#25526
* An `execArgv` option that supports a subset of Node.js command line
options is supported now.
#25467
PR-URL: #25687
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Jan 29, 2019
Gabriel Schulhof
n-api: mark thread-safe function as stable
cff27fe
Fixes: nodejs#24249
PR-URL: nodejs#25556
Backport-PR-URL: nodejs#25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Mar 4, 2019
Gabriel Schulhof
n-api: mark thread-safe function as stable
ad9c154
Fixes: nodejs#24249
PR-URL: nodejs#25556
Backport-PR-URL: nodejs#25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this pull request Mar 12, 2019
Gabriel Schulhof@BethGriggs
n-api: mark thread-safe function as stable
48a5241
Fixes: #24249
PR-URL: #25556
Backport-PR-URL: #25633
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this pull request Mar 20, 2019
Gabriel Schulhof@BethGriggs
n-api: mark thread-safe function as stable
d6ffabc
Fixes: #24249
PR-URL: #25556
Backport-PR-URL: #25648
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorinsMylesBorins mentioned this pull request Mar 26, 2019
Merged
MylesBorins added a commit that referenced this pull request Apr 5, 2019
@MylesBorins
2019-04-18, Version 8.16.0 'Carbon' (LTS)
3a7f44e
Notable Changes:
* n-api:
- add API for asynchronous functions (Gabriel Schulhof)
#17887
- mark thread-safe function as stable (Gabriel Schulhof)
#25556
PR-URL: #26933
MylesBorins added a commit that referenced this pull request Apr 16, 2019
@MylesBorins
2019-04-18, Version 8.16.0 'Carbon' (LTS)
4a6662c
Notable Changes:
* n-api:
- add API for asynchronous functions (Gabriel Schulhof)
#17887
- mark thread-safe function as stable (Gabriel Schulhof)
#25556
PR-URL: #26933
MylesBorins added a commit that referenced this pull request Apr 16, 2019
@MylesBorins
2019-04-16, Version 8.16.0 'Carbon' (LTS)
5f93cf7
Notable Changes:
* n-api:
- add API for asynchronous functions (Gabriel Schulhof)
#17887
- mark thread-safe function as stable (Gabriel Schulhof)
#25556
PR-URL: #26933
MylesBorins added a commit that referenced this pull request Apr 16, 2019
@MylesBorins
2019-04-16, Version 8.16.0 'Carbon' (LTS)
1c26169
Notable Changes:
* n-api:
- add API for asynchronous functions (Gabriel Schulhof)
#17887
- mark thread-safe function as stable (Gabriel Schulhof)
#25556
PR-URL: #26933
@BethGriggsBethGriggs mentioned this pull request May 1, 2019
Merged
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
9bc1d75
Notable changes:
- deps:
- icu 63.1 bump (CLDR 34) (Steven R. Loomis)
[#23715](#23715)
- upgrade npm to 6.9.0 (Kat Marchán)
[#26244](#26244)
- upgrade openssl sources to 1.1.1a (Sam Roberts)
[#25381](#25381)
- upgrade to libuv 1.24.1 (cjihrig)
[#25078](#25078)
- events: add once method to use promises with EventEmitter
(Matteo Collina) [#26078](#26078)
- n-api: mark thread-safe function as stable (Gabriel Schulhof)
[#25556](#25556)
- repl: support top-level for-await-of (Shelley Vohr)
[#23841](#23841)
- zlib:
- add brotli support (Anna Henningsen)
[#24938](#24938)
PR-URL: #27514
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
308b8b9
Notable changes:
- **deps**:
- update ICU to 64.2 (Ujjwal Sharma)
[#27361](#27361)
- upgrade npm to 6.9.0 (Kat Marchán)
[#26244](#26244)
- upgrade openssl sources to 1.1.1b (Sam Roberts)
[#26327](#26327)
- upgrade to libuv 1.28.0 (cjihrig)
[#27241](#27241)
- **events**:
- add once method to use promises with EventEmitter (Matteo Collina)
[#26078](#26078)
- **n-api**:
- mark thread-safe function as stable (Gabriel Schulhof)
[#25556](#25556)
- **repl**:
- support top-level for-await-of (Shelley Vohr)
[#23841](#23841)
- **zlib**:
- add brotli support (Anna Henningsen)
[#24938](#24938)
PR-URL: #27514
BethGriggs added a commit that referenced this pull request May 28, 2019
@BethGriggs
2019-05-28, Version 10.16.0 'Dubnium' (LTS)
b323658
Notable changes:
- **deps**:
- update ICU to 64.2 (Ujjwal Sharma)
[#27361](#27361)
- upgrade npm to 6.9.0 (Kat Marchán)
[#26244](#26244)
- upgrade openssl sources to 1.1.1b (Sam Roberts)
[#26327](#26327)
- upgrade to libuv 1.28.0 (cjihrig)
[#27241](#27241)
- **events**:
- add once method to use promises with EventEmitter (Matteo Collina)
[#26078](#26078)
- **n-api**:
- mark thread-safe function as stable (Gabriel Schulhof)
[#25556](#25556)
- **repl**:
- support top-level for-await-of (Shelley Vohr)
[#23841](#23841)
- **zlib**:
- add brotli support (Anna Henningsen)
[#24938](#24938)
PR-URL: #27514
This was referenced May 29, 2019
Closed
Closed
Closed
Closed
Closed
@gabrielschulhof
gabrielschulhof deleted the un-experimental-tsfn branch June 14, 2019 23:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.lib / srcIssues and PRs related to general changes in the lib or src directory.node-apiIssues and PRs related to the Node-API.semver-minorPRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Graduate experimental N-API feature napi_threadsafe_function

5 participants

@gabrielschulhof@nodejs-github-bot@jasnell@cjihrig@mhdawson