[v18.x backport] lib: reset `RegExp` statics before running user code by aduh95 · Pull Request #44247 · nodejs/node

aduh95 · 2022-08-16T06:27:11Z

PR-URL: #43741
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Geoffrey Booth webadmin@geoffreybooth.com
Reviewed-By: Matteo Collina matteo.collina@gmail.com

nodejs-github-bot · 2022-08-16T06:27:15Z

Review requested:

@nodejs/modules

aduh95 · 2022-08-16T07:27:28Z

It looks like the lint failure was introduced by 5cb5c65.

danielleadams · 2022-08-17T01:16:50Z

@aduh95 I had to rest v18.x-staging, sorry but this will need a rebase

Fixes: nodejs#43740 PR-URL: nodejs#43741 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

nodejs-github-bot · 2022-08-23T17:08:21Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46185/

nodejs-github-bot · 2022-09-05T12:57:33Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46422/

nodejs-github-bot · 2022-09-05T22:01:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46428/

nodejs-github-bot · 2022-09-06T08:08:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46432/

nodejs-github-bot · 2022-09-06T14:29:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46444/

nodejs-github-bot · 2022-09-06T23:08:10Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46455/

nodejs-github-bot · 2022-09-07T13:14:32Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46461/

nodejs-github-bot · 2022-09-07T15:30:52Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46462/

nodejs-github-bot · 2022-09-08T14:46:26Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46487/

nodejs-github-bot · 2022-09-16T08:49:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46619/

nodejs-github-bot · 2022-09-16T09:17:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/46620/

RafaelGSS · 2022-09-23T18:00:05Z

@aduh95 Is it ready to land? I'm about to including it to the v18 proposal

aduh95 · 2022-09-23T18:47:47Z

It is ready to land, thanks for taking care of this :)

RafaelGSS · 2022-09-23T18:55:11Z

It is ready to land, thanks for taking care of this :)

Can you amend the Backport-PR-URL metadata to your commit message?

aduh95 · 2022-09-23T18:57:29Z

It is ready to land, thanks for taking care of this :)
Can you amend the Backport-PR-URL metadata to your commit message?

Sure I can, but I find it surprising as of all the backport PRs I've opened, I've never touched the commit message, and it was taken care of upon landing – also if I push another commit, that means we'd probably need another CI run, which I'd rather avoid. Are you sure that's not something that ncu takes care of?

RafaelGSS · 2022-09-23T19:06:08Z

@nodejs/releasers Do ncu handle it by default? I'm just asking because following the https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-request step 9.v says:

Amend the commit message and include a Backport-PR-URL: metadata and re-push the change to your fork.

I think I can include that metadata while merging using git node land X, but I'm not quite sure if that's the correct workflow.

RafaelGSS · 2022-09-23T19:37:42Z

Landed in 687ffcc

Fixes: #43740 Backport-PR-URL: #43741 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> PR-URL: #44247 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

RafaelGSS · 2022-09-23T19:38:40Z

@aduh95 just realized that I can do it manually using ncu. Sorry for the inconvenience.

richardlau · 2022-09-23T19:50:04Z

@nodejs/releasers Do ncu handle it by default? I'm just asking because following the https://github.com/nodejs/node/blob/main/doc/contributing/backporting-to-release-lines.md#how-to-submit-a-backport-pull-request step 9.v says:
Amend the commit message and include a Backport-PR-URL: metadata and re-push the change to your fork.
I think I can include that metadata while merging using git node land X, but I'm not quite sure if that's the correct workflow.

Use --backport with git node land (nodejs/node-core-utils#383).

Fixes: #43740 Backport-PR-URL: #43741 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> PR-URL: #44247 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v18.x labels Aug 16, 2022

aduh95 added the blocked PRs that are blocked by other issues or PRs. label Aug 16, 2022

This was referenced Aug 16, 2022
lib: add diagnostics channel and perf hooks detail #43984
Merged
[v18.x] src: split property helpers from node::Environment #44251
Closed

danielleadams force-pushed the v18.x-staging branch from 96c3373 to e028edbCompare August 17, 2022 01:16

lib: reset RegExp statics before running user code
aa76869
Fixes: nodejs#43740 PR-URL: nodejs#43741 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

aduh95 force-pushed the backport-regexp-statics-great-reset branch from 48d92db to aa76869Compare August 23, 2022 16:58

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. and removed blocked PRs that are blocked by other issues or PRs. labels Aug 23, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2022

github-actionsBot mentioned this pull request Sep 6, 2022
CI Reliability 2022-09-06 nodejs/reliability#369
Open
17 tasks

RafaelGSS force-pushed the v18.x-staging branch from d912d2d to 60191c6Compare September 6, 2022 16:34

github-actionsBot mentioned this pull request Sep 7, 2022
CI Reliability 2022-09-07 nodejs/reliability#370
Open
15 tasks

RafaelGSS force-pushed the v18.x-staging branch from 60191c6 to c0cfb14Compare September 7, 2022 12:21

RafaelGSS force-pushed the v18.x-staging branch from c0cfb14 to 8ef5c40Compare September 7, 2022 16:28

github-actionsBot mentioned this pull request Sep 8, 2022
CI Reliability 2022-09-08 nodejs/reliability#371
Open
12 tasks

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2022

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 16, 2022

RafaelGSS approved these changes Sep 23, 2022
View reviewed changes

RafaelGSS closed this Sep 23, 2022

RafaelGSS mentioned this pull request Sep 23, 2022
doc: mention git node backport #44764
Closed

aduh95 deleted the backport-regexp-statics-great-reset branch September 24, 2022 12:30

RafaelGSS mentioned this pull request Sep 26, 2022
v18.10.0 proposal #44799
Merged

Uh oh!

Uh oh!

Conversation

aduh95 commented Aug 16, 2022

Uh oh!

nodejs-github-bot commented Aug 16, 2022

Uh oh!

aduh95 commented Aug 16, 2022

Uh oh!

danielleadams commented Aug 17, 2022

Uh oh!

nodejs-github-bot commented Aug 23, 2022

Uh oh!

nodejs-github-bot commented Sep 5, 2022

Uh oh!

nodejs-github-bot commented Sep 5, 2022

Uh oh!

nodejs-github-bot commented Sep 6, 2022

Uh oh!

nodejs-github-bot commented Sep 6, 2022

Uh oh!

nodejs-github-bot commented Sep 6, 2022

Uh oh!

nodejs-github-bot commented Sep 7, 2022

Uh oh!

nodejs-github-bot commented Sep 7, 2022

Uh oh!

nodejs-github-bot commented Sep 8, 2022

Uh oh!

nodejs-github-bot commented Sep 16, 2022

Uh oh!

nodejs-github-bot commented Sep 16, 2022

Uh oh!

RafaelGSS commented Sep 23, 2022

Uh oh!

aduh95 commented Sep 23, 2022

Uh oh!

RafaelGSS commented Sep 23, 2022

Uh oh!

aduh95 commented Sep 23, 2022

Uh oh!

RafaelGSS commented Sep 23, 2022

Uh oh!

RafaelGSS commented Sep 23, 2022

Uh oh!

RafaelGSS commented Sep 23, 2022

Uh oh!

richardlau commented Sep 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants