test: fix edge snapshot stack traces by GeoffreyBooth · Pull Request #49659 · nodejs/node

GeoffreyBooth · 2023-09-15T05:07:36Z

Working on #49657, I discovered that some of the more unusual snapshot tests had stack traces that include specifics of the module loader internals. (See https://github.com/nodejs/node/actions/runs/6191368639/job/16809521748?pr=49657.) Refactoring the modules code shouldn’t break these unrelated tests; these snapshots should be like the others that exclude detailed stack traces of modules internals. These two specific cases probably slipped through because they’re edge cases, having to do with source maps and colored stack trace output. This PR updates the tests and snapshots so that future modules changes don’t break these tests. @nodejs/test_runner @nodejs/testing

aduh95 · 2023-09-15T08:07:37Z

IMO this is not a good candidate for fast-track, it's not a trivial change.

GeoffreyBooth · 2023-09-15T16:52:18Z

IMO this is not a good candidate for fast-track, it’s not a trivial change.

Well that’s fine, but then #49657 can’t land fast-track either because it depends on this.

nodejs-github-bot · 2023-09-17T14:03:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54006/

GeoffreyBooth · 2023-09-17T15:24:58Z

I want to give @MoLow a chance to review this, it can wait a few more days.

MoLow

LGTM

nodejs-github-bot · 2023-09-17T18:55:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54010/

nodejs-github-bot · 2023-09-17T20:06:33Z

Commit Queue failed

- Loading data for nodejs/node/pull/49659
✔ Done loading data for nodejs/node/pull/49659
----------------------------------- PR info ------------------------------------
Title test: fix edge snapshot stack traces (#49659)
⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch GeoffreyBooth:fix-snapshot-stack-traces -> nodejs:main
Labels test, author ready, needs-ci, commit-queue-squash
Commits 1
- test: fix edge snapshot stack traces
Committers 1
- Geoffrey Booth PR-URL: https://github.com/nodejs/node/pull/49659
Reviewed-By: James M Snell Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow ------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/49659
Reviewed-By: James M Snell Reviewed-By: Yagiz Nizipli Reviewed-By: Moshe Atlow --------------------------------------------------------------------------------
ℹ This PR was created on Fri, 15 Sep 2023 05:07:36 GMT
✔ Approvals: 3
✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/49659#pullrequestreview-1629983258
✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/49659#pullrequestreview-1630085441
✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/49659#pullrequestreview-1630114315
✘ Last GitHub CI failed
ℹ Last Full PR CI on 2023-09-17T18:55:39Z: https://ci.nodejs.org/job/node-test-pull-request/54010/
- Querying data for job/node-test-pull-request/54010/
✔ Last Jenkins CI successful
--------------------------------------------------------------------------------
✔ Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/6215579253

nodejs-github-bot · 2023-09-17T20:09:42Z

CI: https://ci.nodejs.org/job/node-test-pull-request/54014/

PR-URL: nodejs#49659 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: #49659 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

PR-URL: nodejs#49659 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs/node#49659

PR-URL: #49659 Backport-PR-URL: #50669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

nodejs/node#49659

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closesnodejs/node#49327 * test: deflake test-tls-socket-closenodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixesnodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

nodejs/node#49659

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closesnodejs/node#49327 * test: deflake test-tls-socket-closenodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixesnodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

* chore: bump node in DEPS to v20.10.0 * chore: update feat_initialize_asar_support.patch no code changes; patch just needed an update due to nearby upstream changes Xref: nodejs/node#49986 * chore: update pass_all_globals_through_require.patch no manual changes; patch applied with fuzz Xref: nodejs/node#49657 * chore: update refactor_allow_embedder_overriding_of_internal_fs_calls Xref: nodejs/node#49912 no code changes; patch just needed an update due to nearby upstream changes * chore: update chore_allow_the_node_entrypoint_to_be_a_builtin_module.patch Xref: nodejs/node#49986 minor manual changes needed to sync with upstream change * update fix_expose_the_built-in_electron_module_via_the_esm_loader.patch Xref: nodejs/node#50096 Xref: nodejs/node#50314 in lib/internal/modules/esm/load.js, update the code that checks for `format === 'electron'`. I'd like 👀 on this Xref: nodejs/node#49657 add braces in lib/internal/modules/esm/translators.js to sync with upstream * fix: lazyload fs in esm loaders to apply asar patches * nodejs/node#50127 * nodejs/node#50096 * esm: jsdoc for modules code nodejs/node#49523 * test: set test-cli-node-options as flaky nodejs/node#50296 * deps: update c-ares to 1.20.1 nodejs/node#50082 * esm: bypass CommonJS loader under --default-type=module nodejs/node#49986 * deps: update uvwasi to 0.0.19 nodejs/node#49908 * lib,test: do not hardcode Buffer.kMaxLength nodejs/node#49876 * crypto: account for disabled SharedArrayBuffer nodejs/node#50034 * test: fix edge snapshot stack traces nodejs/node#49659 * src: generate snapshot with --predictable nodejs/node#48749 * chore: fixup patch indices * fs: throw errors from sync branches instead of separate implementations nodejs/node#49913 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * esm: detect ESM syntax in ambiguous JavaScrip nodejs/node#50096 * fixup! test: fix edge snapshot stack traces * esm: unflag extensionless ES module JavaScript and Wasm in module scope nodejs/node#49974 * [tagged-ptr] Arrowify objects https://chromium-review.googlesource.com/c/v8/v8/+/4705331 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Charles Kerr <charles@charleskerr.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

PR-URL: nodejs/node#49659 Backport-PR-URL: nodejs/node#50669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

GeoffreyBooth added test Issues and PRs related to the tests. fast-track PRs that do not need to wait for 48 hours to land. labels Sep 15, 2023

GeoffreyBooth requested a review from MoLow September 15, 2023 05:07

This comment was marked as outdated.
Sign in to view

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Sep 15, 2023

aduh95 removed the fast-track PRs that do not need to wait for 48 hours to land. label Sep 15, 2023

test: fix edge snapshot stack traces
4eebdfa

GeoffreyBooth force-pushed the fix-snapshot-stack-traces branch from fbc9c81 to 4eebdfaCompare September 15, 2023 19:33

jasnell approved these changes Sep 16, 2023
View reviewed changes

anonrig approved these changes Sep 17, 2023
View reviewed changes

anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 17, 2023

github-actionsBot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2023

GeoffreyBooth removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 17, 2023

MoLow approved these changes Sep 17, 2023
View reviewed changes

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 17, 2023

GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Sep 17, 2023

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 17, 2023

RafaelGSS mentioned this pull request Oct 9, 2023
2023-10-17, Version 21.0.0 (Current) #49870
Merged

GeoffreyBooth deleted the fix-snapshot-stack-traces branch October 17, 2023 02:52

codebytere mentioned this pull request Oct 18, 2023
[v18.x backport] test: fix edge snapshot stack traces #50237
Closed

codebytere mentioned this pull request Oct 18, 2023
test: fix Node.js color edge snapshot stack traces electron/electron#40250
Merged
4 tasks

targos mentioned this pull request Nov 11, 2023
[v18.x] Backport most ESM and customization hook changes #50669
Closed

targos pushed a commit that referenced this pull request Nov 11, 2023
test: fix edge snapshot stack traces
5dfe423
PR-URL: #49659 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
test: fix edge snapshot stack traces
85b21a8
PR-URL: nodejs#49659 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

targos mentioned this pull request Nov 12, 2023
v20.10.0 release proposal #50682
Merged

targos added backported-to-v20.x and removed backport-open-v20.x labels Nov 12, 2023

codebytere added a commit to electron/electron that referenced this pull request Nov 17, 2023
test: fix edge snapshot stack traces
3d1fc96
nodejs/node#49659

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2023
test: fix edge snapshot stack traces
5f9ee7d
nodejs/node#49659

codebytere added a commit to electron/electron that referenced this pull request Nov 22, 2023
test: fix edge snapshot stack traces
0cd876e
nodejs/node#49659

targos added the backported-to-v18.x label Nov 23, 2023

targos pushed a commit that referenced this pull request Nov 23, 2023
test: fix edge snapshot stack traces
00c0853
PR-URL: #49659 Backport-PR-URL: #50669 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

codebytere added a commit to electron/electron that referenced this pull request Nov 28, 2023
test: fix edge snapshot stack traces
4044669
nodejs/node#49659

targos mentioned this pull request Nov 28, 2023
v18.19.0 release proposal #50953
Merged

codebytere added a commit to electron/electron that referenced this pull request Nov 29, 2023
test: fix edge snapshot stack traces
3daaf84
nodejs/node#49659

juanarbol mentioned this pull request Dec 6, 2023
2023-12-06, N|Solid v5.0.1 Iron Release nodesource/nsolid#41
Merged

codebytere added a commit to electron/electron that referenced this pull request Dec 8, 2023
test: fix edge snapshot stack traces
a421313
nodejs/node#49659

codebytere added a commit to electron/electron that referenced this pull request Dec 8, 2023
test: fix edge snapshot stack traces
7be25b9
nodejs/node#49659

Navigation Menu

Uh oh!

Uh oh!

test: fix edge snapshot stack traces - #49659

test: fix edge snapshot stack traces#49659
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
GeoffreyBooth:fix-snapshot-stack-traces

GeoffreyBooth commented Sep 15, 2023•
edited
Loading

Uh oh!

This comment was marked as outdated.

aduh95 commented Sep 15, 2023

Uh oh!

GeoffreyBooth commented Sep 15, 2023

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

GeoffreyBooth commented Sep 17, 2023

Uh oh!

MoLow left a comment

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Uh oh!

Conversation

GeoffreyBooth commented Sep 15, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

aduh95 commented Sep 15, 2023

Uh oh!

GeoffreyBooth commented Sep 15, 2023

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

GeoffreyBooth commented Sep 17, 2023

Uh oh!

MoLow left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

nodejs-github-bot commented Sep 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GeoffreyBooth commented Sep 15, 2023•
edited
Loading