Uh oh!
There was an error while loading. Please reload this page.
src: replace ARRAY_SIZE with typesafe arraysize (v4.x) - #6221
Closed
bnoordhuis wants to merge 12 commits into
Closed
src: replace ARRAY_SIZE with typesafe arraysize (v4.x)#6221bnoordhuis wants to merge 12 commits into
bnoordhuis wants to merge 12 commits into
Conversation
4 tasks
MylesBorins
commented
Apr 15, 2016
Contributor
thanks @bnoordhuis I'll get this landed in v4 after it lives in v5 for a bit |
jasnell
commented
Apr 15, 2016
Member
LGTM. This one should be safe but giving it a week makes sense. |
addaleax
commented
Apr 21, 2016
Member
LGTM |
MylesBorins
commented
May 9, 2016
Contributor
@bnoordhuis it looks like this needs to be rebased again. Thanks |
MylesBorins
commented
May 17, 2016
Contributor
one more ping to @bnoordhuis |
MylesBorins
commented
Jun 1, 2016
Contributor
ping @bnoordhuis |
ESLint 2.9.0 fixes some bugs that resulted in minor issues not being caught by ESLint 2.7.0. Update instances of our code that will be flagged when we upgrade to ESLint 2.9.0. PR-URL: nodejs#6498 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Fixes some formatting, improves some formatting, updates minor nits. Refs: nodejs#6655 PR-URL: nodejs#6548 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: nodejs#6579 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Included a block in the modules.md file to explain the existence and purpose of the module wrapper. PR-URL: nodejs#6433 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Move the newcomers section to be more noticeable to those who it will be needed by. Also removed some entries that are now effectively duplicates. They are all in the above section. PR-URL: nodejs#6681 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com>
Fixes: nodejs#6642 PR-URL: nodejs#6689 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Alexander Makarenko <estliberitas@gmail.com> Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com>
test-debugger-repl-term had incorrect expected output and so was failing. It was likely dependent on previous bugs in the debugger. The fixture file has been modified so that the output is as expected. PR-URL: nodejs#6682 Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
The line number checks in test-debugger-repl-break-in-module were checking for line numbers that exceed the total number of lines in the files that were being inspected. Change the checks to match the actual files. PR-URL: nodejs#6686 Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Previously, the example was checking for error by strict equality to null. The error could be undefined though which would fail that check. PR-URL: nodejs#6660 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jeremy Whitlock <jwhitlock@apache.org>
PR-URL: nodejs#6812 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
bnoordhuis
commented
Jun 2, 2016
MemberAuthor
Sorry, this has been on my todo list for some time. I'll try to get around to it this week. |
To prevent `ARRAY_SIZE(&arg)` (i.e., taking the array size of a pointer) from happening again. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Make the `num_values_` and `num_fields_` unsigned and remove an erroneous comment. PR-URL: nodejs#5969 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuisforce-pushed
the
backport-5969-v4.x
branch
from
June 2, 2016 17:34
b46ea50 to
6ddd3d3Comparebnoordhuis
commented
Jun 2, 2016
MemberAuthor
Rebased. New CI: https://ci.nodejs.org/job/node-test-pull-request/2903/ |
MylesBorins
commented
Jun 6, 2016
Contributor
landed in 8f55108...a8207fb |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R=@thealphanerd
CI: https://ci.nodejs.org/job/node-test-pull-request/2277/