Uh oh!
There was an error while loading. Please reload this page.
Redsign/new header - #5328
Closed
u-rogel wants to merge 59 commits into
Closed
Conversation
feat(unit-test): introduce unit test
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story.
Co-authored-by: Michael Esteban <mickel13@gmail.com>
chore: next lock to versin 13.2.0
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com>
…mplates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
…ies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx
* chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries
fix(package.json) lint:fix missing slashes
u-rogel
commented
May 2, 2023
ContributorAuthor
@ovflowd@AugustinMauroy ready for another review I would say. |
ovflowd
reviewed
May 2, 2023
| min-height: calc(1 * var(--nav-height)); | ||
| padding: 0 var(--space-12); | ||
| } | ||
| .startWrapper { |
Member
There was a problem hiding this comment.
Suggested change
| .startWrapper { | |
| .startWrapper { |
ovflowd
commented
May 2, 2023
Member
@u-rogel code looks nice! But tests failing, probably you need to mock some more stuff! |
| @@ -0,0 +1,9 @@ | |||
| import Header from './index'; | |||
There was a problem hiding this comment.
We should create stories to see active link.
Useful link: nextjs router storybook
ovflowdforce-pushed
the
major/website-redesign
branch
from
May 3, 2023 23:05
7ddfa8d to
f2a3ac4Compareovflowd
commented
May 4, 2023
Member
This PR got accidentally closed because the branch got deleted. Please feel free to reopen the PR. |
AugustinMauroy
commented
May 7, 2023
Member
Hey 👋 @u-rogel! |
u-rogel
commented
May 7, 2023
ContributorAuthor
Hi, sure will submit something later |
AugustinMauroy
left a comment
Member
There was a problem hiding this comment.
Not bad 😁!!!
just don't miss to rebase/chery-pick
| describe('Tests for Header component', () => { | ||
| beforeEach(() => { | ||
| // @ts-ignore |
| <Header /> | ||
| </IntlProvider> | ||
| ); | ||
| expect(container).toMatchSnapshot(); |
There was a problem hiding this comment.
Now we use storybook to create snapshot you should update unit test.
u-rogel
commented
May 8, 2023
ContributorAuthor
Will do! |
u-rogel
commented
May 8, 2023
ContributorAuthor
@AugustinMauroy I think I got too far from the target branch. Will create a new PR from the current stage. |
AugustinMauroy
commented
May 8, 2023
Member
Oh ok no problem ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ovflowd it is way to early to be merged but I have some questions:
oldstyles, can we change to the new ones?jsonp-components.header.links.learn, is missing from our i18n schema, do we have a script to add it?