📎 chore(migration): migrate banner component by manishprivet · Pull Request #5233 · nodejs/nodejs.org

manishprivet · 2023-04-05T09:35:24Z

Changes

Migrates Banner Component From https://github.com/nodejs/nodejs.dev/tree/main/src/components/CommonComponents/Banner

Addresses #5193

…nent

AugustinMauroy

LGTM

…nent

ovflowd

Per my comment, please either remove bannerBtnText or address its i18n issues.

…nent

ovflowd

I left two nitpicks, but there's one major thing to address yet, can you remove the new translation key from all files except en.json? The key should be added to the translated languages through Crowdin, not through here :)

manishprivet · 2023-04-08T22:54:18Z

I left two nitpicks, but there's one major thing to address yet, can you remove the new translation key from all files except en.json? The key should be added to the translated languages through Crowdin, not through here :)

@ovflowd Regarding this, I myself didn't want to copy it in each file, but then I saw these two lines present in each file in English language, so I thought maybe a key was needed for Crowdin

"components.header.buttons.toggleLanguage": "Toggle Language",
"components.header.buttons.toggleDarkMode": "Toggle dark/light mode",

ovflowd · 2023-04-09T16:54:34Z

@ovflowd Regarding this, I myself didn't want to copy it in each file, but then I saw these two lines present in each file in English language, so I thought maybe a key was needed for Crowdin

That's fine. Just means that the key was not translated yet.

ovflowd

LGTM! Thank you for the considerable effort here. I left one last comment that must be addressed before we merge this PR, but otherwise, fine!

shanpriyan

LGTM! 🚀

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

Co-authored-by: Michael Esteban <mickel13@gmail.com> Signed-off-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

* feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore(minor): just a tiny design nitpick * chore: set up storybook (#5191) (#5214) * chore: set up testing-library jest extend (#5231) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> * chore(dependencies): updated dependencies * feat: create section title component (#5237) Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * 📎 chore(migration): migrate banner component (#5233) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: migrate AnimatedPlaceholder component (#5238 Migrate AnimatedPlaceholder component from nodejs.dev and create a new Story. * feat: create article alert component (#5243) * feat: migrate blockquote component (#5259) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat: create article data tag component (#5280) * feat: migrate AuthorList component and add story 🎉 (#5277) Co-authored-by: Michael Esteban <mickel13@gmail.com> * chore(migration): migrate language selector component (#5266) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> * chore: contributing quick fix of example Signed-off-by: Claudio Wunder <cwunder@gnome.org> * chore: story guide and react spreading Signed-off-by: Claudio Wunder <cwunder@gnome.org> * chore: remove base styles from old styling * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * fix(package.json) Lint command is missing slashes (#5321 fix(package.json) lint:fix missing slashes * moved `DataTag` to `components/Api` (#5317) Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> * hot-fix: dependency updates and fix dev runtime * chore: updated start command * migration(Layout): newFooter (#5320) Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: migrate EditLink component (#5271) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * feat(blog) Migrate BlogCard component (#5323) Co-authored-by: Michael Esteban <mickel13@gmail.com> * Issue#5307 - Add framer-motion to the dependency list (#5318) * chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> * chore: add remote turbo cache and simplified gh actions cache * chore: updated cache rules * chore: more cache rules --------- Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> * chore: fix storybook local development mode (#5335) * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <cwunder@gnome.org> * chore: migrate releases types (#5324) * hotfix: first element no margin-top * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * chore: updated dependencies * chore: vercel enable middleware and i18n redirection (#5300) * feat(unit-test): introduce unit test on website redesign branch (#5178 feat(unit-test): introduce unit test * chore: set up storybook (#5191) (#5214) * feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281) * feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236) Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> * chore: updated contributing guidelines, eslint rules and storybook templates (#5294) Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> * chore: fix storybook styles, imports, typescript config and dependencies (#5319 * chore: optimises tsconfig * chiore: add missing dependencies * chore: type storybook constants * chore: styles moved styles to somewhere else * chore: add global json type definition * chore: i18n aria-label instead of sr-only * chore: added open sans font family and space between imports * chore: moved styles and fixed styles and updated banner stories * fix: stylelint rules * chore: updated tsconfig * chore: fix tests * fix: darkmodetoggle test * chore: stories use index.stories.tsx * chore: adopt turborepo (#5316 * chore: revert pnpm use plain npm * fix: package.json * chore: remove warnings and add node_env * chore: cross-env * fix: fix turbo pipelines * chore: only cache certain files * chore: turbo shouldn't care about coverage outputs * chore: proper inputs and outputs for pipelines * chore: do not store some outputs and updated inputs for lint * chore: added prettier configs * chore: remove console.info * chore: updated inputs of all other entries * feat(stability): migrate component * chore(snapshot): update * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update components/Api/Stability/index.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fea(stability): update stories + fix * Update components/Api/Stability/index.stories.tsx Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix(i18n): update turkish language direction (#5182) * chore: rollback CODEOWNER changes (#5183) * Sync: merge `major/website-redesign` into `main` (#5356) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> * feat(stability): update snapshot * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * code format * Update components/Api/Stability/index.tsx Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Nick Schonning <nschonni@gmail.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>

📎 chore(migration): migrate banner component
6dab118

manishprivet requested a review from a team as a code owner April 5, 2023 09:35

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…
d0a2244
…nent

manishprivet added the website redesign Issue/PR part of the Node.js Website Redesign label Apr 5, 2023

AugustinMauroy approved these changes Apr 5, 2023
View reviewed changes

nschonni reviewed Apr 5, 2023
View reviewed changes

Comment threadsite.json Outdated

manishprivet mentioned this pull request Apr 5, 2023
(website redesign) Feat(shellbox): migration #5234
Merged

nschonni reviewed Apr 5, 2023
View reviewed changes

Comment threadcomponents/CommonComponents/Banner/index.tsx Outdated

HinataKah0 reviewed Apr 6, 2023
View reviewed changes

Comment threadcomponents/CommonComponents/Banner/Banner.stories.tsx

ovflowd reviewed Apr 6, 2023
View reviewed changes

Comment thread.storybook/main.js Outdated

manishprivet added 4 commits April 6, 2023 16:02

🪚 refactor(folder-structure): move files to Common from CommonComponents
798dc0f

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…
716006e
…nent

🪚 refactor(html): remove button inside a tag
0b28ef0

merge commit
1fd12b7

nschonni reviewed Apr 6, 2023
View reviewed changes

Comment threadcomponents/Common/Banner/index.tsx

ovflowd requested changes Apr 7, 2023
View reviewed changes

manishprivet added 4 commits April 7, 2023 17:12

🪚 refactor(config): move bannerBtnText to i18n
e7bf751

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…
09dc1ba
…nent

📎 chore(storybook): remove sass addon
1a840e3

🧪 test(storybook): remove bannerBtnText
fcf63cf

manishprivet requested review from nschonni and ovflowd April 7, 2023 11:48

Merge branch 'major/website-redesign' into chore/migrate-banner-compo…
dae35f9
…nent

ovflowd reviewed Apr 8, 2023
View reviewed changes

Comment threadcomponents/Common/Banner/Banner.stories.tsx Outdated
Comment threadcomponents/Common/Banner/Banner.stories.tsx
Comment threadi18n/locales/ca.json
Comment threadi18n/locales/en.json Outdated

🪚 refactor(code): format and conventions
2b2699e

manishprivet requested a review from ovflowd April 8, 2023 23:06

ovflowd reviewed Apr 9, 2023
View reviewed changes

Comment threadi18n/locales/ca.json

ovflowd approved these changes Apr 9, 2023
View reviewed changes

🛠 fix(i18n): remove translation key
716dd46

rodion-arr approved these changes Apr 10, 2023
View reviewed changes

manishprivet removed the request for review from nschonni April 10, 2023 12:16

shanpriyan reviewed Apr 10, 2023
View reviewed changes

Comment threadcomponents/Common/Banner/index.tsx Outdated

shanpriyan approved these changes Apr 10, 2023
View reviewed changes

Update components/Common/Banner/index.tsx
5be3624
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

mikeesto reviewed Apr 10, 2023
View reviewed changes

Comment threadcomponents/Common/Banner/index.tsx Outdated

Update components/Common/Banner/index.tsx
55bc2c4
Co-authored-by: Michael Esteban <mickel13@gmail.com> Signed-off-by: Manish Kumar ⛄ <manishprivet@protonmail.com>

ovflowd merged commit 22b2d1b into nodejs:major/website-redesignApr 11, 2023

manishprivet deleted the chore/migrate-banner-component branch April 11, 2023 12:41

ovflowd added a commit that referenced this pull request Apr 15, 2023
📎 chore(migration): migrate banner component (#5233)
6ce6923
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

ovflowd added a commit that referenced this pull request May 3, 2023
📎 chore(migration): migrate banner component (#5233)
a994f19
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org>

avivkeller removed this from Node.js Website May 3, 2025

Navigation Menu

Uh oh!

📎 chore(migration): migrate banner component - #5233

📎 chore(migration): migrate banner component#5233
ovflowd merged 15 commits into
nodejs:major/website-redesignfrom
manishprivet:chore/migrate-banner-component

manishprivet commented Apr 5, 2023

Uh oh!

AugustinMauroy left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Uh oh!

ovflowd left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manishprivet commented Apr 8, 2023

Uh oh!

ovflowd commented Apr 9, 2023

Uh oh!

Uh oh!

ovflowd left a comment

Uh oh!

Uh oh!

shanpriyan left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Uh oh!

Conversation

manishprivet commented Apr 5, 2023

Changes

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

manishprivet commented Apr 8, 2023

Uh oh!

ovflowd commented Apr 9, 2023

Uh oh!

Uh oh!

ovflowd left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shanpriyan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants