Skip to content

chore(migration): migrate language selector component - #5266

Merged
ovflowd merged 13 commits into
nodejs:major/website-redesignfrom
ktssr:chore/migrate-language-selector
Apr 20, 2023
Merged

chore(migration): migrate language selector component#5266
ovflowd merged 13 commits into
nodejs:major/website-redesignfrom
ktssr:chore/migrate-language-selector

Conversation

@ktssr

@ktssrktssr commented Apr 13, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@ktssr
ktssr requested a review from a team as a code ownerApril 13, 2023 10:05
@ktssrktssr mentioned this pull request Apr 13, 2023
Closed
8 tasks
@ovflowd

ovflowd commented Apr 13, 2023

Copy link
Copy Markdown
Member

Hey @ktssr could you rebase your PR?

@ovflowd

ovflowd commented Apr 13, 2023•
edited
Loading

Copy link
Copy Markdown
Member

I would recommend checking out the major/website-redesign branch again, creating a new clean branch and just cherry-picking these commits. (Except for the merge commit)

image

@ktssr
ktssrforce-pushed the chore/migrate-language-selector branch from e1aba71 to d4856a1CompareApril 13, 2023 12:43
ovflowd
ovflowd approved these changes Apr 15, 2023
View reviewed changes

@ovflowdovflowd left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks nice :)

I see you also made the Dropdown component, but it seems a more straightforward version from this.

Does it still work as intended? If yes, that's great :)

Anyhow, outstanding first contribution! (FYI: I left a few comments that can be addressed)

Comment threadcomponents/Common/Dropdown/__tests__/index.test.tsx Outdated
Comment threadcomponents/Common/Dropdown/index.stories.tsx
Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/Dropdown/index.tsx
Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/LanguageSelector/index.stories.tsx
Comment threadpackage.json Outdated
@ovflowd
ovflowdforce-pushed the major/website-redesign branch from 5cdab56 to 0240b9bCompareApril 15, 2023 08:17
@ovflowd
ovflowdforce-pushed the chore/migrate-language-selector branch from e5cf37d to 8ca96b6CompareApril 15, 2023 08:24
@shanpriyanshanpriyan added the website redesign Issue/PR part of the Node.js Website Redesign label Apr 15, 2023
shanpriyanand others added 4 commits April 16, 2023 00:18
@shanpriyan
Merge branch 'major/website-redesign' into chore/migrate-language-sel…
e4f8d1a
…ector
@ktssr@ovflowd
Update components/Common/Dropdown/__tests__/index.test.tsx
d4b693f
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: ktssr <31731919+ktssr@users.noreply.github.com>
@ktssr@ovflowd
Update components/Common/Dropdown/index.tsx
038259a
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: ktssr <31731919+ktssr@users.noreply.github.com>
Teja Sai Sandeep Reddy Konala
fix(PR review comments): migrate language selector component
892b1ab
ovflowd
ovflowd approved these changes Apr 19, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! I left a few comments but pretty much we're almost there!

Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/Dropdown/index.tsx Outdated
Comment threadcomponents/Common/LanguageSelector/__tests__/index.test.tsx
Comment threadcomponents/Common/LanguageSelector/index.tsx Outdated
Comment threadcomponents/Common/LanguageSelector/index.tsx Outdated
ovflowd
ovflowd approved these changes Apr 19, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Ready to get merged! cc @nodejs/website let's get the reviews/approvals!

@vercel

vercelBot commented Apr 19, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit Preview💬 Add feedbackApr 20, 2023 5:07am
nodejs-org-stories✅ Ready (Inspect)Visit PreviewApr 20, 2023 5:07am
nodejs-org-storybook✅ Ready (Inspect)Visit PreviewApr 20, 2023 5:07am

@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 19, 2023 18:21 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-storybook April 19, 2023 18:23 Inactive
@ovflowd

ovflowd commented Apr 19, 2023

Copy link
Copy Markdown
Member

ngl (not gonna lie), I love these deployments.

@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 20, 2023 05:06 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 20, 2023 05:07 Inactive
mikeesto
mikeesto approved these changes Apr 20, 2023
View reviewed changes

@mikeestomikeesto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first contribution

@ovflowd
ovflowd merged commit 79b5134 into nodejs:major/website-redesignApr 20, 2023
ovflowd added a commit that referenced this pull request May 3, 2023
@ktssr@ovflowd
Teja Sai Sandeep Reddy Konala@shanpriyan@mikeestoClaudio Wunder
chore(migration): migrate language selector component (#5266)
bf82db5
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
ovflowd added a commit that referenced this pull request May 14, 2023
@AugustinMauroyClaudio Wunder
Guilherme Araújo@manishprivet@ovflowdWai.Tung@shanpriyan@mikeesto@HinataKah0@Olaleye-Blessing@ktssrTeja Sai Sandeep Reddy Konala@Harkunwar@vasanth9@JatinSharma32@aymen94Teja Sai Sandeep Reddy Konala@anonrig@nschonni@FHachez@MrJithil
feat(stability): migrate component (#5339)
9221386
* feat(unit-test): introduce unit test on website redesign branch (#5178
feat(unit-test): introduce unit test
* chore(minor): just a tiny design nitpick
* chore: set up storybook (#5191) (#5214)
* chore: set up testing-library jest extend (#5231)
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
* chore(dependencies): updated dependencies
* feat: create section title component (#5237)
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
* 📎 chore(migration): migrate banner component (#5233)
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* feat: migrate AnimatedPlaceholder component (#5238
Migrate AnimatedPlaceholder component from nodejs.dev
and create a new Story.
* feat: create article alert component (#5243)
* feat: migrate blockquote component (#5259)
* feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281)
* feat: create article data tag component (#5280)
* feat: migrate AuthorList component and add story 🎉 (#5277)
Co-authored-by: Michael Esteban <mickel13@gmail.com>
* chore(migration): migrate language selector component (#5266)
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
* feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236)
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
* chore: updated contributing guidelines, eslint rules and storybook templates (#5294)
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
* chore: contributing quick fix of example
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* chore: story guide and react spreading
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* chore: remove base styles from old styling
* chore: fix storybook styles, imports, typescript config and dependencies (#5319
* chore: optimises tsconfig
* chiore: add missing dependencies
* chore: type storybook constants
* chore: styles moved styles to somewhere else
* chore: add global json type definition
* chore: i18n aria-label instead of sr-only
* chore: added open sans font family and space between imports
* chore: moved styles and fixed styles and updated banner stories
* fix: stylelint rules
* chore: updated tsconfig
* chore: fix tests
* fix: darkmodetoggle test
* chore: stories use index.stories.tsx
* chore: adopt turborepo (#5316
* chore: revert pnpm use plain npm
* fix: package.json
* chore: remove warnings and add node_env
* chore: cross-env
* fix: fix turbo pipelines
* chore: only cache certain files
* chore: turbo shouldn't care about coverage outputs
* chore: proper inputs and outputs for pipelines
* chore: do not store some outputs and updated inputs for lint
* chore: added prettier configs
* chore: remove console.info
* chore: updated inputs of all other entries
* fix(package.json) Lint command is missing slashes (#5321
fix(package.json) lint:fix missing slashes
* moved `DataTag` to `components/Api` (#5317)
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
* hot-fix: dependency updates and fix dev runtime
* chore: updated start command
* migration(Layout): newFooter (#5320)
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* feat: migrate EditLink component (#5271)
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
* feat(blog) Migrate BlogCard component (#5323)
Co-authored-by: Michael Esteban <mickel13@gmail.com>
* Issue#5307 - Add framer-motion to the dependency list (#5318)
* chore: add remote turbo cache and simplified gh actions cache (#5326)Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
* chore: add remote turbo cache and simplified gh actions cache
* chore: updated cache rules
* chore: more cache rules
---------
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
* chore: fix storybook local development mode (#5335)
* chore: migrate pagination component (#5331)
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
* Chore(node feat) (#5338)
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* chore: migrate releases types (#5324)
* hotfix: first element no margin-top
* (website redesign) Feat(shellbox): migration (#5234)
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
* fix(i18n): translation key (#5347)
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* chore: updated dependencies
* chore: vercel enable middleware and i18n redirection (#5300)
* feat(unit-test): introduce unit test on website redesign branch (#5178
feat(unit-test): introduce unit test
* chore: set up storybook (#5191) (#5214)
* feat(stylelint,storybook): fixed styleling misconfig and fixed storybooks (#5281)
* feat(DarkModeToggler): Migrate and add stories to theme toggler 🎉 (#5236)
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
* chore: updated contributing guidelines, eslint rules and storybook templates (#5294)
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
* chore: fix storybook styles, imports, typescript config and dependencies (#5319
* chore: optimises tsconfig
* chiore: add missing dependencies
* chore: type storybook constants
* chore: styles moved styles to somewhere else
* chore: add global json type definition
* chore: i18n aria-label instead of sr-only
* chore: added open sans font family and space between imports
* chore: moved styles and fixed styles and updated banner stories
* fix: stylelint rules
* chore: updated tsconfig
* chore: fix tests
* fix: darkmodetoggle test
* chore: stories use index.stories.tsx
* chore: adopt turborepo (#5316
* chore: revert pnpm use plain npm
* fix: package.json
* chore: remove warnings and add node_env
* chore: cross-env
* fix: fix turbo pipelines
* chore: only cache certain files
* chore: turbo shouldn't care about coverage outputs
* chore: proper inputs and outputs for pipelines
* chore: do not store some outputs and updated inputs for lint
* chore: added prettier configs
* chore: remove console.info
* chore: updated inputs of all other entries
* feat(stability): migrate component
* chore(snapshot): update
* Update components/Api/Stability/index.tsx
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update components/Api/Stability/index.tsx
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update components/Api/Stability/index.tsx
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fea(stability): update stories + fix
* Update components/Api/Stability/index.stories.tsx
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix(i18n): update turkish language direction (#5182)
* chore: rollback CODEOWNER changes (#5183)
* Sync: merge `major/website-redesign` into `main` (#5356)
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
* feat(stability): update snapshot
* Update components/Api/Stability/index.tsx
Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* code format
* Update components/Api/Stability/index.tsx
Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
---------
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Yagiz Nizipli <yagiz@nizipli.com>
Co-authored-by: Nick Schonning <nschonni@gmail.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowdovflowdovflowd approved these changes
@aymen94aymen94aymen94 approved these changes
@mikeestomikeestomikeesto approved these changes

Assignees

No one assigned

Labels

website redesignIssue/PR part of the Node.js Website Redesign

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ktssr@ovflowd@aymen94@mikeesto@shanpriyan