Skip to content

feat(stability): migrate component - #5339

Merged
ovflowd merged 62 commits into
nodejs:major/website-redesignfrom
AugustinMauroy:feat(stability)
May 14, 2023
Merged

feat(stability): migrate component#5339
ovflowd merged 62 commits into
nodejs:major/website-redesignfrom
AugustinMauroy:feat(stability)

Conversation

@AugustinMauroy

@AugustinMauroyAugustinMauroy commented Apr 28, 2023

Copy link
Copy Markdown
Member

@vercel

vercelBot commented Apr 28, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 14, 2023 8:01am
nodejs-org-stories✅ Ready (Inspect)Visit PreviewMay 14, 2023 8:01am

@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 28, 2023 20:45 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 28, 2023 20:46 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 29, 2023 09:03 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 29, 2023 09:04 Inactive
Comment threadcomponents/Api/Stability/index.tsx Outdated
Comment threadcomponents/Api/Stability/index.tsx Outdated

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments, but overall, LGTM! (And thanks for the contribution!)

Comment threadcomponents/Api/Stability/index.stories.tsx Outdated
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 30, 2023 10:49 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 10:50 Inactive
Comment threadcomponents/Api/Stability/index.tsx Outdated
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 30, 2023 16:21 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 16:22 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories April 30, 2023 21:54 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org April 30, 2023 21:56 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 1, 2023 03:36 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 1, 2023 03:37 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 3, 2023 08:55 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 3, 2023 08:57 Inactive
Comment threadcomponents/Api/Stability/index.stories.tsx Outdated
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 3, 2023 11:33 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 3, 2023 11:34 Inactive
@ovflowd
ovflowdforce-pushed the major/website-redesign branch from 7ddfa8d to f2a3ac4CompareMay 3, 2023 23:05
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 4, 2023 13:19 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 4, 2023 13:20 Inactive
@ovflowd
ovflowd deleted the branch nodejs:major/website-redesignMay 4, 2023 13:23
@ovflowdovflowd closed this May 4, 2023
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 4, 2023 13:24 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 4, 2023 13:25 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 5, 2023 08:01 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 5, 2023 08:02 Inactive

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! A little comment about the unit tests s

Comment threadcomponents/Api/Stability/__test__/index.test.tsx Outdated
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 08:33 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 11, 2023 08:37 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 11, 2023 08:39 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 11, 2023 08:44 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 12, 2023 18:47 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 12, 2023 18:48 Inactive

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a tiny comment

Comment threadcomponents/Api/Stability/index.module.scss
Comment threadcomponents/Api/Stability/index.tsx
Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 13, 2023 13:35 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 13, 2023 13:35 Inactive
Comment threadcomponents/Api/Stability/index.tsx Outdated
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 13, 2023 15:47 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 13, 2023 15:49 Inactive
Comment threadcomponents/Api/Stability/index.tsx
Co-authored-by: Jithil P Ponnan <MrJithil@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 14, 2023 07:56 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 14, 2023 08:01 Inactive

@HinataKah0HinataKah0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@ovflowd
ovflowd merged commit 9221386 into nodejs:major/website-redesignMay 14, 2023
ovflowd added a commit that referenced this pull request May 17, 2023
* test(snapshot): Migrate snapshot tests to storybook (#5340)
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
fixed styleling misconfig and fixed storybooks (#5281)
fix storybook styles, imports, typescript config and dependencies (#5319
fix(package.json) Lint command is missing slashes (#5321
fix storybook local development mode (#5335)
fix(i18n): translation key (#5347)
* chore: no-unused-vars ignores pattern starting with _ (#5363)
* Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369)
Add clarity to step 4 based on clone method
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
* fix(test): dir name (#5354)
* feat(stability): migrate component (#5339)
* Migrate JsonLink component (#5370)
* Migrate JsonLink component
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
* Add storybook snap and robot icon
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
* Remove IconContext provider
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
---------
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink
* refactor(useDownloadLink): rename file
* refactor(useDownloadLink): rename file
* Apply suggestions from code review
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* refactor(useDownloadLink): undo deleted file
---------
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* feat: Add MUI Config and Theme Provider (#5368)
* feat: Add MUI Config and Theme Provider
* added createTheme
* refactor themeConfig
* feat(theme): Fix linting and package-lock
* feat(theme): Add emotion styled and emtion react
---------
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
* refactor(delete): duplicate test file (#5377)
refactor(test): Delete duplicate test file
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* feat(useClickOutside): introduce (#5359)
* feat(useClickOutside): introduce
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* feat(useClickOutside): fix and twix
* feat(dropdown): remove useless ref
* feat(useClickOutside): update unit test
* feat(UseClickOutside): update type
* fix: usage of type
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* update listener
* Update components/Common/LanguageSelector/index.tsx
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix: languageSelector
* update with feedback
* better unit test
* Update hooks/useClickOutside.ts
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* feat(useClickOutside): update with feedback
* Update hooks/useClickOutside.ts
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update hooks/useClickOutside.ts
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix: if click on modal
* Update hooks/useClickOutside.ts
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update hooks/useClickOutside.ts
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
* Update hooks/useClickOutside.ts
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update useClickOutside.ts
* Update hooks/useClickOutside.ts
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update useClickOutside.ts
* Apply suggestions from code review
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix: build
---------
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
---------
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
Co-authored-by: Vessy <46304479+Ve33y@users.noreply.github.com>
Co-authored-by: Mert Can Altın <mertgold60@gmail.com>
ovflowd pushed a commit that referenced this pull request May 24, 2023
ovflowd pushed a commit that referenced this pull request May 24, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

website redesignIssue/PR part of the Node.js Website Redesign

Projects

None yet

Development

Successfully merging this pull request may close these issues.

13 participants

@AugustinMauroy@ovflowd@MrJithil@HinataKah0@shanpriyan@manishprivet@Olaleye-Blessing@ktssr@Harkunwar@vasanth9@JatinSharma32@anonrig@nschonni