Skip to content

refactor(useDownloadLink): Move useDetectOs to useDownloadLink - #5376

Merged
Harkunwar merged 5 commits into
nodejs:major/website-redesignfrom
Harkunwar:refactor/use-download-link
May 15, 2023
Merged

refactor(useDownloadLink): Move useDetectOs to useDownloadLink#5376
Harkunwar merged 5 commits into
nodejs:major/website-redesignfrom
Harkunwar:refactor/use-download-link

Conversation

@Harkunwar

@HarkunwarHarkunwar commented May 12, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Refactored this hook because it seems like the hook does something which isn't obvious from the name, which is mainly to get the download link for Node JS. detectOS is already a quick synchronous function so it doesn't make sense to have a hook to do the same either. Moreover, we're using useEffect when we don't need to, and it's bad for performance. We should avoid it whenever we can. Lastly, we should use swr for all async for better error handling. This PR also adds types for navigator so we don't need to ignore them and can be fully type safe.

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
  • I've covered new added functionality with unit tests if necessary.

@vercel

vercelBot commented May 12, 2023•
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

NameStatusPreviewCommentsUpdated (UTC)
nodejs-org✅ Ready (Inspect)Visit Preview💬 Add feedbackMay 15, 2023 1:00am
nodejs-org-stories✅ Ready (Inspect)Visit PreviewMay 15, 2023 1:00am

@Harkunwar
Harkunwar changed the base branch from main to major/website-redesignMay 12, 2023 19:16
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 12, 2023 19:17 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 12, 2023 19:18 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 12, 2023 19:21 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 12, 2023 19:22 Inactive
Harkunwar
Harkunwar commented May 12, 2023
View reviewed changes
Comment threadhooks/__test__/useCopyToClipboard.test.tsx
@Harkunwar
Harkunwar marked this pull request as ready for review May 13, 2023 02:06
@Harkunwar
Harkunwar requested a review from ovflowdMay 13, 2023 02:06
Harkunwar
Harkunwar commented May 13, 2023
View reviewed changes
Comment threadhooks/__tests__/useDownloadLink.test.ts
Harkunwar
Harkunwar commented May 13, 2023
View reviewed changes
Comment threadutil/getBitness.ts
Harkunwar
Harkunwar commented May 13, 2023
View reviewed changes
Comment threadhooks/__tests__/useDownloadLink.test.ts
@Harkunwar
Harkunwar requested a review from shanpriyanMay 13, 2023 02:10
@HarkunwarHarkunwar changed the title reafactor(useDownloadLink): Move useDetectOs to useDownloadLinkrefactor(useDownloadLink): Move useDetectOs to useDownloadLinkMay 13, 2023
@shanpriyan

shanpriyan commented May 13, 2023

Copy link
Copy Markdown
Contributor

I think we can remove the hooks/__test__/useCopyToClipboard.test.tsx file in a separate PR 🤔

shanpriyan
shanpriyan approved these changes May 13, 2023
View reviewed changes

@shanpriyanshanpriyan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

ovflowd
ovflowd reviewed May 14, 2023
View reviewed changes
Comment threadutil/getBitness.ts
ovflowd
ovflowd reviewed May 14, 2023
View reviewed changes
Comment threadhooks/useDownloadLink.ts
ovflowd
ovflowd approved these changes May 14, 2023
View reviewed changes

@ovflowdovflowd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 14, 2023 16:20 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 14, 2023 16:21 Inactive
@Harkunwar
Harkunwarforce-pushed the refactor/use-download-link branch from 1b05b01 to 7dc5791CompareMay 15, 2023 00:54
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 15, 2023 00:55 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 15, 2023 00:57 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org May 15, 2023 00:59 Inactive
@vercel
vercelBot temporarily deployed to Preview – nodejs-org-stories May 15, 2023 01:00 Inactive
@Harkunwar
Harkunwar enabled auto-merge (squash) May 15, 2023 01:03
@Harkunwar
Harkunwar merged commit 4444889 into nodejs:major/website-redesignMay 15, 2023
ovflowd added a commit that referenced this pull request May 17, 2023
@ovflowd@Harkunwar
@manishprivetWai.Tung@shanpriyan@mikeestoTeja Sai Sandeep Reddy Konala@aymen94Teja Sai Sandeep Reddy Konala@AugustinMauroyGuilherme Araújo@HinataKah0@Olaleye-Blessing@ktssr@vasanth9@FHachez@JatinSharma32@Ve33y@mertcanaltin
chore: updates main with latest major/website-redesign (#5382)
2065bf7
* test(snapshot): Migrate snapshot tests to storybook (#5340)
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Claudio Wunder <cwunder@hubspot.com>
Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
fixed styleling misconfig and fixed storybooks (#5281)
fix storybook styles, imports, typescript config and dependencies (#5319
fix(package.json) Lint command is missing slashes (#5321
fix storybook local development mode (#5335)
fix(i18n): translation key (#5347)
* chore: no-unused-vars ignores pattern starting with _ (#5363)
* Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369)
Add clarity to step 4 based on clone method
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
* fix(test): dir name (#5354)
* feat(stability): migrate component (#5339)
* Migrate JsonLink component (#5370)
* Migrate JsonLink component
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
* Add storybook snap and robot icon
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
* Remove IconContext provider
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
---------
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink
* refactor(useDownloadLink): rename file
* refactor(useDownloadLink): rename file
* Apply suggestions from code review
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* refactor(useDownloadLink): undo deleted file
---------
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* feat: Add MUI Config and Theme Provider (#5368)
* feat: Add MUI Config and Theme Provider
* added createTheme
* refactor themeConfig
* feat(theme): Fix linting and package-lock
* feat(theme): Add emotion styled and emtion react
---------
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
* refactor(delete): duplicate test file (#5377)
refactor(test): Delete duplicate test file
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
* feat(useClickOutside): introduce (#5359)
* feat(useClickOutside): introduce
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* feat(useClickOutside): fix and twix
* feat(dropdown): remove useless ref
* feat(useClickOutside): update unit test
* feat(UseClickOutside): update type
* fix: usage of type
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* update listener
* Update components/Common/LanguageSelector/index.tsx
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix: languageSelector
* update with feedback
* better unit test
* Update hooks/useClickOutside.ts
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* feat(useClickOutside): update with feedback
* Update hooks/useClickOutside.ts
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update hooks/useClickOutside.ts
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix: if click on modal
* Update hooks/useClickOutside.ts
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update hooks/useClickOutside.ts
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
* Update hooks/useClickOutside.ts
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update useClickOutside.ts
* Update hooks/useClickOutside.ts
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update useClickOutside.ts
* Apply suggestions from code review
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* Update hooks/useClickOutside.ts
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
* fix: build
---------
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
---------
Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com>
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
Co-authored-by: Wai.Tung <maledong_public@foxmail.com>
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com>
Co-authored-by: Michael Esteban <mickel13@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com>
Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com>
Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local>
Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com>
Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com>
Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com>
Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com>
Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com>
Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com>
Co-authored-by: Floran Hachez <floran.hachez@gmail.com>
Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com>
Co-authored-by: Vessy <46304479+Ve33y@users.noreply.github.com>
Co-authored-by: Mert Can Altın <mertgold60@gmail.com>
ovflowd added a commit that referenced this pull request May 24, 2023
@Harkunwar@ovflowdClaudio Wunder
refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)
c2c9a6d
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink
* refactor(useDownloadLink): rename file
* refactor(useDownloadLink): rename file
* Apply suggestions from code review
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* refactor(useDownloadLink): undo deleted file
---------
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
ovflowd added a commit that referenced this pull request May 24, 2023
@Harkunwar@ovflowd
refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376)
56d8aa6
* refactor(useDownloadLink): Move useDetectOs to useDownloadLink
* refactor(useDownloadLink): rename file
* refactor(useDownloadLink): rename file
* Apply suggestions from code review
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
* refactor(useDownloadLink): undo deleted file
---------
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
Co-authored-by: Claudio Wunder <cwunder@gnome.org>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ovflowdovflowdovflowd approved these changes
+1 more reviewer
@shanpriyanshanpriyanshanpriyan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Harkunwar@shanpriyan@ovflowd