Uh oh!
There was an error while loading. Please reload this page.
feat(useClickOutside): introduce - #5359
Merged
Harkunwar merged 34 commits intoMay 15, 2023
Merged
Conversation
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ovflowd
reviewed
May 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
ovflowd
reviewed
May 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
ovflowd
reviewed
May 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
ovflowd
reviewed
May 4, 2023
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
…uroy/nodejs.org into feat(useClickOutside)
Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
ovflowd
reviewed
May 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
ovflowd
reviewed
May 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
Signed-off-by: Claudio Wunder <cwunder@gnome.org>
ovflowd
reviewed
May 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
ovflowd
reviewed
May 14, 2023
Uh oh!
There was an error while loading. Please reload this page.
ovflowd
approved these changes
May 14, 2023
ovflowd
left a comment
Member
There was a problem hiding this comment.
LGTM! But I left a few suggestions!
shanpriyan
approved these changes
May 14, 2023
shanpriyan
left a comment
Contributor
There was a problem hiding this comment.
LGTM! 🚀
Good to go after resolving ovflowd's suggestions
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr>
aymen94
approved these changes
May 15, 2023
ovflowd added a commit
that referenced
this pull request
May 17, 2023
* test(snapshot): Migrate snapshot tests to storybook (#5340) Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Claudio Wunder <cwunder@hubspot.com> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> fixed styleling misconfig and fixed storybooks (#5281) fix storybook styles, imports, typescript config and dependencies (#5319 fix(package.json) Lint command is missing slashes (#5321 fix storybook local development mode (#5335) fix(i18n): translation key (#5347) * chore: no-unused-vars ignores pattern starting with _ (#5363) * Contributing Guidelines Update - Add clarity to step 4 based on clone method (#5369) Add clarity to step 4 based on clone method Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * fix(test): dir name (#5354) * feat(stability): migrate component (#5339) * Migrate JsonLink component (#5370) * Migrate JsonLink component Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * Add storybook snap and robot icon Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> * Remove IconContext provider Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> --------- Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * refactor(useDownloadLink): Move useDetectOs to useDownloadLink (#5376) * refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat: Add MUI Config and Theme Provider (#5368) * feat: Add MUI Config and Theme Provider * added createTheme * refactor themeConfig * feat(theme): Fix linting and package-lock * feat(theme): Add emotion styled and emtion react --------- Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * refactor(delete): duplicate test file (#5377) refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <cwunder@gnome.org> * feat(useClickOutside): introduce (#5359) * feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: build --------- Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> --------- Signed-off-by: Vessy Shestorkina <46304479+Ve33y@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Co-authored-by: Manish Kumar ⛄ <manishprivet@protonmail.com> Co-authored-by: Wai.Tung <maledong_public@foxmail.com> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Michael Esteban <mickel13@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <sandeep.konala@knacksystems.com> Co-authored-by: Aymen Naghmouchi <aymenadvance@gmail.com> Co-authored-by: Teja Sai Sandeep Reddy Konala <tejasaisandeepreddykonala@MacBook-Pro.local> Co-authored-by: Augustin Mauroy <97875033+AugustinMauroy@users.noreply.github.com> Co-authored-by: Guilherme Araújo <guilherme.araujo@maxxidata.com> Co-authored-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Co-authored-by: HinataKah0 <128208841+HinataKah0@users.noreply.github.com> Co-authored-by: Olaleye Blessing <Olayinkablexxy@gmail.com> Co-authored-by: ktssr <31731919+ktssr@users.noreply.github.com> Co-authored-by: vasanthkumar <42891954+vasanth9@users.noreply.github.com> Co-authored-by: Floran Hachez <floran.hachez@gmail.com> Co-authored-by: Jatin <96469998+JatinSharma32@users.noreply.github.com> Co-authored-by: Vessy <46304479+Ve33y@users.noreply.github.com> Co-authored-by: Mert Can Altın <mertgold60@gmail.com>
ovflowd added a commit
that referenced
this pull request
May 24, 2023
* feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: build --------- Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
ovflowd added a commit
that referenced
this pull request
May 24, 2023
* feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <cwunder@gnome.org> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <cwunder@gnome.org> Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> * fix: build --------- Signed-off-by: Augustin Mauroy <augustin.mauroy@outlook.fr> Signed-off-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com> Signed-off-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Claudio Wunder <cwunder@gnome.org> Co-authored-by: Shanmughapriyan S <priyanshan03@gmail.com> Co-authored-by: Harkunwar Kochar <10580591+Harkunwar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useClickOutsideRelated Issues
close: The Dropdown Component should handle clicks outside #5348
Check List
npx turbo lintto ensure the code follows the style guide. And runnpx turbo lint:fixto fix the style errors if necessary.npx turbo formatto ensure the code follows the style guide.npx turbo testto check if all tests are passing, and/ornpx turbo test:snapshotto update snapshots if I created and/or updated React Components.