fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(pm): derive the gates that re-derive from a package export surface - #14207

Merged
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation
Sep 1, 2026
Merged

fix(pm): derive the gates that re-derive from a package export surface#14207
baozhoutao merged 1 commit into
mainfrom
claude/issue-13518-spec-export-gate-derivation

Conversation

@claude

@claudeclaudeBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Fixes#13518

The reading, re-derived on this branch's base (987fe370, after PR #13862 / #14012 / #14188)

The card's premise still held. Its own re-check, run on a fresh tree:

node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack packages/spec/src/index.ts
gatebeforeafter
check:api-surfaceabsentmatched
check:export-originsabsentmatched
check:entry-nameabilityabsentmatched
check:exported-anyabsentmatched
check:dual-source-exportsabsentmatched
check:browser-reachable-entriesabsentmatched
check:strictness-ledger (positive control)presentpresent

33 matched families before, 39 after. The control was present in both runs, which is what makes the six an absence rather than a dead query.

Why the whole CLASS fell out of the derivation

Not six defects. Every one of the six re-derives its population from @objectstack/spec's public export surface, and none of them spells that surface as a path. Each reads packages/spec/package.json, walks its exports map, and resolves each subpath into a built dist/*.d.ts. So the population is computed through the manifest, and both places a literal could have carried it fail:

  • dist/ is a build output and untracked, so any literal reaching it dies in the reachability sweep by construction;
  • the literals these gates do write are anchored at a package root (resolve(PKG_DIR, 'src/index.ts')), and extractWatchHints resolves against exactly one anchor -- the writer's own directory. A literal with no ./ prefix is taken from the repo root, so 'src/index.ts' becomes the root hint src/index.ts and reaches nothing.

The derivation models three follows -- import, program-text read, exec -- and all three end at a program whose declared population can be inherited. A package manifest is not a program. So the entire class ended at a manifest read that contributed nothing, and each of the six scored silent with only its helper-module imports as population.

That this is a class and not a story is printed on other gates today: check:generated's dead leads are api-surface, export-origins and src/meta-spelling/... -- three literals alive under packages/spec/ and dead at the root.

The repair: an EDGE, not six names

⛔ No gate name is added to any table. Following the pattern PR #14012 established for exec edges, this adds the fourth follow -- the manifest edge -- routed through the same three pieces and adding none:

  • the followed file's own declaration decides what a caller inherits. For a module that is declaredInheritedPopulation; for a manifest it is the exports map, read from the tree rather than from a regex over the gate's prose;
  • hintOrigin / hintEdge label the inherited hint so it never travels as a claim the gate made itself. The via column reads gate source via the export surface declared by packages/spec/package.json;
  • it is appended last, after own, imported and run hints, so it can only fill a hole.

A second, smaller hop was required by one member: build-export-origins.ts reaches its package root through a function parameter (collectSourceEntries(pkgDir)), where the others use a constant. singleCallSiteParameters reads a parameter bound at exactly one call site -- the same one-hop shape singleReturnExpressions already uses. It is consulted only where nothing binds the name, which is the branch that returned unknown before, so it can add a reading and can never move one.

The narrowing that decides the number

A gate must actually read the exports map to follow the edge. Without that test the edge admits every reader of any manifest -- +1678 pairs on this tree, every one fabricated. The three live refusals, each checked at its own declaration site:

gatereadsverdict
check:docs-image-tagpackages/cli/package.json -> .versionrefused (235 fabricated pairs withdrawn)
check:authorable-surfacepackages/spec/package.json -> .versionrefused
check:generatedpackages/spec/package.json -> the scripts maprefused

check:generated is under-matched for packages/spec/src for the other reason above (package-root-anchored literals dying at the root). That is a different defect and is filed separately rather than fixed here under a test it does not pass.

Does a seventh gate of the class get covered automatically?

Yes, and it is demonstrated two ways rather than argued:

  1. A live seventh gate the card never named.check:dual-build-cjs-loads walks the same exports map and require()s every published entry (metadata-core's CJS entry point is unloadable since #12843 — import.meta emitted verbatim into dist/index.cjs is a parse-time error, so the guarding try/catch never runs #12971). It is picked up by the edge with nothing listing it. It gains no pairs -- its CI job filter is packages/** and already covered them -- it gains the right provenance, and the self-test pins it by name.
  2. An eighth that exists nowhere but the case. The self-test writes a gate in the class shape, in no table anywhere, and asserts it inherits the same population.

Blast radius, measured before and after

Over 199 discovered families x 7762 tracked files, counted through coveringKey -- the same key the printed block renders from:

(family, file) pairs the derivation covers 166173 -> 172797 (+6624)
pairs LOST 0
pairs RE-ATTRIBUTED (same pair, new via) 0
families whose VERDICT changes 6

The six take 1104 pairs each -- the whole of packages/spec/src, once, which is the defect exactly. No family outside the class moves in either direction.

Verification (all at f2b1d1fa)

scripts/pm/dispatch-gates.mjs is a gate script, so its own self-test is owed on top of the derived family:

commandresult
pnpm check:pm-dispatch-gates1110 cases pass, 0 fail -- 20 of them added by this diff
node scripts/pm/bare-root-worklist.mjs --self-testexit 0
node scripts/check-ratchet-remedy-authority.mjsexit 0
pnpm check:declared-population-liveexit 0
pnpm check:watch-hint-literalexit 0
pnpm check:entry-guard / check:parse-guardexit 0
pnpm check:cross-package-test-inputs + node scripts/check-cross-package-test-inputs.mjsexit 0
node scripts/check-ci-filter-parity.mjsexit 0
node scripts/check-shard-attestation.mjsexit 0
node scripts/check-self-test-wired.mjsexit 0
pnpm check:agent-test-spelling / check:bash32-floor / check:cli-command-ids / check:pnpm-filter-targetsexit 0
pnpm check:nul-bytesexit 0
node scripts/check-test-completeness.mjsNOT MEASURED -- it needs a saved turbo run test log; run bare it exits 3 and its own text says to record it as not measured

The family list was derived from the actual diff with node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (no path arguments -- the script takes its own change set), not quoted from the card.

Every exit code above was captured before any pipe. Two exit=3 readings on the first pass (check-ci-filter-parity, check-shard-attestation) were PREREQUISITE NOT MET -- a fresh worktree with no node_modules -- and are recorded green above only after pnpm install and a re-run.

Both directions pinned

The 15 new self-test cases pin the repair and its refusals, not that a derivation ran:

  • the six derive for packages/spec/src/index.ts, and the control still does;
  • and none of the six reaches that path on anything it spells itself -- without this half every case above passes on a key the gate already had, which is the reading that would let someone "fix" this by widening an unrelated literal;
  • the via column names the export surface, not a population the gate declares;
  • the identical manifest read with the exports read removed contributes nothing;
  • a manifest read inside a self-test body is a fixture, not the gate reaching a package;
  • a parameter with two call sites contributes nothing rather than a pick;
  • entry.manifests is exactly what the scan finds over the family's own files -- never a list kept in the file;
  • the live tree really has gates reading a manifest without reading its exports (6 gate files), and not one inherits a package source.

20 cases in total, counted from the diff. The pre-change baseline was not separately measured, so no before/after case count is claimed -- only that the suite is green at f2b1d1fa with 0 failures.

No changeset

The diff is one file under scripts/pm/** and publishes nothing from any package, so skip-changeset applies and the label is set on this PR.

Note for review

scripts/pm/dispatch-gates.mjs is the board's single-writer toolchain file. No open PR claimed it when this branch started -- re-checked against all 8 open PRs immediately before the first push.

Authoring session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code


Generated by Claude Code

Six gates re-derive their population from `@objectstack/spec`'s public
export surface, and every one was absent from the derivation for
`packages/spec/src/index.ts` -- the entry point that IS their subject.
One shape, one hole.
None of them spells that subject as a path. Each reads the package
manifest, walks its `exports` map, and resolves each subpath into a
built `dist/` that is untracked by construction. The derivation models
three follows and all three end at a PROGRAM whose declared population
it can inherit; a manifest is not a program, so the whole class ended
at a read that contributed nothing.
Adds the fourth follow -- the manifest edge -- routed through the same
pieces as the other three: the followed file's own declaration decides
what a caller inherits (here the `exports` map), `hintOrigin`/`hintEdge`
label it so it never travels as a claim the gate made itself, and it is
appended last so it can only fill a hole. A gate must READ the exports
map to follow it: three live gates read a manifest for `.version` or the
`scripts` map and inherit nothing.
Also reads a package root held in a PARAMETER (one call site, one
value), consulted only where nothing binds the name -- the branch that
returned `unknown` before -- which is the spelling one of the six uses.
Measured over 199 families x 7762 files: 166173 -> 172797 pairs (+6624),
0 lost, 0 re-attributed, 6 verdicts changed. A seventh live gate the
card never named, `check:dual-build-cjs-loads`, is covered by the same
edge, and the self-test pins an eighth that exists nowhere but the case.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
@claudeclaudeBot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Sep 1, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 1, 2026 12:57
@baozhoutao
baozhoutao added this pull request to the merge queueSep 1, 2026
Merged via the queue into main with commit 24b6635Sep 1, 2026
37 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-13518-spec-export-gate-derivation branch September 1, 2026 13:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/lskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] Six packages/spec export-surface gates are absent from the derivation when packages/spec/src/index.ts is the input — one shape, one repair

2 participants

@baozhoutao@claude