docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

docs(ci): stop hard-coding hook self-test deps in a comment - #14538

Merged
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment
Sep 2, 2026
Merged

docs(ci): stop hard-coding hook self-test deps in a comment#14538
baozhoutao merged 3 commits into
mainfrom
claude/issue-14141-hook-selftest-deps-comment

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14141

What

.github/workflows/lint.yml's Claude hook guard self-tests step discovers its
matrices by glob (find .claude/hooks -type f -name '*.selftest.sh' | sort), but
the comment above the step hard-coded a fixed dependency claim for the whole step.
That combination is a drift channel: a new matrix can need more than the original
two did without touching this comment, and one already does
(guard-governed-enqueue.selftest.sh needs node for real — see #14141 for the
full writeup). check:step-collectors cannot see this block (the comment already
admits as much a few lines up), so nothing catches the prose falling out of date.

This is option A from the triage (comment
#14141 (comment)):
rewrite the dependency sentence to describe only what the step itself needs, and
push the "what else" onto each matrix's own header — prose-for-prose, no new
machine channel. Options B/C (a preflight that parses matrix headers, deferred by
the triage) are out of scope here; .claude/hooks/** is untouched.

Before:

Needs jq and git and nothing else — no pnpm, no node, no build, no network
(jq is in the runner image and is already relied on bare by cut-rc.yml and
release.yml). ~2 s measured.

After:

This step itself needs only jq and git (both in the runner image; jq is
already relied on bare by cut-rc.yml and release.yml), plus whatever each
discovered matrix declares in its own header — discovery above is by glob, so a
matrix needing more (node, pnpm, a built tree, a generator) must say so there;
this comment is not the place to enumerate it.

The stale ~2 s measured figure is dropped along with it. No other line moves:
step name:, run: script, the find discovery, and the rest of the "Hermetic
by construction" paragraph (per-matrix throwaway git repos; re-run from a primary
checkout / detached HEAD / non-repo cwd) are untouched, and the
⚠️ check:step-collectors CANNOT see this block admission stays as-is.

Selftest census (why this matters right now)

All five matrices currently discovered under .claude/hooks/*.selftest.sh, and
whether each calls anything beyond jq/git/bash for real (not counting
node/pnpm strings that appear only inside simulated Bash-command fixtures fed
to the guard under test):

matrixown header saysreal extra deps
guard-governed-enqueue.selftest.sh"Needs jq … and node"node (both predicates run for real; one case runs a generator --check when deps are installed)
guard-main-checkout-bash.selftest.sh"Needs jq and git and nothing else"none
guard-main-checkout.selftest.sh"Needs jq and git and nothing else"none
guard-shared-stash.selftest.sh"Needs jq … and nothing"none
guard-tree-enum.selftest.sh"Needs jq … and nothing else"none

Only one matrix has drifted past jq+git so far, and it already documents its own
extra dependency in its own header — which is exactly the shape the rewritten
step comment now describes instead of enumerating. No second drift instance was
found, so route B (a preflight parsing matrix headers) stays deferred per the
triage.

Testing

  • find .claude/hooks -type f -name '*.selftest.sh' | sort — the step's own
    discovery command, run locally: discovers the same 5 files listed above.
  • The step's run: block executed locally, byte-for-byte (bash + jq + git + node
    are all present on this machine): all 5 matrices PASS, exit 0.
  • Gate union derived via node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands .github/workflows/lint.yml on the current
    head (commit 7987b5b2e, origin/main merged in twice as it advanced) — 23
    families, 22 RAN-PASS, 1 NOT-MEASURED (check:type-check-debt, exit 3
    PREREQUISITE NOT MET — needs the full workspace dependency closure built
    first; this is a comment-only YAML change with no bearing on type-check debt).
    pnpm check:pm-dispatch-gates (1240 self-test cases) also RAN-PASS. Full list
    in the issue comment report.
  • No changeset: this PR touches only a YAML comment under .github/**, no
    package or user-visible behaviour changes — skip-changeset label applied and
    confirmed by reading the PR's labels back.

Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV


Generated by Claude Code

The step comment claimed a fixed dependency set (jq + git only) for
the whole "Claude hook guard self-tests" step, but the step discovers
its matrices by glob (`find .claude/hooks -type f -name
'*.selftest.sh'`), so a new matrix can legitimately need more than the
two original ones did -- and one already does
(guard-governed-enqueue.selftest.sh needs `node` for real, to run its
two predicates). The comment never noticed; nothing catches that this
prose fell out of date, since check:step-collectors cannot see this
block (already admitted a few lines up).
Rewrite the dependency sentence to say what is true of the STEP
itself (jq + git, both already relied on bare elsewhere in this repo)
plus whatever each discovered matrix declares in its own header --
because discovery is by glob, a matrix needing more must say so
there, not here. Drop the stale "~2 s measured" figure along with it.
No other line moves: step name, run: script, find discovery, and the
rest of the "Hermetic by construction" paragraph are untouched.
@github-actions

Copy link
Copy Markdown
Contributor

⛔ merge queue 构建失败 — 先分诊,再决定要不要重排

队列构建 33623834019 红了。队列跑的是全量套件(PR 侧 CI 只跑 affected 子集),
所以失败的测试可能在本 PR 没碰过的包里 —— 那不是重排能修的。每次盲目重排都会让排在后面的所有 PR 重建一轮。

失败的 job(日志抽取,best effort):

  • Test Core (1/6) — 失败步骤: Run this shard's tests

    @objectstack/cli:test: FAIL unit test/vitest-tiers-partition.test.ts > the two tiers of packages/cli (#13504) > INTEGRATION_FILES equals the behavioural predicate over every file on disk
    ↳ 失败原因: @objectstack/cli:test: AssertionError: files that spawn the CLI or boot a kernel/driver but are NOT in INTEGRATION_FILES (add them): expected [ Array(1) ] to deeply equal []
    

↳ 失败原因 是判读的关键:超时Test timed out in … / Hook timed out in …)多半是负载/时序,不是本 PR 的回归;
断言AssertionError: …)才指向真实的行为改变。两者的 FAIL 行长得一模一样,只有这一行能区分。

⚠️断言这一侧有一类例外,判据是断言在测什么,不是它是不是 AssertionError 断言的对象是产品行为(一个值、一个形状、一次拒收)⇒ 照上面读:真实的行为改变,去查,⛔ 不要重排掉;
断言的对象是这次实验自身的有效性前提(跑完的耗时、负载下的先后、任何只在时间预算内才成立的条件)⇒ 它跟超时是同一类,同样对负载敏感,重排一次是合法的判别手段。
识别是机械的:断言的消息或它比较的值本身点名了一段时长、一个时间戳、一个耗时计数。实测过的一对 —— AssertionError: SecurityPlugin.init() ran: expected false to be true 测的是产品行为(真回归);
AssertionError: this run took over a second, so second-precision stamps could have differed too: expected 1006 to be less than 1000 测的是实验前提:它守护的那条不变式当时是绿的,同一个 head 原样重排一次即成功。
穿着 AssertionError 外衣的时间测量,仍然是时间测量。(⛔ 这只改「怎么读一次红」,不改「哪些测试可以重排」——后者由别处管。)

跨 PR 相同签名(24h,按失败测试文件聚合):

历史信号:

  • 本 PR 过去 24h 无队列失败记录(首次)。
  • 过去 24h 队列共有 3 个失败构建(不含本次)。

分诊清单:

  1. 失败测试在本 PR 改动的包里 → 真回归,修 PR。
  2. 失败测试与本 PR 无关 → 看上面的「跨 PR 相同签名」;已有汇总 issue ⇒ flaky/环境问题实锤,去那张 issue 上谈,修好前重排只会再烧一轮全队列。
  3. 两者都不是 → 可能与同组 PR 语义冲突;等前面的 PR 落地或失败出队后再重排一次即可,不要连续重排。

Generated by Claude Code · merge-queue-triage workflow (#4859)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cdsize/xsskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants

@baozhoutao@claude