Uh oh!
There was an error while loading. Please reload this page.
skills(automation): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14578
Merged
Merged
Conversation
… row #14296 item 2 = A (comment 5507419465): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14308 — round 1 (PR #14467, merged) implemented every finding in skills/objectstack-automation/SKILL.md and deferred AUTO-B-04, the evals/README.md planned-structure stub, to this ruling. Deletes skills/objectstack-automation/evals/README.md (414 tokens — the template listing planned eval files that do not exist) and drops its one ceiling row from scripts/check-skills-token-ratchet.mjs. The real fixture evals/approvals/test-revise-loop.md and its ratchet row are untouched. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
This was referenced Sep 2, 2026
os-zhuang
approved these changes
Sep 2, 2026
os-zhuang
marked this pull request as ready for review
September 2, 2026 14:05
os-zhuang
enabled auto-merge
September 2, 2026 14:05
Uh oh!
There was an error while loading. Please reload this page.
os-zhuang
deleted the
claude/issue-14308-automation-eval-stub-removal
branch
September 2, 2026 14:40
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#14308
#14296 item 2 = A, comment 5507419465 (09:27Z,
1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14308 — round 1 (PR #14467, merged) implemented every finding inskills/objectstack-automation/SKILL.mdand deferred AUTO-B-04, theevals/README.mdplanned-eval stub, to this ruling. Per the round-1 ACCEPT comment (5506911275), AUTO-B-04 is the only deferred item recorded for this card, so this round closes it.Verified before touching anything:
evals/README.md's "Planned structure" ASCII tree lists four files that do not exist anywhere in the repo (evals/approvals/test-quorum-behaviors.md,evals/flows/test-schedule-binding.md,evals/flows/test-decision-edges.md,evals/triggers/test-time-relative.md) — it is the planned-structure stub, not a real fixture.skills/objectstack-automation/SKILL.mdhas zero references toevals/(grep, 0 hits), so nothing links to the deleted file, and nothing in the repo outsidescripts/check-skills-token-ratchet.mjsnames its path.The two-file diff
skills/objectstack-automation/evals/README.mdscripts/check-skills-token-ratchet.mjs['skills/objectstack-automation/evals/README.md', 414]— the only edit to that script this flight makesNo prose edit anywhere, no new file, no ceiling raised, no other package touched. The real fixture
skills/objectstack-automation/evals/approvals/test-revise-loop.mdand its ratchet row (ceiling 1329, currently 550 tokens / headroom 779) are untouched.Reverse verification — the ratchet red → green pair
Before dropping the row (file deleted via
git rm, row still present):exit 1 — matches the header's documented behaviour exactly: "Missing file or empty read is RED, never a pass (#4690: a gate that cannot find its input must fail, not skip)."
After dropping the row:
exit 0 (was 37 authored files before the deletion, 36 after — exactly the dropped row).
--self-test:✓ check-skills-token-ratchet self-test: 64 cases pass.(the row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on this row, so dropping it needed no other change).Gates — head sha
81ec9d3dUnion re-derived after the final commit:
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands(checked against this checkout'soriginremote — it holds) → 24 command(s), all run underscripts/pm/os-verify-lock.sh(OS_VERIFY_LOCK_SLOT=issue-14308-r2); every exit code captured before any pipe.node scripts/check-ci-filter-parity.mjscoreorcrosspkg, everycrosspkgentry still covers one, and thetestjob'sif:still names both filtersnode scripts/check-cross-package-test-inputs.mjsnode scripts/check-shard-attestation.mjsnode scripts/check-skills-token-ratchet.mjsnode scripts/check-test-completeness.mjsturbo run testlog named; NOT MEASURED, not a findingnode scripts/pm/bare-root-worklist.mjs --self-testpnpm --filter @objectstack/lint run check:doc-formula-expressions@objectstack/formulanot built; this flight touches neither formula nor its docspnpm check:agent-test-spelling--token(s), 1380 launcher-rooted run(s)pnpm check:bash32-floorpnpm check:cli-command-idspnpm check:corpus-claim-driftpnpm check:cross-package-test-inputspnpm check:doc-authoringpnpm check:entry-guardpnpm check:parse-guardpnpm check:pm-dispatch-gatespnpm check:pm-governed-mergespnpm check:pnpm-filter-targets--filteroccurrence(s) across 32 file(s) resolve against 78 workspace package(s)pnpm check:ratchet-remedy-authoritypnpm check:role-wordpnpm check:skill-compatibilitypnpm check:skill-frame-syncpnpm check:skill-identifier-livenesspnpm check:watch-hint-literalcheck:skill-docs(pnpm --filter @objectstack/spec check:skill-docs) →✅ Skill docs in sync— no regeneration needed (neither generated file listsevals/).check:skill-compatibilityandcheck:skill-identifier-livenessboth green, unaffected by the deletion (the eval README carried no identifier binding: Leg 1 484 citations / Leg 2 8 exhaustive sections, both stable).check:published-readme-linksgreen — 176 outbound links, 103/103 relative targets found (the deleted file was linked from nothing).node scripts/check-nul-bytes.mjs→ clean (7953 text files scanned), plus a directgrep -naPC0-control scan of the changed script file, clean.NOT MEASURED (2):
node scripts/check-test-completeness.mjsexits 3, its ownPREREQUISITE NOT METcode — needs a savedturbo run testlog this run has no reason to produce; CI supplies it.pnpm --filter @objectstack/lint run check:doc-formula-expressionsexits 3,PREREQUISITE NOT MET— the workspace package@objectstack/formulais not built; this flight touches neitherformulanor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.Labels
skip-changeset— this diff releases nothing from any package (skills/**+ onescripts/**ratchet-row edit); checked againstscripts/check-empty-changeset.mjs's own enumeration (:357, "It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ noneeds:contract-review.Stays draft:
skills/**is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.🤖 Generated with Claude Code
https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
Generated by Claude Code