Uh oh!
There was an error while loading. Please reload this page.
skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585
Merged
Merged
Conversation
#14296 item 2 = A (comment 5507419465): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. Deletes skills/objectstack-query/evals/README.md (558-token stub of nine "Planned Evals" scenarios never built) and drops its row from scripts/check-skills-token-ratchet.mjs -- the only edit to that script this flight makes. Fixes#14302, round 2. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
This was referenced Sep 2, 2026
os-zhuang
approved these changes
Sep 2, 2026
os-zhuang
marked this pull request as ready for review
September 2, 2026 14:06
os-zhuang
enabled auto-merge
September 2, 2026 14:06
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Sep 2, 2026
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#14302
#14296 item 2 = A, comment 5507419465 (09:27Z,
1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding onskills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), theevals/README.mdplanned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.Verified before touching anything:
find skills/objectstack-query/evalsshowed onlyREADME.md— no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.The two-file diff
skills/objectstack-query/evals/README.mdscripts/check-skills-token-ratchet.mjs['skills/objectstack-query/evals/README.md', 567]— the only edit to that script this flight makesNo prose edit anywhere, no new file, no ceiling raised, no other package touched.
Reverse verification — the ratchet red → green pair
Before dropping the row (file deleted, row still present):
exit 1 — matches the header's documented behaviour exactly.
After dropping the row:
exit 0.
--self-test:✓ check-skills-token-ratchet self-test: 64 cases pass.(the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).Gates — head sha
3e1a218eUnion re-derived after the final commit:
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands(checked against this checkout'soriginremote — it holds) → 24 command(s), all run underscripts/pm/os-verify-lock.sh(slotissue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then$?read directly).node scripts/check-ci-filter-parity.mjscore/crosspkg, everycrosspkgentry still covers one,testjob'sif:names both filtersnode scripts/check-cross-package-test-inputs.mjsnode scripts/check-shard-attestation.mjsnode scripts/check-skills-token-ratchet.mjsnode scripts/check-test-completeness.mjsturbo run testlog named; NOT MEASURED, not a findingnode scripts/pm/bare-root-worklist.mjs --self-testpnpm --filter @objectstack/lint run check:doc-formula-expressions@objectstack/formulanot built; this flight touches neither formula nor its docspnpm check:agent-test-spellingpnpm check:bash32-floorpnpm check:cli-command-idspnpm check:corpus-claim-driftpnpm check:cross-package-test-inputspnpm check:doc-authoringpnpm check:entry-guardpnpm check:parse-guardpnpm check:pm-dispatch-gatespnpm check:pm-governed-mergespnpm check:pnpm-filter-targets--filteroccurrence(s) across 32 file(s) resolve against 78 workspace package(s)pnpm check:ratchet-remedy-authoritypnpm check:role-wordpnpm check:skill-compatibilitypnpm check:skill-frame-syncpnpm check:skill-identifier-livenesspnpm check:watch-hint-literalcheck:skill-docs(pnpm --filter @objectstack/spec check:skill-docs) →✅ Skill docs in sync— no regeneration needed (neither generated file listsevals/).check:skill-identifier-livenessandcheck:skill-compatibilityboth green, unaffected by the deletion (the eval README carried no identifier binding).node scripts/check-nul-bytes.mjs→ clean (7,953 tracked text files, no raw control bytes).NOT MEASURED (2):
node scripts/check-test-completeness.mjsexits 3, its ownPREREQUISITE NOT METcode — needs a savedturbo run testlog this run has no reason to produce; CI supplies it.pnpm --filter @objectstack/lint run check:doc-formula-expressionsexits 3,PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built— this flight touches neitherformulanor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.Labels
skip-changeset— this diff releases nothing from any package (skills/**+ onescripts/**ratchet-row edit); checked againstscripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ noneeds:contract-review.Stays draft:
skills/**is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.🤖 Generated with Claude Code
https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
Generated by Claude Code