skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2) - #14585

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal
Sep 2, 2026
Merged

skills(query): delete the planned-eval stub and drop its ceiling row (#14296 item 2)#14585
os-zhuang merged 1 commit into
mainfrom
claude/issue-14302-query-eval-stub-removal

Conversation

@os-litant

Copy link
Copy Markdown
Collaborator

Fixes#14302

#14296 item 2 = A, comment 5507419465 (09:27Z, 1A 2A 3A 4A): the planned-eval stubs are deleted and their ceilings step down; real fixtures stay. This is round 2 of #14302 — round 1 (PR #14443, merged) implemented every RESTRUCTURE finding on skills/objectstack-query/**; this round executes the one item it deferred (QRY-D-05 / H-02 / H-03), the evals/README.md planned-eval stub. Per the seat's ACCEPT comment on #14443, the eval stub is the only deferred item recorded for this card — so this PR closes it.

Verified before touching anything: find skills/objectstack-query/evals showed only README.md — no other file or subdirectory in that tree. The README is nine prose "Planned Evals" scenarios, not an ASCII listing of fixture paths — there is no separate path to check for existence; the scenarios themselves were never built into eval cases anywhere in the repo.

The two-file diff

filechange
skills/objectstack-query/evals/README.mddeleted (558 tokens, 39 lines — nine "Planned Evals" scenarios never built)
scripts/check-skills-token-ratchet.mjsone row dropped: ['skills/objectstack-query/evals/README.md', 567] — the only edit to that script this flight makes

No prose edit anywhere, no new file, no ceiling raised, no other package touched.

Reverse verification — the ratchet red → green pair

Before dropping the row (file deleted, row still present):

$ node scripts/check-skills-token-ratchet.mjs
✗ check-skills-token-ratchet: cannot read skills/objectstack-query/evals/README.md — red, not a skip (#4690).

exit 1 — matches the header's documented behaviour exactly.

After dropping the row:

$ node scripts/check-skills-token-ratchet.mjs
✓ check-skills-token-ratchet: skills/objectstack-query/SKILL.md is 3915 tokens (ceiling 5552; headroom 1637).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/aggregation.md is 1846 tokens (ceiling 2357; headroom 511).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/filters.md is 2136 tokens (ceiling 2149; headroom 13).
✓ check-skills-token-ratchet: skills/objectstack-query/rules/pagination.md is 1158 tokens (ceiling 1382; headroom 224).
✓ check-skills-token-ratchet: 36 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted.

exit 0. --self-test: ✓ check-skills-token-ratchet self-test: 64 cases pass. (the dropped row is keyed by exact relative path; nothing else in the self-test's fixtures or pinned counts depends on it, so dropping it needed no other change).

Gates — head sha 3e1a218e

Union re-derived after the final commit: node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands (checked against this checkout's origin remote — it holds) → 24 command(s), all run under scripts/pm/os-verify-lock.sh (slot issue-14302-r2-gates; held 20m28s, waited 9m00s across two acquisitions — the first hit its queue budget and resumed the same slot per the wrapper's own guidance); every exit code captured before any pipe (redirected to a log file, then $? read directly).

commandexitresult
node scripts/check-ci-filter-parity.mjs0all 130 declared cross-package glob(s) (92 unique) covered by core/crosspkg, every crosspkg entry still covers one, test job's if: names both filters
node scripts/check-cross-package-test-inputs.mjs025 package(s) read outside themselves, all declared, turbo.json hashes every declared glob
node scripts/check-shard-attestation.mjs02 aggregate gate(s) count 3 declared leg(s) across 3 attesting job(s)
node scripts/check-skills-token-ratchet.mjs036 authored bundle file(s) within their ceilings; 11 generator-owned file(s) measured, not ratcheted
node scripts/check-test-completeness.mjs3PREREQUISITE NOT MET — no saved turbo run test log named; NOT MEASURED, not a finding
node scripts/pm/bare-root-worklist.mjs --self-test0self-test OK — 57 live row(s), 49 recorded verdict(s), none stale/missing/contradicted
pnpm --filter @objectstack/lint run check:doc-formula-expressions3PREREQUISITE NOT MET — @objectstack/formula not built; this flight touches neither formula nor its docs
pnpm check:agent-test-spelling0self-test + live sweep clean
pnpm check:bash32-floor026 tracked shell file(s), no bash4+ construct outside guarded positions
pnpm check:cli-command-ids0315 command-id literal(s) across 112 file(s) all resolve
pnpm check:corpus-claim-drift01 rule row, 2 baselined file(s), clean
pnpm check:cross-package-test-inputs0117 self-test cases pass; 25 package(s) declared, all covered
pnpm check:doc-authoring014491 customer-facing string(s) across 710 spec sources clean; sibling-package baseline holds
pnpm check:entry-guard0199 scripts/ file(s), 150 export bindings, all safe
pnpm check:parse-guard0clean
pnpm check:pm-dispatch-gates0dispatch-gates self-test: 1240 cases pass
pnpm check:pm-governed-merges0self-test: 243 assertions; live: real generator declared 9 output(s), certified this tree
pnpm check:pnpm-filter-targets0142/181 --filter occurrence(s) across 32 file(s) resolve against 78 workspace package(s)
pnpm check:ratchet-remedy-authority0184 scripts swept; 12 marked ⛔ MAINTAINER-ONLY, 6 turned down, 166 hand out no remedy
pnpm check:role-word0224 .md/.mdx file(s) scanned; ledger 42 baselined file(s) unchanged by this flight
pnpm check:skill-compatibility011 SKILL.md file(s) reconciled against 78 workspace packages
pnpm check:skill-frame-sync04 copies of the decision frame structurally isomorphic across 3 files
pnpm check:skill-identifier-liveness0Leg 1: 484 citation(s) over 46 published file(s); Leg 2: 8 registered exhaustive section(s), 0 ledgered gaps
pnpm check:watch-hint-literal045 declaration(s) across 4 rostered name(s), no unrostered spelling

check:skill-docs (pnpm --filter @objectstack/spec check:skill-docs) → ✅ Skill docs in sync — no regeneration needed (neither generated file lists evals/). check:skill-identifier-liveness and check:skill-compatibility both green, unaffected by the deletion (the eval README carried no identifier binding). node scripts/check-nul-bytes.mjs → clean (7,953 tracked text files, no raw control bytes).

NOT MEASURED (2):node scripts/check-test-completeness.mjs exits 3, its own PREREQUISITE NOT MET code — needs a saved turbo run test log this run has no reason to produce; CI supplies it. pnpm --filter @objectstack/lint run check:doc-formula-expressions exits 3, PREREQUISITE NOT MET — the workspace package @objectstack/formula is not built — this flight touches neither formula nor its docs, so building it just to green a prerequisite gate would be verification-face padding on a two-file deletion; CI builds the closure and supplies a real reading.

Labels

skip-changeset — this diff releases nothing from any package (skills/** + one scripts/** ratchet-row edit); checked against scripts/check-empty-changeset.mjs's own enumeration ("It releases nothing (.github/, .claude/, skills/, docs/, content/, examples/, tests-only, and the like) -> delete the changeset and apply the 'skip-changeset' label"). No contract claim in this diff ⇒ no needs:contract-review.

Stays draft: skills/** is a governed surface (docs/adr/** · .claude/** · skills/** · AGENTS.md · CLAUDE.md) — landing is the maintainer's, by hand.

🤖 Generated with Claude Code

https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1


Generated by Claude Code

#14296 item 2 = A (comment 5507419465): the planned-eval stubs are
deleted and their ceilings step down; real fixtures stay. Deletes
skills/objectstack-query/evals/README.md (558-token stub of nine
"Planned Evals" scenarios never built) and drops its row from
scripts/check-skills-token-ratchet.mjs -- the only edit to that
script this flight makes.
Fixes#14302, round 2.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LraLgQVGq8egUwfYZpbYt1
@os-zhuang
os-zhuang marked this pull request as ready for review September 2, 2026 14:06
@os-zhuang
os-zhuang added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d80140cSep 2, 2026
39 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-14302-query-eval-stub-removal branch September 2, 2026 14:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

3 participants

@os-litant@os-zhuang@claude