Uh oh!
There was an error while loading. Please reload this page.
feat(showcase): page-local state demo + flip variables @experimental→live (ADR-0049) - #2269
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 91 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
os-zhuangforce-pushed
the
feat/page-variables-adr0049
branch
from
June 24, 2026 06:59
45a5bce to
9fdae2fCompare…live (ADR-0049) The page-variable end-to-end loop is now implemented in objectui (page state injected as `page.<var>`, element:record_picker writes via `source`, visibility gates live), so promote PageSchema.variables from @experimental to live and ship a worked example. - spec: replace the @experimental marker on PageSchema.variables with live docs; enrich PageVariableSchema (binding direction: a variable names its writer component via `source`). - spec liveness ledger: flip page.variables experimental→live with the objectui consumer cited (packages/spec/liveness/page.json) — passes check:liveness. - showcase: new master/detail page `showcase_page_variables` — a record picker writes `selectedProjectId`; a detail panel gates on `page.selectedProjectId`. Wired into navigation + the app config. - dogfood test: asserts the wiring is coherent and the gating predicates flip with the variable (mutually exclusive empty/detail states) + registration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
os-zhuangforce-pushed
the
feat/page-variables-adr0049
branch
from
June 24, 2026 07:02
9fdae2f to
d4fae4eCompareUh oh!
There was an error while loading. Please reload this page.
os-zhuang added a commit
that referenced
this pull request
Jun 24, 2026
…ig removal (#2268) (#2272) #2268 hard-removed 16 dead exports (6 from ./ui Blank/RecordReview, 10 from ./studio PageBuilder/Canvas/Palette) and #2265 added PAGE_TYPE_ROADMAP, but the committed api-surface.json snapshot was never regenerated — so check:api-surface has been red on main for every PR touching packages/spec/** (surfaced on #2269). Regenerate the snapshot to match the built surface. Diff is exactly the 16 intentional removals + PAGE_TYPE_ROADMAP; api-surface-signatures.json unchanged; the frozen downstream-contract gate is unaffected (it never referenced these symbols). Kept at minor (not a major bump) as a deliberate, documented exception to the ADR-0059 §4 freeze contract — see the appended note in the #2268 changeset. The removed symbols are config for renderless page types with no plausible functional consumer; the pre-publish hotcrm live gate guards any real break. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Promotes
PageSchema.variablesfrom@experimentalto live (ADR-0049) and ships a worked example. The end-to-end page-variable loop is now implemented in objectui (companion PR objectstack-ai/objectui#1957): page state is injected into the expression context aspage.<var>,element:record_pickerwrites a variable viasource, andvisibilitypredicates gate live.Changes
packages/spec/src/ui/page.zod.ts) — replace the@experimentalmarker onPageSchema.variableswith live docs; enrichPageVariableSchema(binding direction: a variable names its writer component viasource, e.g.{ name: 'selectedProjectId', source: 'project_picker' }).showcase_page_variables: a record picker writesselectedProjectId; a detail panel gates onpage.selectedProjectId != ''(empty-state hint on== ''). Wired into navigation + the app config.test/page-variables.test.ts) — asserts the wiring is coherent (variable bound to a real picker id) and the gating predicates actually flip with the variable (mutually-exclusive empty/detail states), plus config + nav registration.Verification
Requires objectstack-ai/objectui#1957 for the runtime behavior.
🤖 Generated with Claude Code