Uh oh!
There was an error while loading. Please reload this page.
docs(qa): correct two dogfood headers that still state ADR-0094's retired 2026-07-14 overlay direction - #8290
Merged
os-zhuang merged 1 commit intoAug 13, 2026
Conversation
…ired 2026-07-14 overlay direction (#7351) Both suites already pin the post-#6483 refusal correctly in their test bodies, which carry the #6483 annotations. Only the file headers still described the 2026-07-14 direction — "a data-plane edit is TRANSLATED into an env-scope ADR-0005 overlay" and "delete RESETS to the declared body" — as current. That direction was retired on 2026-08-09 by ADR-0094 D5-R (#6858 / PR #6962), after #6483 / PR #6608 rolled `permission` back to `allowOrgOverride: false`. Prose only: the diff touches comment lines exclusively, no assertion and no behaviour changes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016pY4Xb2iDecfDtT3CWoiTW
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
📓 Docs Drift CheckNo hand-written docs reference the 0 changed package(s). ✅ |
This was referenced Aug 13, 2026
os-zhuang
marked this pull request as ready for review
August 13, 2026 03:54
Uh oh!
There was an error while loading. Please reload this page.
os-zhuang
deleted the
claude/issue-7351-adr-0094-retired-direction-copies
branch
August 13, 2026 04:11
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #7351 — this is the
packages/qahalf. The card's third site (theADR-0094 D2 parenthetical, under
docs/adr/**) ships as a separate PR, because adocs/adr/**path hit routes a PR to maintainer-only landing and this half needs nosuch wait. Neither PR blocks the other.
What was wrong
ADR-0094's 2026-07-14 direction — an env-scope overlay is the platform's standard
ADR-0005 customization of a packaged permission set, and deleting the overlay resets
the row to the shipped declaration — was retired on 2026-08-09 by ADR-0094 D5-R
(#6858 / PR #6962), after #6483 / PR #6608 rolled
permissionback toallowOrgOverride: false.Two dogfood file headers still described that retired direction as current:
packages/qa/dogfood/test/two-doors-permission.dogfood.test.ts— the 块2 headerstated both retired halves verbatim ("TRANSLATED into an env-scope metadata OVERLAY
(the standard ADR-0005 customization)" and "'delete' resets to the shipped
declaration").
packages/qa/dogfood/test/showcase-permission-projection.dogfood.test.ts— headeritem 3's looser "deleting an artifact-backed set RESETS it to the declared body".
In both files the test bodies are already correct and carry their
#6483annotations; only the headers had drifted. This is the same silent-by-construction
class as #7082, one package over.
What changed
Header prose only. Each header now states the refusal that its own body asserts, marks
the 2026-07-14 direction as retired, and points at D5-R. The showcase header additionally
records that with no overlay left to lift the delete is a no-op success rather than a
revert-to-declared step — matching the annotation its delete case already carries.
Not touched, on purpose: no assertion, no behaviour, no gate. The card is explicit
that the test bodies are right and the header is what is wrong, so nothing was "fixed"
to match a stale header. No currency gate was built (that idea is #7082's disposition B,
which was not dispatched).
Verification
Premise re-verified before editing: the card was measured on
origin/main@f3f855ac,so all three quoted passages were re-located by text and confirmed still verbatim on
ecb39ea22.//comment(
git diff -U0filtered for non-comment changes returns empty).pnpm --filter '@objectstack/dogfood^...' build(62-package closure), thenpnpm --filter @objectstack/dogfood typecheck— clean.pnpm --filter @objectstack/dogfood test— 104 test files passed, 1 skipped; 719tests passed, 2 expected-fail, 3 skipped, 0 failed.
node scripts/pm/dispatch-gates.mjs:check:test-source-alias,check:type-source-resolution(path-derived),check:query-options-erasure,check:type-check-coverage(convention-triggered byediting test files), plus
check:nul-bytes. All five green locally.No changeset: comment-only change in test files, nothing user-visible is released — the
PR carries
skip-changeset.Generated by Claude Code