Skip to content

docs(qa): correct two dogfood headers that still state ADR-0094's retired 2026-07-14 overlay direction - #8290

Merged
os-zhuang merged 1 commit into
mainfrom
claude/issue-7351-adr-0094-retired-direction-copies
Aug 13, 2026
Merged

docs(qa): correct two dogfood headers that still state ADR-0094's retired 2026-07-14 overlay direction#8290
os-zhuang merged 1 commit into
mainfrom
claude/issue-7351-adr-0094-retired-direction-copies

Conversation

@os-zhuang

Copy link
Copy Markdown
Contributor

Part of #7351 — this is the packages/qa half. The card's third site (the
ADR-0094 D2 parenthetical, under docs/adr/**) ships as a separate PR, because a
docs/adr/** path hit routes a PR to maintainer-only landing and this half needs no
such wait. Neither PR blocks the other.

What was wrong

ADR-0094's 2026-07-14 direction — an env-scope overlay is the platform's standard
ADR-0005 customization of a packaged permission set, and deleting the overlay resets
the row to the shipped declaration — was retired on 2026-08-09 by ADR-0094 D5-R
(#6858 / PR #6962), after #6483 / PR #6608 rolled permission back to
allowOrgOverride: false.

Two dogfood file headers still described that retired direction as current:

  • packages/qa/dogfood/test/two-doors-permission.dogfood.test.ts — the 块2 header
    stated both retired halves verbatim ("TRANSLATED into an env-scope metadata OVERLAY
    (the standard ADR-0005 customization)" and "'delete' resets to the shipped
    declaration").
  • packages/qa/dogfood/test/showcase-permission-projection.dogfood.test.ts — header
    item 3's looser "deleting an artifact-backed set RESETS it to the declared body".

In both files the test bodies are already correct and carry their #6483
annotations; only the headers had drifted. This is the same silent-by-construction
class as #7082, one package over.

What changed

Header prose only. Each header now states the refusal that its own body asserts, marks
the 2026-07-14 direction as retired, and points at D5-R. The showcase header additionally
records that with no overlay left to lift the delete is a no-op success rather than a
revert-to-declared step — matching the annotation its delete case already carries.

Not touched, on purpose: no assertion, no behaviour, no gate. The card is explicit
that the test bodies are right and the header is what is wrong, so nothing was "fixed"
to match a stale header. No currency gate was built (that idea is #7082's disposition B,
which was not dispatched).

Verification

Premise re-verified before editing: the card was measured on origin/main @ f3f855ac,
so all three quoted passages were re-located by text and confirmed still verbatim on
ecb39ea22.

  • The diff is mechanically comment-only — every changed line is a // comment
    (git diff -U0 filtered for non-comment changes returns empty).
  • pnpm --filter '@objectstack/dogfood^...' build (62-package closure), then
    pnpm --filter @objectstack/dogfood typecheck — clean.
  • pnpm --filter @objectstack/dogfood test104 test files passed, 1 skipped; 719
    tests passed, 2 expected-fail, 3 skipped, 0 failed.
  • Gates re-derived against the final diff with node scripts/pm/dispatch-gates.mjs:
    check:test-source-alias, check:type-source-resolution (path-derived),
    check:query-options-erasure, check:type-check-coverage (convention-triggered by
    editing test files), plus check:nul-bytes. All five green locally.

No changeset: comment-only change in test files, nothing user-visible is released — the
PR carries skip-changeset.


Generated by Claude Code

…ired 2026-07-14 overlay direction (#7351)
Both suites already pin the post-#6483 refusal correctly in their test bodies,
which carry the #6483 annotations. Only the file headers still described the
2026-07-14 direction — "a data-plane edit is TRANSLATED into an env-scope
ADR-0005 overlay" and "delete RESETS to the declared body" — as current. That
direction was retired on 2026-08-09 by ADR-0094 D5-R (#6858 / PR #6962), after
#6483 / PR #6608 rolled `permission` back to `allowOrgOverride: false`.
Prose only: the diff touches comment lines exclusively, no assertion and no
behaviour changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_016pY4Xb2iDecfDtT3CWoiTW
@vercel

vercelBot commented Aug 13, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentActionsUpdated (UTC)
objectstackIgnoredIgnoredAug 13, 2026 3:34am

Request Review

@os-zhuangos-zhuang added skip-changeset PR has no user-facing published change; bypasses the changeset gate and removed tests labels Aug 13, 2026 — with Claude
@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

No hand-written docs reference the 0 changed package(s). ✅

@os-zhuang
os-zhuang marked this pull request as ready for review August 13, 2026 03:54
@os-zhuang
os-zhuang added this pull request to the merge queueAug 13, 2026
Merged via the queue into main with commit 6500ebbAug 13, 2026
33 checks passed
@os-zhuang
os-zhuang deleted the claude/issue-7351-adr-0094-retired-direction-copies branch August 13, 2026 04:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/sskip-changesetPR has no user-facing published change; bypasses the changeset gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@os-zhuang@claude