Uh oh!
There was an error while loading. Please reload this page.
[Doc] Enable doctest with Calcite - #4379
Merged
Merged
Conversation
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
commented
Sep 29, 2025
| | FLOOR(282474973688888.022) | FLOOR(9223372036854775807.022) | FLOOR(9223372036854775807.0000001) | | ||
| |----------------------------+--------------------------------+------------------------------------| | ||
| | 282474973688888 | 9223372036854775807 | 9223372036854775807 | | ||
| | 282474973688888.0| 9.223372036854776e+18| 9.223372036854776e+18 | |
MemberAuthor
There was a problem hiding this comment.
For the double values which are out of the double's precision. Keep the behavior same as Java's Math.floor(double) and Splunk's floor() math function.
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin
commented
Sep 29, 2025
| ] as b | ||
| | stats avg(salary) by span(age, 10) as age_span, b.country; | ||
| fetched rows / total rows = 5/5 | ||
| PPL> source = state_country as a | where country = 'USA' OR country = 'England' | left join ON a.name = b.name [ source = occupation | where salary > 0 | fields name, country, salary | sort salary | head 3 ] as b | stats avg(salary) by span(age, 10) as age_span, b.country; |
MemberAuthor
There was a problem hiding this comment.
not sure why this query failed in linux/doctest only. I cannot reproduce in local and IT. Will keep the PPL> to avoid failure.
ppl_cmd.process("source = state_country as a | where country = 'USA' OR country = 'England' | left join ON a.name = b.name [ source = occupation | where salary > 0 | fields name, country, salary | sort salary | head 3 ] as b | stats avg(salary) by span(age, 10) as age_span, b.country")Expected:
fetched rows / total rows = 3/3
+-------------+----------+-----------+
| avg(salary) | age_span | b.country |
|-------------+----------+-----------|
| null | 40 | null |
| 70000.0 | 30 | USA |
| 100000.0 | 70 | England |
+-------------+----------+-----------+
Got:
fetched rows / total rows = 2/2
+-------------+----------+-----------+
| avg(salary) | age_span | b.country |
|-------------+----------+-----------|
| 70000.0 | 30 | USA |
| 100000.0 | 70 | England |
+-------------+----------+-----------+
----------------------------------------------------------------------
LantaoJin
marked this pull request as ready for review
September 29, 2025 11:01
LantaoJin
requested review from
Swiddis, YANG-DB, dai-chen, derek-ho, joshuali925, kavithacm, mengweieric, penghuo, ps48 and vamsimanohar
as code ownersSeptember 29, 2025 11:01
LantaoJin
requested review from
GumpacG, MaxKsyunz, RyanL1997, Yury-Fridlyand, acarbonetto, anirudha, forestmvey, noCharger, qianheng-aws, seankao-az, ykmr1224 and yuancu
as code ownersSeptember 29, 2025 11:01
LantaoJin
commented
Sep 29, 2025
Comment on lines
10
to
+12
| "user/ppl/cmd/grok.rst", | ||
| "user/ppl/cmd/head.rst", | ||
| "user/ppl/cmd/parse.rst", | ||
| "user/ppl/cmd/patterns.rst", | ||
| "user/ppl/cmd/rare.rst", | ||
| "user/ppl/cmd/search.rst", | ||
| "user/ppl/cmd/sort.rst", | ||
| "user/ppl/cmd/syntax.rst", | ||
| "user/ppl/cmd/trendline.rst", | ||
| "user/ppl/cmd/top.rst", | ||
| "user/ppl/cmd/where.rst", | ||
| "user/ppl/cmd/join.rst", | ||
| "user/ppl/cmd/lookup.rst", | ||
| "user/ppl/cmd/subquery.rst", | ||
| "user/ppl/general/identifiers.rst", | ||
| "user/ppl/general/datatypes.rst", | ||
| "user/ppl/functions/datetime.rst", | ||
| "user/ppl/functions/expressions.rst", | ||
| "user/ppl/functions/ip.rst", | ||
| "user/ppl/functions/json.rst", | ||
| "user/ppl/functions/math.rst", | ||
| "user/ppl/functions/relevance.rst", | ||
| "user/ppl/functions/string.rst" | ||
| "user/ppl/cmd/patterns.rst" |
MemberAuthor
There was a problem hiding this comment.
I see the #4380 closed. but grok, parse, patterns are still not able to 100% match the result of doctest in v2. @songkant-aws can you fix it or link an issue. Or it just needs to update the doc.
LantaoJin
commented
Sep 29, 2025
| | 2024-07-01 00:00:00 | web-01 | 2 | | ||
| | 2024-07-01 00:00:00 | web-02 | 2 | | ||
| +---------------------+--------+-------+ | ||
| os> source=events | timechart span=1h count() by host |
MemberAuthor
There was a problem hiding this comment.
@selsong , when I change PPL> to os> in timechart.rst. I found many results cannot not match the expected results added in doc. timechart command is a Calcite enabled only command, which means the results in this file shouldn't be impacted by the action of setting calcite enabled as default. Please check why the original expected results cannot match the actual ones. cc @penghuo
LantaoJin
commented
Sep 29, 2025
| @@ -145,9 +141,7 @@ This example calculates the average CPU usage for each minute without grouping b | |||
| PPL query:: | |||
| PPL> source=events | timechart span=1m avg(cpu_usage) | |||
MemberAuthor
penghuo
approved these changes
Sep 29, 2025
Swiddis
approved these changes
Sep 29, 2025
Contributor
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repositorycd$(git rev-parse --show-toplevel)# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/sql/backport-2.19-dev 2.19-dev
# Navigate to the new working treepushd ../.worktrees/sql/backport-2.19-dev
# Create a new branch
git switch --create backport/backport-4379-to-2.19-dev
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9143a449f38bf08470ecc25826c474d8fd38d6c8
# Push it to GitHub
git push --set-upstream origin backport/backport-4379-to-2.19-dev
# Go back to the original working treepopd# Delete the working tree
git worktree remove ../.worktrees/sql/backport-2.19-devThen, create a pull request where the |
penghuo pushed a commit
to penghuo/os-sql
that referenced
this pull request
Oct 7, 2025
(cherry picked from commit 9143a44)
penghuo pushed a commit
to penghuo/os-sql
that referenced
this pull request
Oct 7, 2025
(cherry picked from commit 9143a44) Signed-off-by: Peng Huo <penghuo@gmail.com>
LantaoJin added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Oct 9, 2025
(cherry picked from commit 9143a44)
LantaoJin added a commit
to LantaoJin/search-plugins-sql
that referenced
this pull request
Oct 9, 2025
(cherry picked from commit 9143a44) Signed-off-by: Lantao Jin <ltjin@amazon.com>
LantaoJin added a commit
that referenced
this pull request
Oct 9, 2025
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
* main-apple: (218 commits) Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442) Create fab-radar.yml PPL `fillnull` command enhancement (opensearch-project#4421) reverting to _doc + _id (opensearch-project#4435) Support `multisearch` command in calcite (opensearch-project#4332) Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423) [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418) Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378) [Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344) Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613) Version bump: 3.3 (opensearch-project#4417) Add max/min eval functions (opensearch-project#4333) Support time modifiers in search command (opensearch-project#4224) Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402) refactor span (opensearch-project#4334) Move release notes categories (opensearch-project#3818) [Doc] Enable doctest with Calcite (opensearch-project#4379) Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407) Scale of decimal literal should always be positive in Calcite (opensearch-project#4401) Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Followup of #4372
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoffor-s.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.