[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416

Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom
aalva500-prog:feature/fixcount
Closed

[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom
aalva500-prog:feature/fixcount

Conversation

@aalva500-prog

@aalva500-progaalva500-prog commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Description

Currently, SQL/PPL Count Query Is Maxed at MAX_INT

For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:

{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:

{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • New functionality has javadoc added.
  • New functionality has a user manual doc added.
  • New PPL command checklist all confirmed.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff or -s.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

aaarone90and others added 6 commits September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit that referenced this pull request Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit to asifabashar/sql that referenced this pull request Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot pushed a commit that referenced this pull request Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit that referenced this pull request Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog deleted the feature/fixcount branch January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER - #4416
Closed
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Closed
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTEGER#4416
aalva500-prog wants to merge 6 commits into
opensearch-project:mainfrom 
aalva500-prog:feature/fixcount
Conversation
@aalva500-prog
@aalva500-progaalva500-prog
commented
Sep 30, 2025

Copy link


Copy Markdown

Contributor
Description
Currently, SQL/PPL Count Query Is Maxed at MAX_INT
For example, in the following query requestId is capped at the value of max(interger), however, the actual number of requestId could be higher:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "integer"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

This PR addresses the above issue by changing the resturn type from integer to long, so the new result will be as follows:
{
"query": ""source = accounts | stats count(requestId)""
}
{
"schema": [
{
"name": "count(requestId)",
"type": "bigint"
}
],
"datarows": [
[
2147483647
]
],
"total": 1,
"size": 1
}

Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
  •  New functionality includes testing.
  •  New functionality has been documented.
  •  New functionality has javadoc added.
  •  New functionality has a user manual doc added.
  •  New PPL command checklist all confirmed.
  •  API changes companion pull request created.
  •  Commits are signed per the DCO using --signoff or -s.
  •  Public documentation issue/PR created.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

For more information on following Developer Certificate of Origin and signing off your commits, please check here.
aaarone90and others
added 6 commits
September 16, 2025 09:50
@aaarone90
Updating coalesce documentation, as requested
a291640
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Adding os prompt to queries to run doctest
7f53efc
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aalva500-prog
Merge branch 'opensearch-project:main' into doc/update-coalesce
8887cba
@aaarone90
Adding nested IFNULL example under IFNULL section
f7ca692
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Fixing doctest
53ddd43
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
@aaarone90
Changing count function to be capped at long instead of integer
a5c6ed2
Signed-off-by: Aaron Alvarez <aaarone@amazon.com>
RyanL1997 pushed a commit
that referenced
this pull request
Oct 1, 2025
@aalva500-prog@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
d7b2c35
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
asifabashar added a commit
to asifabashar/sql
that referenced
this pull request
Oct 10, 2025
@asifabashar
Merge branch 'main-apple' into sync-mirror-update
6505a4e
* main-apple: (218 commits)
Add ignorePrometheus Flag for integTest and docTest (opensearch-project#4442)
Create fab-radar.yml
PPL `fillnull` command enhancement (opensearch-project#4421)
reverting to _doc + _id (opensearch-project#4435)
Support `multisearch` command in calcite (opensearch-project#4332)
Add 3.3 release notes (opensearch-project#4422) (opensearch-project#4423)
[SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER opensearch-project#4416 (opensearch-project#4418)
Change the default search sort tiebreaker to `_shard_doc` for PIT search (opensearch-project#4378)
[Enhancement] Add error handling for known limitation of sql `JOIN` (opensearch-project#4344)
Bugfix: SQL type mapping for legacy JDBC output (opensearch-project#3613)
Version bump: 3.3 (opensearch-project#4417)
Add max/min eval functions (opensearch-project#4333)
Support time modifiers in search command (opensearch-project#4224)
Fix numbered token bug and make it optional output in patterns command (opensearch-project#4402)
refactor span (opensearch-project#4334)
Move release notes categories (opensearch-project#3818)
[Doc] Enable doctest with Calcite (opensearch-project#4379)
Mod function should return decimal instead of float when handle the operands are decimal literal (opensearch-project#4407)
Scale of decimal literal should always be positive in Calcite (opensearch-project#4401)
Enable Calcite by default and implicit fallback the unsupported commands (opensearch-project#4372)
...
opensearch-trigger-botBot
pushed a commit
that referenced
this pull request
Oct 24, 2025
@github-actions@aaarone90
[SQL/PPL] Fix the count(*) and dc(field) to be capped at MAX_INTE…
608963b
…GER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LantaoJin added a commit
that referenced
this pull request
Oct 28, 2025
@opensearch-trigger-bot@github-actions
@aaarone90@LantaoJin
[Backport 2.19-dev] [SQL/PPL] Fix the count(*) and dc(field) to b…
757904d
…e capped at MAX_INTEGER #4416 (#4656)
* [SQL/PPL] Fix the `count(*)` and `dc(field)` to be capped at MAX_INTEGER #4416 (#4418)
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
(cherry picked from commit d7b2c35)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
* Fix IT
Signed-off-by: Lantao Jin <ltjin@amazon.com>
---------
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Lantao Jin <ltjin@amazon.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Aaron Alvarez <aaarone@amazon.com>
Co-authored-by: Lantao Jin <ltjin@amazon.com>
@aalva500-prog
aalva500-prog
deleted the

feature/fixcount

branch
January 7, 2026 22:57
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@ps48ps48Awaiting requested review from ps48ps48 will be requested when the pull request is marked ready for reviewps48 is a code owner
@joshuali925joshuali925Awaiting requested review from joshuali925joshuali925 will be requested when the pull request is marked ready for reviewjoshuali925 is a code owner
@dai-chendai-chenAwaiting requested review from dai-chendai-chen will be requested when the pull request is marked ready for reviewdai-chen is a code owner
@mengweiericmengweiericAwaiting requested review from mengweiericmengweieric will be requested when the pull request is marked ready for reviewmengweieric is a code owner
@vamsimanoharvamsimanoharAwaiting requested review from vamsimanoharvamsimanohar will be requested when the pull request is marked ready for reviewvamsimanohar is a code owner
@SwiddisSwiddisAwaiting requested review from SwiddisSwiddis will be requested when the pull request is marked ready for reviewSwiddis is a code owner
@penghuopenghuoAwaiting requested review from penghuopenghuo will be requested when the pull request is marked ready for reviewpenghuo is a code owner
@anirudhaanirudhaAwaiting requested review from anirudhaanirudha will be requested when the pull request is marked ready for reviewanirudha is a code owner
@acarbonettoacarbonettoAwaiting requested review from acarbonettoacarbonetto will be requested when the pull request is marked ready for reviewacarbonetto is a code owner
@ykmr1224ykmr1224Awaiting requested review from ykmr1224ykmr1224 will be requested when the pull request is marked ready for reviewykmr1224 is a code owner
@LantaoJinLantaoJinAwaiting requested review from LantaoJinLantaoJin will be requested when the pull request is marked ready for reviewLantaoJin is a code owner
@noChargernoChargerAwaiting requested review from noChargernoCharger will be requested when the pull request is marked ready for reviewnoCharger is a code owner
@qianheng-awsqianheng-awsAwaiting requested review from qianheng-awsqianheng-aws will be requested when the pull request is marked ready for reviewqianheng-aws is a code owner
@yuancuyuancuAwaiting requested review from yuancuyuancu will be requested when the pull request is marked ready for reviewyuancu is a code owner
@RyanL1997RyanL1997Awaiting requested review from RyanL1997RyanL1997 will be requested when the pull request is marked ready for reviewRyanL1997 is a code owner
@ahkcsahkcsAwaiting requested review from ahkcsahkcs will be requested when the pull request is marked ready for reviewahkcs is a code owner
@songkant-awssongkant-awsAwaiting requested review from songkant-awssongkant-aws will be requested when the pull request is marked ready for reviewsongkant-aws is a code owner

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@aalva500-prog@aaarone90