Migrate workbench to OpenSearch Dashboards by davidcui1225 · Pull Request #6 · opensearch-project/sql

davidcui1225 · 2021-04-13T23:26:07Z

Issue #, if available:
N/A
Description of changes:

Migrate workbench to OpenSearch Dashboards
bump version to 1.15

TODO: Update GitHub workflows, get feedback on changes needed in tslint.yaml with Elasticsearch BV license statement.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

dblock · 2021-04-14T00:05:28Z

 repository: elastic/kibana
 ref: v7.10.2
- path: sql/kibana
+ path: sql/OpenSearch-Dashboards


I think paths should remain lowercase. + below many

Even though the OpenSearch-Dashboards repo has the upper case?

You're right. In hindsight maybe we should have made repo names lowercase, but YOLO.

dblock · 2021-04-14T00:10:19Z

 },
 },
- async (context, request, response): Promise<IKibanaResponse<any | ResponseError>> => {
+ async (context, request, response): Promise<IOpenSearchDashboardsResponse<any | ResponseError>> => {


I think this becomes IDashboardsResponse, if it's in this repo.

I think it's IOpenSearchDashboardsResponse based on
/** * A response data object, expected to returned as a result of {@link RequestHandler} execution * @public */ export interface IOpenSearchDashboardsResponse< T extends HttpResponsePayload | ResponseError = any > { readonly status: number; readonly payload?: T; readonly options: HttpResponseOptions; }
From the OpenSearch-Dashboards source code

dblock · 2021-04-14T00:11:05Z

 export const DEFAULT_HEADERS = {
 'Content-Type': 'application/json',
 Accept: 'application/json',
- 'User-Agent': 'Kibana',


I don't know the context for this, but if we were returning a certain UA header we probably want to continue returning one.

Should I just change it to 'User-Agent': 'OpenSearch Dashboards' then?

AFAIK spaces in the user agent strings are considered separators according to the HTTP spec, so this would need to be OpenSearch-Dashboards.

…s-AOS-202-CAST Dialect: Added CAST to convert to int and string as of AOS-202

…pensearch-project#1181) * Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix doctest after rebase. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix doctest after rebase. - Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update syntax section. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Creation and updating 2.x branch (opensearch-project#6) * Create the 2.x branch * Add workflow_dispatch: to github CLI Signed-off-by: YANGDB <yang.db.dev@gmail.com>

* remove sub-folders which upgraded as new repositories - sql-cli - sql-odbc - sql-jdbc - dashboards-query-workbench - add additional workflow run triggers - move the BI tests to jdbc/odbc - move the sql-cli outside and clone for the doctest build Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Merge remote-tracking branch 'upstream/main' Signed-off-by: YANGDB <yang.db.dev@gmail.com> * add sql-jdbc dependendcy to gradle Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Disallow unquoted literals in `LIKE` clause in `DESCRIBE` statement (#1181) * Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix doctest after rebase. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix doctest after rebase. - Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update syntax section. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Creation and updating 2.x branch (#6) * Create the 2.x branch * Add workflow_dispatch: to github CLI Signed-off-by: YANGDB <yang.db.dev@gmail.com> * remove sub-folders which upgraded as new repositories - sql-cli - sql-odbc - sql-jdbc - dashboards-query-workbench Signed-off-by: YANG-DB <yang-db-dev@gmail.com> * add additional workflow run triggers Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Merge remote-tracking branch 'upstream/main' - move the BI tests to jdbc/odbc - move the sql-cli outside and clone for the doctest build Signed-off-by: YANGDB <yang.db.dev@gmail.com> * Disallow unquoted literals in `LIKE` clause in `DESCRIBE` statement (#1181) (#3) * Allow quoted literals only in `DESCRIBE` and `SHOW` clauses. Tests. Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> * Fix doctest after rebase. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Fix doctest after rebase. - Typo fix. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> * Update syntax section. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com> Signed-off-by: YANG-DB <yang-db-dev@gmail.com> Signed-off-by: YANGDB <yang.db.dev@gmail.com> Signed-off-by: Yury-Fridlyand <yuryf@bitquilltech.com> Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> Co-authored-by: lior perry <lioperry@amazon.com> Co-authored-by: yang-db <yang-db-dev@gmail.com> Co-authored-by: Yury-Fridlyand <yury.fridlyand@improving.com>

) * # This is a combination of 9 commits. # This is the 1st commit message: Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #2: Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #3: Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #4: Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #5: running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #6: Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #7: improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #8: Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #9: spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * parent 496fe8e author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700 committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700 Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing unused import in OpenSearchRestClientTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * running spotless apply. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressed comments in PR 5. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>

* Spotless apply for datasources. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * ignore checkstyle for datasources Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>

…-plan Ensuring all sub aggs are pushed down and remove reliance on doc_count

…dar162010361-pkl-pipelines (rdar://162010361) Migrate from Rio YAML config to PKL-based pipelines configuration

…ories Merge overlapping items: - opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法 - opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件 - opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计 - opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6 - opensearch-project#9 (data scale) → 数据覆盖 - opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4 Items already detailed in new §5.6 subsections are replaced with brief summaries + cross-references, eliminating ~15 lines of repetition. Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>

Fixes based on code verification and logical analysis (no retesting): 1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation) to G0-1 (1.05ms, point query) — D3 is a point query, should reference the semantically matching baseline. Difference updated to ~8.26ms. 2. §5.6.1: Removed circular reasoning in 'cross-validation' wording. The 1.17ms delta is derived by subtracting _explain from e2e, not independently measured — cannot serve as independent verification. Renamed to '差值分解（非交叉验证）'. 3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M. They are different queries (different WHERE/GROUP BY/measure); similar overhead ratios (87.6% vs 85.2%) could be coincidental. Only controlled-variable data (C1-H 1M→10M) is valid evidence. 4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5. D1-H 28%→40% (↑12pp) was omitted despite being more significant than C1-H ↑2pp. Added to both the hypothesis table and core conclusion. 5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection serial, 4GB heap, loopback network' conditions, plus note that H1's 140× degradation may differ under production 8GB heap. 6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's overhead is serialization-dominated (result-set-dependent variable cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost. 7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote — explicitly states 'not参与结论推导', only H1/G3 cold-query data participates in conclusions. 8. §5.1: Changed plugins.calcite.enabled description from '持久化设置' to '代码默认值, OpenSearchSettings.java:157' — code verification confirmed default is true, not a custom persistent setting. Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>

davidcui1225 · 2021-04-13T23:26:07Z