OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

OpenSearch migration for ODBC driver - #5

Closed
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2
Closed

OpenSearch migration for ODBC driver#5
dai-chen wants to merge 2 commits into
developfrom
opensearch/odbc-2

Conversation

@dai-chen

Copy link
Copy Markdown
Collaborator

Issue #, if available:

Description of changes: Testing in progress. TODO: rename all ES.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chendai-chen self-assigned this Apr 13, 2021
@dai-chendai-chen changed the title OpenSearch migration for ODBCOpenSearch migration for ODBC driverApr 13, 2021
joshuali925 pushed a commit to joshuali925/sql that referenced this pull request Jan 4, 2022
…D-return-type-AOS-202
Dialect: fix return type for MID function as part of AOS-202
GumpacG pushed a commit that referenced this pull request Aug 9, 2023
)
* # This is a combination of 9 commits.
# This is the 1st commit message:
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #2:
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #3:
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #4:
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #5:
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #6:
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #7:
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #8:
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
# This is the commit message #9:
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* parent 496fe8e
author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700
committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700
Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899)
* Added setDefaultMediaType for create_index and create_index_with_IOException
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
(cherry picked from commit 7b932a7)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs 2
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
cherry pick 60c0018
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Addressed PR comment for table format in AbstractExprValue.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from ExpressionReferenceOptimizer.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from AstDSL.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removed pre tag from SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
fixed java doc in QualifiedName.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing checkstyle test for core and added spotless for relevant directories.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fix breaking changes. Disable some flaky tests in legacy.
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
(cherry picked from commit 809e656)
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Fixed java doc spelling and improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
improving string concatination.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Improving failure format on some functions.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
spotless apply and fix of build.gradle
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Resolving merge conflicts for pre tag in java docs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
running spotless check on newly pre tagged javadocs.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Converts java doc table to proper java doc table.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Removing unused import in OpenSearchRestClientTest.java
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* running spotless apply.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Addressed comments in PR 5.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 10, 2023
* Integ/sl google java format5 (#332)
Adding core final GJF fix.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* remove repeated unused checkstyle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* replaced nbsp with pre tag.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* Add test fixtures to failure ignore in core build.gradle.
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit that referenced this pull request Aug 22, 2023
) (#1996)
* spotlesss apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed target for spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* fixed comments of spotless
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
* spotless apply
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
---------
Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
songkant-aws pushed a commit to songkant-aws/sql that referenced this pull request Mar 19, 2025
alchemist51 pushed a commit to alchemist51/sql that referenced this pull request Nov 7, 2025
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 21, 2026
…ories
Merge overlapping items:
- opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法
- opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件
- opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计
- opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6
- opensearch-project#9 (data scale) → 数据覆盖
- opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4
Items already detailed in new §5.6 subsections are replaced with
brief summaries + cross-references, eliminating ~15 lines of repetition.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit to TomZhang2/sql that referenced this pull request Jul 22, 2026
Fixes based on code verification and logical analysis (no retesting):
1. §5.6.1: D3 _explain estimate changed from G0-2 (0.82ms, aggregation)
to G0-1 (1.05ms, point query) — D3 is a point query, should reference
the semantically matching baseline. Difference updated to ~8.26ms.
2. §5.6.1: Removed circular reasoning in 'cross-validation' wording.
The 1.17ms delta is derived by subtracting _explain from e2e, not
independently measured — cannot serve as independent verification.
Renamed to '差值分解(非交叉验证)'.
3. §5.6.4: Removed 'corroboration' claim between G3 and C1-H 10M.
They are different queries (different WHERE/GROUP BY/measure);
similar overhead ratios (87.6% vs 85.2%) could be coincidental.
Only controlled-variable data (C1-H 1M→10M) is valid evidence.
4. §5.6.5: Added missing D1-H deep pagination scenario to conclusion opensearch-project#5.
D1-H 28%→40% (↑12pp) was omitted despite being more significant than
C1-H ↑2pp. Added to both the hypothesis table and core conclusion.
5. §5.6.5: Added scope qualifiers to conclusion opensearch-project#6 — 'single-connection
serial, 4GB heap, loopback network' conditions, plus note that H1's
140× degradation may differ under production 8GB heap.
6. §5.6.2: Corrected 'fixed overhead' mislabel for D3's 9.31ms. D3's
overhead is serialization-dominated (result-set-dependent variable
cost), not fixed; C1/C3's 2.47/2.10ms is the actual near-fixed cost.
7. §5.6.5: Marked G1/H2 cache-hit data in summary table with † footnote
— explicitly states 'not参与结论推导', only H1/G3 cold-query data
participates in conclusions.
8. §5.1: Changed plugins.calcite.enabled description from '持久化设置'
to '代码默认值, OpenSearchSettings.java:157' — code verification
confirmed default is true, not a custom persistent setting.
Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@dai-chen