Uh oh!
There was an error while loading. Please reload this page.
OpenSearch migration for SQL/PPL - #1
Merged
Merged
Conversation
dai-chen
marked this pull request as ready for review
April 7, 2021 22:15
dblock
reviewed
Apr 8, 2021
dblock
left a comment
Member
There was a problem hiding this comment.
See below, sorry to be late to this game.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
6 tasks
joshuali925 referenced
this pull request
in joshuali925/sql
Jan 4, 2022
Added Tableau Connector to OpenSearch SQL
6 tasks
6 tasks
6 tasks
GumpacG pushed a commit
that referenced
this pull request
Aug 9, 2023
) * # This is a combination of 9 commits. # This is the 1st commit message: Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #2: Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #3: Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #4: Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #5: running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #6: Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #7: improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #8: Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> # This is the commit message #9: spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * parent 496fe8e author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700 committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700 Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing unused import in OpenSearchRestClientTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * running spotless apply. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressed comments in PR 5. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com>
Yury-Fridlyand pushed a commit
that referenced
this pull request
Aug 9, 2023
) * GJF part 4 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add build.gradle comment to mention why we are ignoring checkstyle failures for core. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fix include spotless build gradle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert astDSL.JAVA Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert ast changes as was covered in spotless #1 PR for GJF. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Reverting commits in ast folder attempt #2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert change to RaretopN.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Replacing removed include in spotless. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
acarbonetto pushed a commit
that referenced
this pull request
Aug 22, 2023
…in files #4#1933 (#1995) * [Spotless] Applying Google Code Format for core/src/main files #4 (#1933) * GJF part 4 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add build.gradle comment to mention why we are ignoring checkstyle failures for core. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Fix include spotless build gradle. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert astDSL.JAVA Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert ast changes as was covered in spotless #1 PR for GJF. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Reverting commits in ast folder attempt #2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * revert change to RaretopN.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Replacing removed include in spotless. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * addressed PR comments Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * remove pitest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
Yury-Fridlyand pushed a commit
that referenced
this pull request
Aug 22, 2023
…in files #1#1930 (#1992) * [Spotless] Applying Google Code Format for core/src/main files #1 (#1930) * # This is a combination of 9 commits. Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * parent 496fe8e author Mitchell Gale <Mitchell.Gale@improving.com> 1691080710 -0700 committer Mitchell Gale <Mitchell.Gale@improving.com> 1691080766 -0700 Fix create_index/create_index_with_IOException issue caused by OpenSearch PR change (#1899) * Added setDefaultMediaType for create_index and create_index_with_IOException Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> (cherry picked from commit 7b932a7) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs 2 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> cherry pick 60c0018 Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Addressed PR comment for table format in AbstractExprValue. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from ExpressionReferenceOptimizer. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from AstDSL.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removed pre tag from SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> fixed java doc in QualifiedName.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing checkstyle test for core and added spotless for relevant directories. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixing spacing around headers in ExpressionReferenceOptimizer.java SelectExpressionAnalyzer.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fix breaking changes. Disable some flaky tests in legacy. Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com> (cherry picked from commit 809e656) Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Fixed java doc spelling and improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> improving string concatination. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Improving failure format on some functions. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> spotless apply and fix of build.gradle Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Resolving merge conflicts for pre tag in java docs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> running spotless check on newly pre tagged javadocs. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Converts java doc table to proper java doc table. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Removing unused import in OpenSearchRestClientTest.java Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * running spotless apply. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * Addressed comments in PR 5. Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * spotless apply Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * removed pitest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * remove pitest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * add spotless Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> * remove pitest Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> --------- Signed-off-by: Mitchell Gale <Mitchell.Gale@improving.com> Signed-off-by: Mitchell Gale <Mitchell.gale@improving.com>
songkant-aws referenced
this pull request
in songkant-aws/sql
Mar 19, 2025
Map opensearch math functions to calcite implementations
expani pushed a commit
to expani/sql
that referenced
this pull request
Oct 13, 2025
…-plan Added support for average metric aggregation
8 tasks
4 tasks
TomZhang2 added a commit
to TomZhang2/sql
that referenced
this pull request
Jul 21, 2026
…ories Merge overlapping items: - opensearch-project#1+opensearch-project#10 (sample size/p99/p999) → 统计方法 - opensearch-project#2+opensearch-project#3+opensearch-project#8+opensearch-project#16 (network/heap/JDK/H1 pressure) → 环境与硬件 - opensearch-project#4+opensearch-project#5+opensearch-project#6+opensearch-project#12+opensearch-project#15 (concurrency/cache/forcemerge 1M+10M) → 测试设计 - opensearch-project#7+opensearch-project#13+opensearch-project#14 (G0 cross-engine/C1-H→G3/E-group) → 测量方法, cross-ref §5.6 - opensearch-project#9 (data scale) → 数据覆盖 - opensearch-project#11 (H1 timeout) → 生产风险, cross-ref §5.6.4 Items already detailed in new §5.6 subsections are replaced with brief summaries + cross-references, eliminating ~15 lines of repetition. Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
TomZhang2 added a commit
to TomZhang2/sql
that referenced
this pull request
Jul 22, 2026
§2.3 and §1.4 incorrectly stated V1/V2 have 'no memory compute'. Actually all 3 engines use multiple DSL requests + in-memory merge for DSL-unsupported capabilities: - Legacy V1: BlockHashJoin (verified via _explain: 2 PIT queries + hash join on coordinator) - V2: TakeOrderedOperator (window functions, agg sorting) - Calcite: Enumerable operators (Janino codegen) Updated: - §1.4 table: V1 memory compute '无' → '有（BlockHashJoin 等 V1 算子）' V2 '无' → '有（TakeOrderedOperator 等 V2 算子）' - §2.3 table: V1 DSL生成 column updated from 'QueryAction→SearchRequestBuilder' to '多次 DSL 请求 + 内存合并（如 BlockHashJoin）' - §2.3 key difference opensearch-project#1: rewritten to explain the unified pattern (multiple DSL + memory merge) across all 3 engines Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai> Signed-off-by: taozhang314 <42579706+TomZhang2@users.noreply.github.com>
8 tasks
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: If nothing else miss, the only leftover is the ES doc links in source code comments and documentation.
1.Changing to OpenSearch Dependencies
2.Renaming to OpenSearch
3.Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.