Uh oh!
There was an error while loading. Please reload this page.
🐛 Revert "Move the e2e into the operator-controler-system ns" - #930
Merged
Conversation
…framework#927)" This ends up overwriting the security policy of the operator-controller-system namespace, which really isn't something we want to do in a valid e2e test. Many of the e2e components need to run as root in order to do the things they need to do. This reverts commit aa48e70.
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #930 +/- ##
=======================================
Coverage 79.15% 79.15% =======================================
Files 15 15 Lines 1084 1084 =======================================
Hits 858 858 Misses 157 157 Partials 69 69
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tmshort
commented
Jun 13, 2024
ContributorAuthor
Revert of #927 |
joelanford
approved these changes
Jun 13, 2024
joelanford
added this pull request to the merge queue
Jun 13, 2024
grokspawn
approved these changes
Jun 13, 2024
This was referenced Jul 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ends up overwriting the security policy of the operator-controller-system namespace, which really isn't something we want to do in a valid e2e test.
Many of the e2e components need to run as root in order to do the things they need to do.
This reverts commit aa48e70.
Description
Reviewer Checklist