Uh oh!
There was an error while loading. Please reload this page.
🌱 mac setup steps - #938
Conversation
Signed-off-by: Jordan Keister <jordan@nimblewidget.com>
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #938 +/- ##
==========================================
- Coverage 79.34% 79.16% -0.19%
==========================================
Files 16 16 Lines 1104 1104 ==========================================
- Hits 876 874 -2 - Misses 158 159 +1 - Partials 70 71 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| Modify your login shell's `PATH` to prefer the new tools over those in the existing environment. This example should work either with `zsh` (in $HOME/.zshrc) or `bash` (in $HOME/.bashrc): | ||
| ```sh | ||
| for bindir in `find $(brew --prefix)/opt -type d -follow -name gnubin -print` |
There was a problem hiding this comment.
I normally try to avoid running commands in .zshrc because it can slow down creation of a new session significantly. Maybe it is not that big of a deal with brew --prefix and find, but I had this issue with npm.
If we can avoid this - that would be great. Here is my .zshrc:
# coreutils
PATH="/opt/homebrew/opt/coreutils/libexec/gnubin:$PATH"# gnu-tar
PATH="/opt/homebrew/opt/gnu-tar/libexec/gnubin:$PATH"Not sure if coreutils are necessary for OLMv1.
There was a problem hiding this comment.
But we might still need to use brew --prefix. I think it it is different on Intel and ARM Macs unfortunately.
There was a problem hiding this comment.
I've been doing this for quite awhile never encountered new session timing issues, though I appreciate the concern. The additional advantage of the approach is that if we identify we need additional tooling, sourcing the resource file will automagically pick it up.
npm is known for sometimes performing package maintenance at awkward times, and I definitely wouldn't want to include a function in shell resources which invoked it. I see no harm in a targeted path-walk though.
As far as I know we only need bash, gnu-tar, and gsed, unless you can think of a reason that we need coreutils...
There was a problem hiding this comment.
find $(brew --prefix)/opt -type d -follow -name gnubin -print 0,01s user 0,10s system 96% cpu 0,112 total
Ok, it is not that bad. At least on my machine :)
Description
Reviewer Checklist