Skip to content

Add Windows GitHub actions build - #10664

Closed
iluuu1994 wants to merge 1 commit into
php:PHP-8.1from
iluuu1994:github-actions-windows
Closed

Add Windows GitHub actions build#10664
iluuu1994 wants to merge 1 commit into
php:PHP-8.1from
iluuu1994:github-actions-windows

Conversation

@iluuu1994

Copy link
Copy Markdown
Member

#8392 with minimal changes.

Comment threadrun-tests.php Outdated

@mvorisekmvorisekFeb 22, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @iluuu1994 for taking #8392 over.

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this/run-tests.php change is some rebase leftover

This is intentional, otherwise the -g flag doesn't behave properly (diff gets printed even if excluded). It's backported from master.

do not forget to add nightly job one this PR is working

It's removed intentionally for now until this has proven to work fine, I'll re-add it after.

@Girgias

Copy link
Copy Markdown
Member

There seems to be an issue with test bug72858.phpt not properly detecting that it's not running on 32bits.

@iluuu1994
iluuu1994force-pushed the github-actions-windows branch 2 times, most recently from b624e14 to 67ea7f9CompareFebruary 22, 2023 22:37
@iluuu1994

Copy link
Copy Markdown
MemberAuthor

Turns out choco is actually faster so I'll just keep it this way.

@iluuu1994
iluuu1994force-pushed the github-actions-windows branch 15 times, most recently from c59ae3b to 1d7c35aCompareMarch 1, 2023 17:42
@iluuu1994

Copy link
Copy Markdown
MemberAuthor

Unfortunately, it looks like sometimes the build stalls in the build phase (phpsdk_deps). I'm not sure why that is.

https://github.com/php/php-src/actions/runs/4352459361/jobs/7605272205

@mvorisek

mvorisek commented Mar 7, 2023

Copy link
Copy Markdown
Contributor
Terminate batch job (Y/N)? ^C^C

at the end is caused by Github Actions tryiing to terminate the job step after timeout, so the problem is before

to debug this, you may want to fork https://github.com/php/php-sdk-binary-tools/blob/master/bin/phpsdk_deps.php (cloned here https://github.com/php/php-src/blob/916b132ea0/.github/scripts/windows/build.bat#L23) and log more data

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@iluuu1994@Girgias@mvorisek