Skip to content

Fix mysql tests with non-standard server port - #9744

Closed
mvorisek wants to merge 1 commit into
php:PHP-8.1from
mvorisek:del_bug72858_test
Closed

Fix mysql tests with non-standard server port#9744
mvorisek wants to merge 1 commit into
php:PHP-8.1from
mvorisek:del_bug72858_test

Conversation

@mvorisek

@mvorisekmvorisek commented Oct 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@cmb69

cmb69 commented Oct 14, 2022

Copy link
Copy Markdown
Member

The test passes locally for me (PHP-8.0 and PHP-8.1; on PHP-8.2 and master it fails for different reasons, likely due to #8648; I'm going to check that).

Anyway, the actual value of $v2 does not really matter; the bug fix (and the regression test) are only there to check that a failing MapViewOfFileEx() is properly caught. So could you please try with $v2 = PHP_INT_MAX instead of the assignment we have now?

@cmb69

cmb69 commented Oct 14, 2022

Copy link
Copy Markdown
Member

on PHP-8.2 and master it fails for different reasons, likely due to #8648; I'm going to check that

See #9748.

@mvorisekmvorisek changed the title Delete always failing sysvshm bug72858.phpt testFix always failing sysvshm bug72858.phpt testOct 14, 2022
@mvorisek

mvorisek commented Oct 14, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Anyway, the actual value of $v2 does not really matter; the bug fix (and the regression test) are only there to check that a failing MapViewOfFileEx() is properly caught. So could you please try with $v2 = PHP_INT_MAX instead of the assignment we have now?

it matters :), tested in https://github.com/php/php-src/actions/runs/3249858369/jobs/5332750729#step:8:4628, test is no longer failing, PR title updated

@mvorisekmvorisek changed the title Fix always failing sysvshm bug72858.phpt testMake tests compatible with Windows x86 buildsOct 14, 2022
@mvorisekmvorisek mentioned this pull request Oct 14, 2022
Closed
cmb69
cmb69 reviewed Oct 14, 2022
View reviewed changes
Comment threadext/mysqli/tests/bug73462.phpt Outdated
cmb69
cmb69 reviewed Oct 14, 2022
View reviewed changes
Comment threadext/mysqli/tests/bug73949.phpt Outdated
cmb69
cmb69 reviewed Oct 14, 2022
View reviewed changes
Comment threadext/phar/tests/bug69958.phpt Outdated
@mvorisek
mvorisek marked this pull request as draft October 14, 2022 18:30
@mvorisek
mvorisek marked this pull request as ready for review October 14, 2022 18:45
@mvorisek
mvorisek changed the base branch from PHP-8.0 to PHP-8.1November 12, 2022 14:07
@mvorisek
mvorisek requested a review from cmb69November 13, 2022 12:02
@mvorisek
mvorisek marked this pull request as draft November 15, 2022 12:34
@mvorisekmvorisek mentioned this pull request Feb 22, 2023
Closed
@mvorisekmvorisek changed the title Make tests compatible with Windows x86 buildsFix mysql tests with non-standard server portApr 19, 2023
@mvorisek
mvorisek marked this pull request as ready for review April 19, 2023 11:05
@mvorisek

mvorisek commented Apr 19, 2023

Copy link
Copy Markdown
ContributorAuthor

This PR is complete, other changes to fix tests for Windows CI has been already integrated.

@iluuu1994

iluuu1994 commented Apr 20, 2023

Copy link
Copy Markdown
Member

Looks fine, thanks!

@mvorisek
mvorisek deleted the del_bug72858_test branch April 20, 2023 11:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmb69cmb69Awaiting requested review from cmb69

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mvorisek@cmb69@iluuu1994