Skip to content

Test Windows x86 and x64 with Github Actions - #8392

Closed
mvorisek wants to merge 16 commits into
php:PHP-8.1from
mvorisek:win_ci.cipush
Closed

Test Windows x86 and x64 with Github Actions#8392
mvorisek wants to merge 16 commits into
php:PHP-8.1from
mvorisek:win_ci.cipush

Conversation

@mvorisek

@mvorisekmvorisek commented Apr 17, 2022

Copy link
Copy Markdown
Contributor

Move Windows testing to unified place - GitHub Actions

needs #9721 and #9744

AppVeyour (orig):
image

Github Actions (moved):
image

@mvorisek
mvorisekforce-pushed the win_ci.cipush branch 2 times, most recently from b465468 to 69f7c7bCompareApril 17, 2022 19:43

@cmb69cmb69 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving Windows CI to GH actions is very welcome. Thank you! @flavioheleno and @iluuu1994 already worked on that; not sure what's the status of that.

Anyhow, I suggest to keep AppVeyor CI for a while, so we can verify that the move is complete.

Comment threadappveyor/test_task.bat Outdated
@iluuu1994

Copy link
Copy Markdown
Member

I started but didn't get very far. iluuu1994#10 I'm happy for anybody else to take over.

@flavioheleno

Copy link
Copy Markdown
Contributor

I haven't gone too far either. Changes are here: flavioheleno@0ee6bc5 :-)

@mvorisek
mvorisek changed the base branch from master to PHP-8.0April 18, 2022 13:41
@mvorisek
mvorisekforce-pushed the win_ci.cipush branch 6 times, most recently from 49336d0 to 4da833fCompareApril 18, 2022 15:30
@mvorisek

Copy link
Copy Markdown
ContributorAuthor

🚀 🚀 tests run!

guys, can you take care of the failing tests?

also, x86 cannot compile :(

@cmb69

Copy link
Copy Markdown
Member

guys, can you take care of the failing tests?

On a very quick glance, this looks like a line ending issue. It might be necessary to checkout with LF.

also, x86 cannot compile :(

The CI runs with CFLAGS=/W1 /WX. So far, this is only supported for x64. I suggest to just run with CFLAGS=/W1 instead for now.

@mvorisek
mvorisekforce-pushed the win_ci.cipush branch 5 times, most recently from 47c8c69 to 874ba42CompareApril 18, 2022 16:48
@mvorisek
mvorisek marked this pull request as ready for review April 18, 2022 16:56
@mvorisek
mvorisekforce-pushed the win_ci.cipush branch 3 times, most recently from ab66b78 to 49c9870CompareApril 18, 2022 19:59
@mvorisek

Copy link
Copy Markdown
ContributorAuthor

what is wrong with 59e357a? previous commit has no issue, but if the if is removed, build fails with command syntax error

@iluuu1994

iluuu1994 commented Apr 18, 2022

Copy link
Copy Markdown
Member

The condition isn't the same, maybe that's it?

Ah sorry, you actually removed the outer if. Are you sure the first if was even executed before? Anyway, sorry I can't really help here, I'm not very familiar with the Windows build process.

@mvorisek
mvorisekforce-pushed the win_ci.cipush branch 4 times, most recently from ae467dd to e5e678aCompareApril 19, 2022 13:08
@mvorisek

Copy link
Copy Markdown
ContributorAuthor

@cmb69 can you please help me with the one failing Windows test?

Comment thread.github/workflows/push.yml Outdated

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUST BE REVERTED BEFORE MERGE

@mvorisek

Copy link
Copy Markdown
ContributorAuthor

Hello, PR is passing CI, please let me know if there is anything to address

@github-actions

Copy link
Copy Markdown

There has not been any recent activity in this PR. It will automatically be closed in 7 days if no further action is taken.

@iluuu1994

Copy link
Copy Markdown
Member

@mvorisek Thank you for this PR! I opened #10664 with a minimal set of changes.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@mvorisek@iluuu1994@flavioheleno@cmb69@Girgias@ramsey