Skip to content

Remove events - #550

Merged
alexcjohnson merged 12 commits into
masterfrom
no-events
Jan 25, 2019
Merged

Remove events#550
alexcjohnson merged 12 commits into
masterfrom
no-events

Conversation

@alexcjohnson

@alexcjohnsonalexcjohnson commented Jan 20, 2019•
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes#531

Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.

In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.

The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc

Marc-Andre-Rivet
Marc-Andre-Rivet reviewed Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
python -m unittest tests.test_integration
python -m unittest tests.test_resources
python -m unittest tests.test_configs
./test.sh

@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Marc-Andre-Rivet
Marc-Andre-Rivet reviewed Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
if not p.endswith("-*") and
p not in python_keywords and
p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
p != 'setProps'] + ['**kwargs']

@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation

@rpkylerpkyleJan 21, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.

Marc-Andre-Rivet
Marc-Andre-Rivet reviewed Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False

@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now

@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed

good call -> ec9aaee

@Marc-Andre-Rivet

Marc-Andre-Rivet commented Jan 21, 2019

Copy link
Copy Markdown
Contributor

This looks good to me

  • changelog entry missing
  • obviously need to point to master of dash-renderer after this

Would appreciate @T4rk1n or @rmarren1 input.

@alexcjohnson

alexcjohnson commented Jan 23, 2019

Copy link
Copy Markdown
CollaboratorAuthor

obviously need to point to master of dash-renderer after this

That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.

@alexcjohnsonalexcjohnson mentioned this pull request Jan 24, 2019
Merged
T4rk1n
T4rk1n reviewed Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py Outdated

return events
if 'dashEvents' in props or 'fireEvents' in props:
raise AttributeError('Events are no longer supported by dash')

@T4rk1nT4rk1nJan 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.

@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?

@T4rk1nT4rk1nJan 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.

@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.

T4rk1n
T4rk1n reviewed Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n reviewed Jan 24, 2019
View reviewed changes
Comment threadtest.sh
echo "All tests passed!"
fi

exit $EXIT_STATE

@T4rk1nT4rk1nJan 24, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?

@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.

@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8

Marc-Andre-Rivet
Marc-Andre-Rivet approved these changes Jan 25, 2019
View reviewed changes

@Marc-Andre-RivetMarc-Andre-Rivet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃
Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.

@alexcjohnson
alexcjohnson merged commit 3d2acc5 into masterJan 25, 2019
@alexcjohnson
alexcjohnson deleted the no-events branch January 25, 2019 15:48
@tcbegleytcbegley mentioned this pull request Jan 26, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments
+2 more reviewers
@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
Remove events by alexcjohnson · Pull Request #550 · plotly/dash · GitHub
Skip to content
Remove events - #550
Merged
alexcjohnson merged 12 commits into
masterfrom 
no-events
Jan 25, 2019
Merged
Remove events#550
alexcjohnson merged 12 commits into
masterfrom 
no-events
Conversation
@alexcjohnson
@alexcjohnsonalexcjohnson
commented
Jan 20, 2019•

edited

Loading

Copy link


Copy Markdown

Collaborator
Closes#531
Dash complement to plotly/dash-renderer#114 - note that the no-events branch of dash-renderer is needed to get tests to pass here, but not vice versa.
In the other repos I've been making a single npm command to run all the tests, and using that command in ci. Here we don't use npm, so I made a shell script test.sh for the same purpose.
The component generation routines, as modified here, are what I used to rebuild the html components in the already-merged plotly/dash-html-components#89, and in a forthcoming PR in dcc
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment thread.circleci/config.yml
 python -m unittest tests.test_integration
 python -m unittest tests.test_resources
 python -m unittest tests.test_configs
 ./test.sh
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
 if not p.endswith("-*") and
 p not in python_keywords and
 p not in ['dashEvents', 'fireEvent', 'setProps']] + ['**kwargs']
 p != 'setProps'] + ['**kwargs']
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if that was intentional but still present for the R generation
@rpkylerpkyleJan 21, 2019•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have modified my code to match.
Marc-Andre-Rivet
Marc-Andre-Rivet
reviewed
Jan 21, 2019
View reviewed changes
Comment threadtests/development/test_base_component.py
 self.ComponentClass().available_events,
['restyle', 'relayout', 'click']
hasattr(self.ComponentClass(), 'available_events'),
False
@Marc-Andre-RivetMarc-Andre-RivetJan 21, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed to make clearer what it's testing now
@alexcjohnsonalexcjohnsonJan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe this test should be renamed
good call -> ec9aaee
@Marc-Andre-Rivet
Marc-Andre-Rivet
commented
Jan 21, 2019

Copy link


Copy Markdown

Contributor
This looks good to me
  • changelog entry missing
  • obviously need to point to master of dash-renderer after this
Would appreciate @T4rk1n or @rmarren1 input.
@alexcjohnson
alexcjohnson
commented
Jan 23, 2019

Copy link


Copy Markdown

CollaboratorAuthor
obviously need to point to master of dash-renderer after this
That's been merged - at this point I believe we can simply make a release of dash-renderer off master, and it will stop processing events even if used with older versions of everything else that still supports them; then we can make new releases of everything else (the only PR I haven't made yet is dcc, coming soon...) acknowledging and locking in the lack of event support. I believe the only incompatible combination will be new dash with old dash-renderer.
@alexcjohnsonalexcjohnson
mentioned this pull request
Jan 24, 2019
 Merged

T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threaddash/development/_py_components_generation.py
Outdated


 return events
 if 'dashEvents' in props or 'fireEvents' in props:
 raise AttributeError('Events are no longer supported by dash')
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a custom exception or raise a DeprecationWarning instead.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it wasn't deprecated, it was outright removed 😅 but I'm happy to make a custom exception - ObsoleteEventsError?
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think exceptions.NonExistantPropException with a event removal message would fit the bill.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used NonExistentEventException, which is the same I use for corresponding obsolete callback usage.
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
T4rk1n
T4rk1n
reviewed
Jan 24, 2019
View reviewed changes
Comment threadtest.sh
 echo "All tests passed!"
fi

exit $EXIT_STATE
@T4rk1nT4rk1nJan 24, 2019

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the linting also ?
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I'll move linting in here too.
@alexcjohnsonalexcjohnsonJan 24, 2019

Copy link


Copy Markdown

CollaboratorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

linting into test.sh -> 2c9a3c8
Marc-Andre-Rivet
Marc-Andre-Rivet
approved these changes
Jan 25, 2019
View reviewed changes
@Marc-Andre-RivetMarc-Andre-Rivet
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No python expert but this looks fine to me. 💃

Will take this out on a dash-docs run with the other dash repos before releasing, for sanity.
@alexcjohnson
alexcjohnson
merged commit 3d2acc5
into
masterJan 25, 2019
@alexcjohnson
alexcjohnson
deleted the

no-events

branch
January 25, 2019 15:48
@tcbegleytcbegley
mentioned this pull request
Jan 26, 2019

Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@T4rk1nT4rk1nT4rk1n left review comments

+2 more reviewers

@rpkylerpkylerpkyle left review comments
@Marc-Andre-RivetMarc-Andre-RivetMarc-Andre-Rivet approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@alexcjohnson@Marc-Andre-Rivet@T4rk1n@rpkyle