Skip to content

Adding pointcloud - #850

Merged
etpinard merged 11 commits into
plotly:masterfrom
monfera:pointcloud-squashed
Sep 7, 2016
Merged

Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom
monfera:pointcloud-squashed

Conversation

@monfera

@monferamonfera commented Aug 12, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains the plotly.js part of the new pointcloud2d trace type.

Work left involves

  • changing certain things about sizing
  • removing some disused marker options
  • image test cases
  • npm publish gl-pointcloud2d

@monfera
monferaforce-pushed the pointcloud-squashed branch from db35191 to 98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard reviewed Aug 12, 2016
View reviewed changes
Comment threadlib/index-gl2d.js Outdated

Plotly.register([
require('./scattergl'),
require('./pointcloud2d'),

@etpinardetpinardAug 12, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !

@monferamonferaAug 12, 2016

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done

@monfera
monferaforce-pushed the pointcloud-squashed branch from 98f90ad to 0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard added this to the v1.17.0 milestone Aug 12, 2016
@monfera
monferaforce-pushed the pointcloud-squashed branch from 553975d to b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed the pointcloud-squashed branch 3 times, most recently from 1860058 to 2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard reviewed Sep 1, 2016
View reviewed changes
Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
x: scatterglAttrs.x,
y: scatterglAttrs.y,
xy: {

@etpinardetpinardSep 1, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true

@etpinard

etpinard commented Sep 1, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

@monfera Looks like the the autoscale and reset scale mode bar buttons don't work

gifrecord_2016-09-01_180432

I suspect that's caused by the doAutorange not finding all the required info.

We might want to have a look at 330c5f3

@etpinard

etpinard commented Sep 1, 2016

Copy link
Copy Markdown
Contributor

Apart from the above comment and a few naming / styling issues this PR is looking amazing.

@monfera Thanks for all your hard work!

@monfera

monfera commented Sep 1, 2016

Copy link
Copy Markdown
ContributorAuthor

@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!

@monfera

monfera commented Sep 1, 2016

Copy link
Copy Markdown
ContributorAuthor

@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image

@etpinardetpinard removed this from the v1.17.0 milestone Sep 7, 2016
@monfera

monfera commented Sep 7, 2016

Copy link
Copy Markdown
ContributorAuthor

@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!

@etpinardetpinard added this to the v1.17.0 milestone Sep 7, 2016
@monferamonfera changed the title [WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard reviewed Sep 7, 2016
View reviewed changes
Comment threadsrc/traces/pointcloud/convert.js
if(xy) {

positions = xy;
len = xy.length >>> 1;

@etpinardetpinardSep 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).

etpinard
etpinard reviewed Sep 7, 2016
View reviewed changes
Comment threadsrc/traces/pointcloud/convert.js

positions = xy;

// dividing xy.length by 2 and truncating to integer if xy.length was not even

@etpinardetpinardSep 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!

@etpinard

etpinard commented Sep 7, 2016

Copy link
Copy Markdown
Contributor

Amazing work 💃

@etpinard
etpinard merged commit 06af109 into plotly:masterSep 7, 2016
This was referenced Sep 7, 2016
Closed
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

featuresomething new

Projects

None yet

Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Adding pointcloud by monfera · Pull Request #850 · plotly/plotly.js · GitHub
Skip to content
Adding pointcloud - #850
Merged
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Sep 7, 2016
Merged
Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Conversation
@monfera
@monferamonfera
commented
Aug 12, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR contains the plotly.js part of the new pointcloud2d trace type.
Work left involves
  •  changing certain things about sizing
  •  removing some disused marker options
  •  image test cases
  •  npm publish gl-pointcloud2d
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
db35191 to
98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard
reviewed
Aug 12, 2016
 View reviewed changes

Comment threadlib/index-gl2d.js
Outdated


Plotly.register([
 require('./scattergl'),
 require('./pointcloud2d'),
@etpinardetpinardAug 12, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !
@monferamonferaAug 12, 2016

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
98f90ad to
0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard
added this to the v1.17.0 milestone
Aug 12, 2016
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
553975d to
b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
3 times, most recently
from
1860058 to
2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard
reviewed
Sep 1, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
 x: scatterglAttrs.x,
 y: scatterglAttrs.y,
 xy: {
@etpinardetpinardSep 1, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true
@etpinard
etpinard
commented
Sep 1, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
@monfera Looks like the the autoscale and reset scale mode bar buttons don't work
gifrecord_2016-09-01_180432
I suspect that's caused by the doAutorange not finding all the required info.
We might want to have a look at 330c5f3
@etpinard
etpinard
commented
Sep 1, 2016

Copy link


Copy Markdown

Contributor
Apart from the above comment and a few naming / styling issues this PR is looking amazing.
@monfera Thanks for all your hard work!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image
@etpinardetpinard
removed this from the v1.17.0 milestone
Sep 7, 2016
@monfera
monfera
commented
Sep 7, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!
@etpinardetpinard
added this to the v1.17.0 milestone
Sep 7, 2016
@monferamonfera
changed the title
[WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js
 if(xy) {

 positions = xy;
 len = xy.length >>> 1;
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js

 positions = xy;

 // dividing xy.length by 2 and truncating to integer if xy.length was not even
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!
@etpinard
etpinard
commented
Sep 7, 2016

Copy link


Copy Markdown

Contributor
Amazing work 💃
@etpinard
etpinard
merged commit 06af109
into
plotly:masterSep 7, 2016

This was referenced Sep 7, 2016

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Adding pointcloud by monfera · Pull Request #850 · plotly/plotly.js · GitHub
Skip to content
Adding pointcloud - #850
Merged
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Sep 7, 2016
Merged
Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Conversation
@monfera
@monferamonfera
commented
Aug 12, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR contains the plotly.js part of the new pointcloud2d trace type.
Work left involves
  •  changing certain things about sizing
  •  removing some disused marker options
  •  image test cases
  •  npm publish gl-pointcloud2d
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
db35191 to
98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard
reviewed
Aug 12, 2016
 View reviewed changes

Comment threadlib/index-gl2d.js
Outdated


Plotly.register([
 require('./scattergl'),
 require('./pointcloud2d'),
@etpinardetpinardAug 12, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !
@monferamonferaAug 12, 2016

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
98f90ad to
0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard
added this to the v1.17.0 milestone
Aug 12, 2016
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
553975d to
b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
3 times, most recently
from
1860058 to
2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard
reviewed
Sep 1, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
 x: scatterglAttrs.x,
 y: scatterglAttrs.y,
 xy: {
@etpinardetpinardSep 1, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true
@etpinard
etpinard
commented
Sep 1, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
@monfera Looks like the the autoscale and reset scale mode bar buttons don't work
gifrecord_2016-09-01_180432
I suspect that's caused by the doAutorange not finding all the required info.
We might want to have a look at 330c5f3
@etpinard
etpinard
commented
Sep 1, 2016

Copy link


Copy Markdown

Contributor
Apart from the above comment and a few naming / styling issues this PR is looking amazing.
@monfera Thanks for all your hard work!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image
@etpinardetpinard
removed this from the v1.17.0 milestone
Sep 7, 2016
@monfera
monfera
commented
Sep 7, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!
@etpinardetpinard
added this to the v1.17.0 milestone
Sep 7, 2016
@monferamonfera
changed the title
[WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js
 if(xy) {

 positions = xy;
 len = xy.length >>> 1;
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js

 positions = xy;

 // dividing xy.length by 2 and truncating to integer if xy.length was not even
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!
@etpinard
etpinard
commented
Sep 7, 2016

Copy link


Copy Markdown

Contributor
Amazing work 💃
@etpinard
etpinard
merged commit 06af109
into
plotly:masterSep 7, 2016

This was referenced Sep 7, 2016

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Adding pointcloud by monfera · Pull Request #850 · plotly/plotly.js · GitHub
Skip to content
Adding pointcloud - #850
Merged
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Sep 7, 2016
Merged
Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Conversation
@monfera
@monferamonfera
commented
Aug 12, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR contains the plotly.js part of the new pointcloud2d trace type.
Work left involves
  •  changing certain things about sizing
  •  removing some disused marker options
  •  image test cases
  •  npm publish gl-pointcloud2d
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
db35191 to
98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard
reviewed
Aug 12, 2016
 View reviewed changes

Comment threadlib/index-gl2d.js
Outdated


Plotly.register([
 require('./scattergl'),
 require('./pointcloud2d'),
@etpinardetpinardAug 12, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !
@monferamonferaAug 12, 2016

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
98f90ad to
0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard
added this to the v1.17.0 milestone
Aug 12, 2016
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
553975d to
b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
3 times, most recently
from
1860058 to
2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard
reviewed
Sep 1, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
 x: scatterglAttrs.x,
 y: scatterglAttrs.y,
 xy: {
@etpinardetpinardSep 1, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true
@etpinard
etpinard
commented
Sep 1, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
@monfera Looks like the the autoscale and reset scale mode bar buttons don't work
gifrecord_2016-09-01_180432
I suspect that's caused by the doAutorange not finding all the required info.
We might want to have a look at 330c5f3
@etpinard
etpinard
commented
Sep 1, 2016

Copy link


Copy Markdown

Contributor
Apart from the above comment and a few naming / styling issues this PR is looking amazing.
@monfera Thanks for all your hard work!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image
@etpinardetpinard
removed this from the v1.17.0 milestone
Sep 7, 2016
@monfera
monfera
commented
Sep 7, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!
@etpinardetpinard
added this to the v1.17.0 milestone
Sep 7, 2016
@monferamonfera
changed the title
[WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js
 if(xy) {

 positions = xy;
 len = xy.length >>> 1;
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js

 positions = xy;

 // dividing xy.length by 2 and truncating to integer if xy.length was not even
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!
@etpinard
etpinard
commented
Sep 7, 2016

Copy link


Copy Markdown

Contributor
Amazing work 💃
@etpinard
etpinard
merged commit 06af109
into
plotly:masterSep 7, 2016

This was referenced Sep 7, 2016

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Adding pointcloud by monfera · Pull Request #850 · plotly/plotly.js · GitHub
Skip to content
Adding pointcloud - #850
Merged
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Sep 7, 2016
Merged
Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Conversation
@monfera
@monferamonfera
commented
Aug 12, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR contains the plotly.js part of the new pointcloud2d trace type.
Work left involves
  •  changing certain things about sizing
  •  removing some disused marker options
  •  image test cases
  •  npm publish gl-pointcloud2d
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
db35191 to
98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard
reviewed
Aug 12, 2016
 View reviewed changes

Comment threadlib/index-gl2d.js
Outdated


Plotly.register([
 require('./scattergl'),
 require('./pointcloud2d'),
@etpinardetpinardAug 12, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !
@monferamonferaAug 12, 2016

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
98f90ad to
0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard
added this to the v1.17.0 milestone
Aug 12, 2016
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
553975d to
b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
3 times, most recently
from
1860058 to
2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard
reviewed
Sep 1, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
 x: scatterglAttrs.x,
 y: scatterglAttrs.y,
 xy: {
@etpinardetpinardSep 1, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true
@etpinard
etpinard
commented
Sep 1, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
@monfera Looks like the the autoscale and reset scale mode bar buttons don't work
gifrecord_2016-09-01_180432
I suspect that's caused by the doAutorange not finding all the required info.
We might want to have a look at 330c5f3
@etpinard
etpinard
commented
Sep 1, 2016

Copy link


Copy Markdown

Contributor
Apart from the above comment and a few naming / styling issues this PR is looking amazing.
@monfera Thanks for all your hard work!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image
@etpinardetpinard
removed this from the v1.17.0 milestone
Sep 7, 2016
@monfera
monfera
commented
Sep 7, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!
@etpinardetpinard
added this to the v1.17.0 milestone
Sep 7, 2016
@monferamonfera
changed the title
[WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js
 if(xy) {

 positions = xy;
 len = xy.length >>> 1;
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js

 positions = xy;

 // dividing xy.length by 2 and truncating to integer if xy.length was not even
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!
@etpinard
etpinard
commented
Sep 7, 2016

Copy link


Copy Markdown

Contributor
Amazing work 💃
@etpinard
etpinard
merged commit 06af109
into
plotly:masterSep 7, 2016

This was referenced Sep 7, 2016

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Adding pointcloud by monfera · Pull Request #850 · plotly/plotly.js · GitHub
Skip to content
Adding pointcloud - #850
Merged
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Sep 7, 2016
Merged
Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Conversation
@monfera
@monferamonfera
commented
Aug 12, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR contains the plotly.js part of the new pointcloud2d trace type.
Work left involves
  •  changing certain things about sizing
  •  removing some disused marker options
  •  image test cases
  •  npm publish gl-pointcloud2d
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
db35191 to
98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard
reviewed
Aug 12, 2016
 View reviewed changes

Comment threadlib/index-gl2d.js
Outdated


Plotly.register([
 require('./scattergl'),
 require('./pointcloud2d'),
@etpinardetpinardAug 12, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !
@monferamonferaAug 12, 2016

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
98f90ad to
0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard
added this to the v1.17.0 milestone
Aug 12, 2016
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
553975d to
b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
3 times, most recently
from
1860058 to
2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard
reviewed
Sep 1, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
 x: scatterglAttrs.x,
 y: scatterglAttrs.y,
 xy: {
@etpinardetpinardSep 1, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true
@etpinard
etpinard
commented
Sep 1, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
@monfera Looks like the the autoscale and reset scale mode bar buttons don't work
gifrecord_2016-09-01_180432
I suspect that's caused by the doAutorange not finding all the required info.
We might want to have a look at 330c5f3
@etpinard
etpinard
commented
Sep 1, 2016

Copy link


Copy Markdown

Contributor
Apart from the above comment and a few naming / styling issues this PR is looking amazing.
@monfera Thanks for all your hard work!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image
@etpinardetpinard
removed this from the v1.17.0 milestone
Sep 7, 2016
@monfera
monfera
commented
Sep 7, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!
@etpinardetpinard
added this to the v1.17.0 milestone
Sep 7, 2016
@monferamonfera
changed the title
[WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js
 if(xy) {

 positions = xy;
 len = xy.length >>> 1;
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js

 positions = xy;

 // dividing xy.length by 2 and truncating to integer if xy.length was not even
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!
@etpinard
etpinard
commented
Sep 7, 2016

Copy link


Copy Markdown

Contributor
Amazing work 💃
@etpinard
etpinard
merged commit 06af109
into
plotly:masterSep 7, 2016

This was referenced Sep 7, 2016

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Adding pointcloud by monfera · Pull Request #850 · plotly/plotly.js · GitHub
Skip to content
Adding pointcloud - #850
Merged
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Sep 7, 2016
Merged
Adding pointcloud#850
etpinard merged 11 commits into
plotly:masterfrom 
monfera:pointcloud-squashed
Conversation
@monfera
@monferamonfera
commented
Aug 12, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
This PR contains the plotly.js part of the new pointcloud2d trace type.
Work left involves
  •  changing certain things about sizing
  •  removing some disused marker options
  •  image test cases
  •  npm publish gl-pointcloud2d
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
db35191 to
98f90adCompareAugust 12, 2016 15:33
etpinard
etpinard
reviewed
Aug 12, 2016
 View reviewed changes

Comment threadlib/index-gl2d.js
Outdated


Plotly.register([
 require('./scattergl'),
 require('./pointcloud2d'),
@etpinardetpinardAug 12, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this pointcloud !
@monferamonferaAug 12, 2016

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, now done
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
98f90ad to
0deacccCompareAugust 12, 2016 16:08
@etpinardetpinard
added this to the v1.17.0 milestone
Aug 12, 2016
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
from
553975d to
b45d3d7CompareAugust 15, 2016 15:05
@monfera
monferaforce-pushed
the
pointcloud-squashed
branch
3 times, most recently
from
1860058 to
2f1005fCompareSeptember 1, 2016 17:27
etpinard
etpinard
reviewed
Sep 1, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/attributes.js
module.exports = {
 x: scatterglAttrs.x,
 y: scatterglAttrs.y,
 xy: {
@etpinardetpinardSep 1, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a dream come true
@etpinard
etpinard
commented
Sep 1, 2016•

edited

Loading

Copy link


Copy Markdown

Contributor
@monfera Looks like the the autoscale and reset scale mode bar buttons don't work
gifrecord_2016-09-01_180432
I suspect that's caused by the doAutorange not finding all the required info.
We might want to have a look at 330c5f3
@etpinard
etpinard
commented
Sep 1, 2016

Copy link


Copy Markdown

Contributor
Apart from the above comment and a few naming / styling issues this PR is looking amazing.
@monfera Thanks for all your hard work!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard thanks for all your comments, they look easy, i.e. perfect for a morning ramp-up. Special thanks for catching this interaction issue too!
@monfera
monfera
commented
Sep 1, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard I just wanted to mention that I had some unpushed commits in gl-gis/pointcloud-2d and the image now should come out like this (see the difference in the opacity, size and boundary).
image
@etpinardetpinard
removed this from the v1.17.0 milestone
Sep 7, 2016
@monfera
monfera
commented
Sep 7, 2016

Copy link


Copy Markdown

ContributorAuthor
@etpinard for the record the solution to the plot disappearance issue on +/-/reset you found is here in stackgl: stackgl/gl-shader#16 - thanks again for catching it!
@etpinardetpinard
added this to the v1.17.0 milestone
Sep 7, 2016
@monferamonfera
changed the title
[WIP] adding point cloudAdding pointcloudSep 7, 2016
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js
 if(xy) {

 positions = xy;
 len = xy.length >>> 1;
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bitwise ops are cool 😎 but can you add a short comment above describing what this does (for folks unfamiliar with them).
etpinard
etpinard
reviewed
Sep 7, 2016
 View reviewed changes

Comment threadsrc/traces/pointcloud/convert.js

 positions = xy;

 // dividing xy.length by 2 and truncating to integer if xy.length was not even
@etpinardetpinardSep 7, 2016

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much!
@etpinard
etpinard
commented
Sep 7, 2016

Copy link


Copy Markdown

Contributor
Amazing work 💃
@etpinard
etpinard
merged commit 06af109
into
plotly:masterSep 7, 2016

This was referenced Sep 7, 2016

Closed


Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

featuresomething new

Projects


None yet


Milestone

v1.17.0

Development

Successfully merging this pull request may close these issues.

4 participants

@monfera@etpinard@rreusser@cldougl