Skip to content

Revert "SelectPanel: Prepare for non-anchored variants" - #5255

Merged
siddharthkp merged 1 commit into
mainfrom
revert-5230-selectpanel-use-anchored-position
Nov 8, 2024
Merged

Revert "SelectPanel: Prepare for non-anchored variants"#5255
siddharthkp merged 1 commit into
mainfrom
revert-5230-selectpanel-use-anchored-position

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Nov 8, 2024•
edited
Loading

Copy link
Copy Markdown
Member

@siddharthkpsiddharthkp self-assigned this Nov 8, 2024
@changeset-bot

This comment was marked as resolved.

Sign in to view
@github-actionsgithub-actionsBot added the staff Author is a staff member label Nov 8, 2024
@siddharthkpsiddharthkp added skip changeset This change does not need a changelog and removed staff Author is a staff member labels Nov 8, 2024
@github-actions

github-actionsBot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 8, 2024
@siddharthkp
siddharthkp marked this pull request as ready for review November 8, 2024 21:02
@siddharthkp
siddharthkp requested a review from a team as a code ownerNovember 8, 2024 21:02
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5255 November 8, 2024 21:04 Inactive
@siddharthkpsiddharthkp added integration-tests: skipped manually Changes in this PR do not require an integration test integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm integration-tests: skipped manually Changes in this PR do not require an integration test labels Nov 8, 2024
@github-actions

github-actionsBot commented Nov 8, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js98.64 KB (-0.22% 🔽)
packages/react/dist/browser.umd.js99.05 KB (-0.18% 🔽)

@siddharthkp
siddharthkp added this pull request to the merge queueNov 8, 2024
@primer-integration

primer-integrationBot commented Nov 8, 2024

Copy link
Copy Markdown

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350652

@github-merge-queue
github-merge-queueBot removed this pull request from the merge queue due to failed status checks Nov 8, 2024
@primer-integration

primer-integrationBot commented Nov 8, 2024

Copy link
Copy Markdown

🔴 golden-jobs completed with status failure.

@github-actionsgithub-actionsBot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 8, 2024
@github-actionsgithub-actionsBot added the integration-tests: failing Changes in this PR cause breaking changes in gh/gh label Nov 8, 2024
@siddharthkp
siddharthkp added this pull request to the merge queueNov 8, 2024
Merged via the queue into main with commit 64802f1Nov 8, 2024
@siddharthkp
siddharthkp deleted the revert-5230-selectpanel-use-anchored-position branch November 8, 2024 21:39
This was referenced Nov 8, 2024
Closed
Merged
siddharthkp added a commit that referenced this pull request Nov 11, 2024
@siddharthkp
Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)…
dc3d2c0
…" (#5255)"
This reverts commit 64802f1.
@siddharthkpsiddharthkp mentioned this pull request Nov 11, 2024
Merged
github-merge-queueBot pushed a commit that referenced this pull request Nov 12, 2024
@siddharthkp
Bring back#5255"SelectPanel: Prepare for non-anchored variants" (#5262
fca4ec9
)
* Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)" (#5255)"
This reverts commit 64802f1.
* Revert "tiny formatting to make it easier to review"
This reverts commit f0be480.
* different way of writing the same thing
siddharthkp added a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Bring back#5255"SelectPanel: Prepare for non-anchored varia…
089306c
…nts" (#5…"
This reverts commit fca4ec9.
github-merge-queueBot pushed a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Bring back#5255"SelectPanel: Prepare for non-anchored varia…
0389f42
…nts" (#5…" (#5272)
This reverts commit fca4ec9.
siddharthkp added a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Bring back#5255"SelectPanel: Prepare for non-anchored varia…
37e10d0
…nts" (#5…"
This reverts commit fca4ec9.
siddharthkp added a commit that referenced this pull request Nov 13, 2024
@siddharthkp
Revert "Revert "SelectPanel: Prepare for non-anchored variants (#5230)…
2d6fa8f
…" (#5255)"
This reverts commit 64802f1.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@francineluccafrancineluccafrancinelucca approved these changes

Assignees

@siddharthkpsiddharthkp

Labels

integration-tests: failingChanges in this PR cause breaking changes in gh/ghskip changesetThis change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@siddharthkp@joshblack@francinelucca