Skip to content

Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored variants"" - #5272

Merged
siddharthkp merged 1 commit into
mainfrom
revert-5262-revert-5255-revert-5230-selectpanel-use-anchored-position
Nov 13, 2024
Merged

Revert "Bring back #5255 "SelectPanel: Prepare for non-anchored variants""#5272
siddharthkp merged 1 commit into
mainfrom
revert-5262-revert-5255-revert-5230-selectpanel-use-anchored-position

Conversation

@siddharthkp

@siddharthkpsiddharthkp commented Nov 13, 2024

Copy link
Copy Markdown
Member

@changeset-bot

changeset-botBot commented Nov 13, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 089306c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@siddharthkpsiddharthkp self-assigned this Nov 13, 2024
@siddharthkpsiddharthkp added the skip changeset This change does not need a changelog label Nov 13, 2024
@github-actionsgithub-actionsBot added the staff Author is a staff member label Nov 13, 2024
@siddharthkp
siddharthkp marked this pull request as ready for review November 13, 2024 15:25
@siddharthkp
siddharthkp requested a review from a team as a code ownerNovember 13, 2024 15:25
@github-actions

github-actionsBot commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5272 November 13, 2024 15:27 Inactive
@github-actions

github-actionsBot commented Nov 13, 2024

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js98.79 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js98.99 KB (-0.19% 🔽)

@siddharthkpsiddharthkp added the integration-tests: skipped manually Changes in this PR do not require an integration test label Nov 13, 2024
@siddharthkp
siddharthkp added this pull request to the merge queueNov 13, 2024
Merged via the queue into main with commit 0389f42Nov 13, 2024
@siddharthkp
siddharthkp deleted the revert-5262-revert-5255-revert-5230-selectpanel-use-anchored-position branch November 13, 2024 15:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshblackjoshblackjoshblack approved these changes
@TylerJDevTylerJDevAwaiting requested review from TylerJDevTylerJDev is a code owner automatically assigned from primer/engineer-reviewers

Assignees

@siddharthkpsiddharthkp

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmintegration-tests: skipped manuallyChanges in this PR do not require an integration testskip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siddharthkp@joshblack