Uh oh!
There was an error while loading. Please reload this page.
BugFix: Use first-of-type for buttongroup selector - #5343
Merged
Conversation
🦋 Changeset detectedLatest commit: 426beb0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
Contributor
size-limit report 📦
|
langermank
approved these changes
Dec 3, 2024
francinelucca added a commit
that referenced
this pull request
Dec 5, 2024
This reverts commit 70005b8.
13 tasks
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While cleaning up the ButtonGroup feature flags #5339, I noticed a bug in the Overlay screenshots where the last-child button didn't have the correct border radius.
This is because of the hidden Tooltip component in the group of items. I updated the selector to use
:is(button, a)and:first-of-typeand:last-of-typepseudo-classes to fix the issue. The updated screenshots show the issue.Changelog
New
Changed
Fix issue in ButtonGroup Overlay screenshots by updating the selector to use
:is(button, a)and:first-of-typeand:last-of-typepseudo-classes.Removed
Rollout strategy
Testing & Reviewing
Merge checklist