Skip to content

Revert ButtonGroup changes from last release 37.7.0 - #5412

Merged
jonrohan merged 4 commits into
mainfrom
revert_buttongroup_changes
Dec 11, 2024
Merged

Revert ButtonGroup changes from last release 37.7.0#5412
jonrohan merged 4 commits into
mainfrom
revert_buttongroup_changes

Conversation

@jonrohan

@jonrohanjonrohan commented Dec 11, 2024

Copy link
Copy Markdown
Member

Reverts #5339
Reverts #5343

This caused some bugs in the ButtonGroup component in production where the ButtonGroup had mixed types button,a

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@jonrohan
jonrohan requested review from a team as code ownersDecember 11, 2024 00:01
@changeset-bot

changeset-botBot commented Dec 11, 2024•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: b2e1fa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actionsgithub-actionsBot added the staff Author is a staff member label Dec 11, 2024
@github-actions

github-actionsBot commented Dec 11, 2024

Copy link
Copy Markdown
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actionsgithub-actionsBot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 11, 2024
@github-actions
github-actionsBottemporarily deployed to storybook-preview-5412 December 11, 2024 00:04 Inactive
@github-actions

github-actionsBot commented Dec 11, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

size-limit report 📦

PathSize
packages/react/dist/browser.esm.js102.59 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js102.94 KB (+0.09% 🔺)

@github-actions
github-actionsBottemporarily deployed to storybook-preview-5412 December 11, 2024 00:17 Inactive
@jonrohanjonrohan added the skip changeset This change does not need a changelog label Dec 11, 2024
@jonrohan
jonrohan added this pull request to the merge queueDec 11, 2024
Merged via the queue into main with commit d9e62e9Dec 11, 2024
@jonrohan
jonrohan deleted the revert_buttongroup_changes branch December 11, 2024 00:36
@francineluccafrancinelucca mentioned this pull request Dec 9, 2024
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@francineluccafrancineluccafrancinelucca approved these changes
@maximedegrevemaximedegreveAwaiting requested review from maximedegrevemaximedegreve was automatically assigned from primer/design-reviewers

Assignees

No one assigned

Labels

integration-tests: recommendedThis change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpmskip changesetThis change does not need a changelogstaffAuthor is a staff member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jonrohan@francinelucca